On Mon, Jun 13, 2016 at 8:01 PM, Chris Packham judge.packham@gmail.com wrote:

Hi Mark,

On Mon, Jun 13, 2016 at 5:00 PM, Mark Tomlinson mark.tomlinson@alliedtelesis.co.nz wrote:

...

The __get_unaligned_le* functions may not be declared on all platforms. Instead, get_unaligned_le* should be used. On many platforms both of these are the same function.

Change-Id: If28222615e85a6f34f3fde42eb21c6f56a2cb988

We shouldn't let these leak out of $work. This doesn't really mean anything to anyone without access to our internal review system.

...

Reviewed-by: Chris Packham chris.packham@alliedtelesis.co.nz

For what it's worth - this is me I usually post with my gmail account because it's better for managing high volume mailing lists.

Also your signed-off line is missing.

...

---

drivers/usb/eth/smsc95xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c index 08eaed5..7d9abfd 100644 --- a/drivers/usb/eth/smsc95xx.c +++ b/drivers/usb/eth/smsc95xx.c @@ -391,8 +391,8 @@ static int smsc95xx_write_hwaddr_common(struct usb_device *udev, struct smsc95xx_private *priv, unsigned char *enetaddr) {

•   u32 addr_lo = __get_unaligned_le32(&enetaddr[0]);
  

•   u32 addr_hi = __get_unaligned_le16(&enetaddr[4]);
  

•   u32 addr_lo = get_unaligned_le32(&enetaddr[0]);
  

•   u32 addr_hi = get_unaligned_le16(&enetaddr[4]);
    int ret;
  
    /* set hardware address */
  

-- 2.8.4

---

U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

The __get_unaligned_le* functions may not be declared on all platforms. Instead, get_unaligned_le* should be used. On many platforms both of these are the same function.

Signed-off-by: Chris Packham judge.packham@gmail.com --- Hi Joe,

Mark didn't manage to get to this before he went on leave so I've taken it over.

Changes in v2: - Remove gerrit reference from commit message - Sign-off and change author

drivers/usb/eth/smsc95xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c index 08eaed5..7d9abfd 100644 --- a/drivers/usb/eth/smsc95xx.c +++ b/drivers/usb/eth/smsc95xx.c @@ -391,8 +391,8 @@ static int smsc95xx_write_hwaddr_common(struct usb_device *udev, struct smsc95xx_private *priv, unsigned char *enetaddr) { - u32 addr_lo = __get_unaligned_le32(&enetaddr[0]); - u32 addr_hi = __get_unaligned_le16(&enetaddr[4]); + u32 addr_lo = get_unaligned_le32(&enetaddr[0]); + u32 addr_hi = get_unaligned_le16(&enetaddr[4]); int ret;

/* set hardware address */