[U-Boot] [PATCH] common: usb: fix checking condition
From: Peng Fan peng.fan@nxp.com
We support max USB_MAXENDPOINTS, so need to use "epno >= USB_MAXENDPOINTS", but not "epno > USB_MAXENDPOINTS". If use ">", we may exceeds the array of if_desc->ep_desc.
Signed-off-by: Peng Fan peng.fan@nxp.com Cc: Simon Glass sjg@chromium.org Cc: Hans de Goede hdegoede@redhat.com Cc: Marek Vasut marex@denx.de Cc: Paul Kocialkowski contact@paulk.fr Cc: "Stefan Brüns" stefan.bruens@rwth-aachen.de Cc: Vincent Palatin vpalatin@chromium.org --- common/usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/usb.c b/common/usb.c index 9f67cc1..c7b8b0e 100644 --- a/common/usb.c +++ b/common/usb.c @@ -456,7 +456,7 @@ static int usb_parse_config(struct usb_device *dev, } epno = dev->config.if_desc[ifno].no_of_ep; if_desc = &dev->config.if_desc[ifno]; - if (epno > USB_MAXENDPOINTS) { + if (epno >= USB_MAXENDPOINTS) { printf("Interface %d has too many endpoints!\n", if_desc->desc.bInterfaceNumber); return -EINVAL;
On Tuesday, January 12, 2016 at 08:57:01 AM, Peng Fan wrote:
From: Peng Fan peng.fan@nxp.com
We support max USB_MAXENDPOINTS, so need to use "epno >= USB_MAXENDPOINTS", but not "epno > USB_MAXENDPOINTS". If use ">", we may exceeds the array of if_desc->ep_desc.
Signed-off-by: Peng Fan peng.fan@nxp.com Cc: Simon Glass sjg@chromium.org Cc: Hans de Goede hdegoede@redhat.com Cc: Marek Vasut marex@denx.de Cc: Paul Kocialkowski contact@paulk.fr Cc: "Stefan Brüns" stefan.bruens@rwth-aachen.de Cc: Vincent Palatin vpalatin@chromium.org
Acked-by: Marek Vasut marex@denx.de
common/usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/usb.c b/common/usb.c index 9f67cc1..c7b8b0e 100644 --- a/common/usb.c +++ b/common/usb.c @@ -456,7 +456,7 @@ static int usb_parse_config(struct usb_device *dev, } epno = dev->config.if_desc[ifno].no_of_ep; if_desc = &dev->config.if_desc[ifno];
if (epno > USB_MAXENDPOINTS) {
if (epno >= USB_MAXENDPOINTS) { printf("Interface %d has too many endpoints!\n", if_desc->desc.bInterfaceNumber); return -EINVAL;
Best regards, Marek Vasut
participants (2)
-
Marek Vasut -
Peng Fan