[PATCH v1 00/49] add support for broadcom NS3 soc
This patch series adds support for Broadcom Northstar 3 SoC. NS3 is a octo-core 64-bit ARMv8 Cortex-A72 processors targeting a broad range of networking applications.
Abhishek Shah (1): board: ns3: add api to save boot parameters passed from BL31
Bharat Gooty (2): include/configs: ns3: add env variables for Linux boot include/configs: ns3: add support for flashing images
Bharat Kumar Reddy Gooty (3): board: ns3: program GIC LPI tables board: ns3: limit U-boot relocation within 16MB memory cmd: bcm: add command for chimp hand shake
Corneliu Doban (1): cmd: gpt: add eMMC and GPT support
Pramod Kumar (4): arm: dts: ns3: add emmc node arm: dts: ns3: add sp805 watchdog node board: ns3: add FIT image its file board: ns3: add development keys used in FIT
Rajesh Ravi (1): board: ns3: default reset type to L3
Ray Jui (1): board: ns3: define ddr memory layout
Rayagonda Kokatanur (27): board: ns3: add support for Broadcom Northstar 3 arm: cpu: armv8: add L3 memory flush support configs: ns3: enable clock subsystem arm: dts: ns3: add clock dt node configs: ns3: enable pinctrl driver dt-bindings: pinctrl: add ns3 pads definition arm: dts: ns3: add pinctrl node arm: dts: ns3: add gpio node gpio: do not include <asm/arch/gpio.h> on TARGET_BCMNS3 configs: ns3: enable BCM IPROC mmc driver configs: ns3: enable mmc commands arm: dts: ns3: add qspi node dt-bindings: memory: ns3: add memory definitions arm: dts: ns3: add i2c node configs: ns3: enable gpt commands configs: ns3: enable EXT4 and FAT fs support configs: ns3: enable sp805 watchdog driver board: ns3: start sp805 watchdog service dt-bindings: memory: ns3: update GIC LPI address configs: ns3: enable GIC ITS LPI table programing dt-bindings: memory: ns3: add ddr memory definition configs: ns3: enable FIT config configs: ns3: enable PXE boot command configs: ns3: enable RPMB configs: ns3: enable tee and optee driver configs: ns3: env in mmc board: ns3: check chimp handshake status
Sheetal Tigadoli (1): common: ns3: add error logging support
Srinath Mannam (1): arm: dts: ns3: add PAXB PCIe host and phy node
Trac Hoang (2): board: ns3: add generic MCU IPC command send API cmd: bcm: add nitro boot command
Vikas Gupta (3): board: ns3: add optee based bnxt fw load driver arm: dts: ns3: add optee node cmd: bcm: add nitro image load commands
Vladimir Olovyannikov (2): board: ns3: kconfig: extend board kconfig with specific commands cmd: bcm: add broadcom error log setup command
arch/arm/Kconfig | 10 + arch/arm/cpu/armv8/Makefile | 1 + arch/arm/cpu/armv8/bcmns3/Makefile | 5 + arch/arm/cpu/armv8/bcmns3/lowlevel.S | 99 ++ arch/arm/dts/Makefile | 2 + arch/arm/dts/ns3-board.dts | 105 ++ arch/arm/dts/ns3-clock.dtsi | 34 + arch/arm/dts/ns3-pinctrl.dtsi | 321 +++++++ arch/arm/dts/ns3.dtsi | 265 ++++++ arch/arm/include/asm/arch-bcmns3/bl33_info.h | 26 + arch/arm/include/asm/gpio.h | 2 +- board/broadcom/bcmns3/Kconfig | 25 + board/broadcom/bcmns3/Makefile | 7 + board/broadcom/bcmns3/chimp_optee.c | 154 +++ board/broadcom/bcmns3/fit/keys/dev.crt | 21 + board/broadcom/bcmns3/fit/keys/dev.key | 28 + board/broadcom/bcmns3/fit/multi.its | 59 ++ board/broadcom/bcmns3/mcu_cmd.c | 49 + board/broadcom/bcmns3/mcu_cmd.h | 13 + board/broadcom/bcmns3/ns3.c | 263 +++++ cmd/Kconfig | 2 + cmd/Makefile | 2 + cmd/bcm/Kconfig | 12 + cmd/bcm/Makefile | 7 + cmd/bcm/chimp_boot.c | 36 + cmd/bcm/chimp_handshake.c | 32 + cmd/bcm/elog.h | 64 ++ cmd/bcm/logsetup.c | 432 +++++++++ cmd/bcm/nitro_image_load.c | 99 ++ cmd/gpt.c | 95 ++ common/Kconfig | 8 + common/Makefile | 1 + common/bcm_elog.c | 49 + common/console.c | 22 + configs/bcm_ns3_defconfig | 57 ++ include/bcm_elog.h | 37 + include/brcm/chimp.h | 48 + include/configs/bcm_ns3.h | 901 ++++++++++++++++++ include/dt-bindings/memory/bcm-ns3-mc.h | 65 ++ .../dt-bindings/pinctrl/brcm,pinctrl-ns3.h | 41 + 40 files changed, 3498 insertions(+), 1 deletion(-) create mode 100644 arch/arm/cpu/armv8/bcmns3/Makefile create mode 100644 arch/arm/cpu/armv8/bcmns3/lowlevel.S create mode 100644 arch/arm/dts/ns3-board.dts create mode 100644 arch/arm/dts/ns3-clock.dtsi create mode 100644 arch/arm/dts/ns3-pinctrl.dtsi create mode 100644 arch/arm/dts/ns3.dtsi create mode 100644 arch/arm/include/asm/arch-bcmns3/bl33_info.h create mode 100644 board/broadcom/bcmns3/Kconfig create mode 100644 board/broadcom/bcmns3/Makefile create mode 100644 board/broadcom/bcmns3/chimp_optee.c create mode 100644 board/broadcom/bcmns3/fit/keys/dev.crt create mode 100644 board/broadcom/bcmns3/fit/keys/dev.key create mode 100644 board/broadcom/bcmns3/fit/multi.its create mode 100644 board/broadcom/bcmns3/mcu_cmd.c create mode 100644 board/broadcom/bcmns3/mcu_cmd.h create mode 100644 board/broadcom/bcmns3/ns3.c create mode 100644 cmd/bcm/Kconfig create mode 100644 cmd/bcm/Makefile create mode 100644 cmd/bcm/chimp_boot.c create mode 100644 cmd/bcm/chimp_handshake.c create mode 100644 cmd/bcm/elog.h create mode 100644 cmd/bcm/logsetup.c create mode 100644 cmd/bcm/nitro_image_load.c create mode 100644 common/bcm_elog.c create mode 100644 configs/bcm_ns3_defconfig create mode 100644 include/bcm_elog.h create mode 100644 include/brcm/chimp.h create mode 100644 include/configs/bcm_ns3.h create mode 100644 include/dt-bindings/memory/bcm-ns3-mc.h create mode 100644 include/dt-bindings/pinctrl/brcm,pinctrl-ns3.h
On 4/27/20 12:47 PM, Rayagonda Kokatanur wrote:
This patch series adds support for Broadcom Northstar 3 SoC.
Please, do keep the CC sane, don't CC everyone.
[...]
arch/arm/Kconfig | 10 + arch/arm/cpu/armv8/Makefile | 1 + arch/arm/cpu/armv8/bcmns3/Makefile | 5 + arch/arm/cpu/armv8/bcmns3/lowlevel.S | 99 ++ arch/arm/dts/Makefile | 2 + arch/arm/dts/ns3-board.dts | 105 ++ arch/arm/dts/ns3-clock.dtsi | 34 + arch/arm/dts/ns3-pinctrl.dtsi | 321 +++++++ arch/arm/dts/ns3.dtsi | 265 ++++++ arch/arm/include/asm/arch-bcmns3/bl33_info.h | 26 + arch/arm/include/asm/gpio.h | 2 +- board/broadcom/bcmns3/Kconfig | 25 + board/broadcom/bcmns3/Makefile | 7 + board/broadcom/bcmns3/chimp_optee.c | 154 +++ board/broadcom/bcmns3/fit/keys/dev.crt | 21 + board/broadcom/bcmns3/fit/keys/dev.key | 28 + board/broadcom/bcmns3/fit/multi.its | 59 ++ board/broadcom/bcmns3/mcu_cmd.c | 49 + board/broadcom/bcmns3/mcu_cmd.h | 13 + board/broadcom/bcmns3/ns3.c | 263 +++++ cmd/Kconfig | 2 + cmd/Makefile | 2 + cmd/bcm/Kconfig | 12 + cmd/bcm/Makefile | 7 + cmd/bcm/chimp_boot.c | 36 + cmd/bcm/chimp_handshake.c | 32 + cmd/bcm/elog.h | 64 ++ cmd/bcm/logsetup.c | 432 +++++++++ cmd/bcm/nitro_image_load.c | 99 ++ cmd/gpt.c | 95 ++
Please split the series into multiple smaller, logical series -- core code, drivers, other stuff. Patching common code should be done in a separate patchset. Also, these custom commands will need to be rethought.
common/Kconfig | 8 + common/Makefile | 1 + common/bcm_elog.c | 49 + common/console.c | 22 + configs/bcm_ns3_defconfig | 57 ++ include/bcm_elog.h | 37 + include/brcm/chimp.h | 48 + include/configs/bcm_ns3.h | 901 ++++++++++++++++++ include/dt-bindings/memory/bcm-ns3-mc.h | 65 ++ .../dt-bindings/pinctrl/brcm,pinctrl-ns3.h | 41 + 40 files changed, 3498 insertions(+), 1 deletion(-) create mode 100644 arch/arm/cpu/armv8/bcmns3/Makefile create mode 100644 arch/arm/cpu/armv8/bcmns3/lowlevel.S create mode 100644 arch/arm/dts/ns3-board.dts create mode 100644 arch/arm/dts/ns3-clock.dtsi create mode 100644 arch/arm/dts/ns3-pinctrl.dtsi create mode 100644 arch/arm/dts/ns3.dtsi create mode 100644 arch/arm/include/asm/arch-bcmns3/bl33_info.h create mode 100644 board/broadcom/bcmns3/Kconfig create mode 100644 board/broadcom/bcmns3/Makefile create mode 100644 board/broadcom/bcmns3/chimp_optee.c create mode 100644 board/broadcom/bcmns3/fit/keys/dev.crt create mode 100644 board/broadcom/bcmns3/fit/keys/dev.key create mode 100644 board/broadcom/bcmns3/fit/multi.its create mode 100644 board/broadcom/bcmns3/mcu_cmd.c create mode 100644 board/broadcom/bcmns3/mcu_cmd.h create mode 100644 board/broadcom/bcmns3/ns3.c create mode 100644 cmd/bcm/Kconfig create mode 100644 cmd/bcm/Makefile create mode 100644 cmd/bcm/chimp_boot.c create mode 100644 cmd/bcm/chimp_handshake.c create mode 100644 cmd/bcm/elog.h create mode 100644 cmd/bcm/logsetup.c create mode 100644 cmd/bcm/nitro_image_load.c create mode 100644 common/bcm_elog.c create mode 100644 configs/bcm_ns3_defconfig create mode 100644 include/bcm_elog.h create mode 100644 include/brcm/chimp.h create mode 100644 include/configs/bcm_ns3.h create mode 100644 include/dt-bindings/memory/bcm-ns3-mc.h create mode 100644 include/dt-bindings/pinctrl/brcm,pinctrl-ns3.h
[...]
On Mon, Apr 27, 2020 at 2:12 PM Marek Vasut marex@denx.de wrote:
On 4/27/20 12:47 PM, Rayagonda Kokatanur wrote:
This patch series adds support for Broadcom Northstar 3 SoC.
Please, do keep the CC sane, don't CC everyone.
+1!
Please, learn how not to spam people with the crazy patch bomb. Next time I will simple mark this as a spam.
On 4/27/20 3:13 PM, Andy Shevchenko wrote:
On Mon, Apr 27, 2020 at 2:12 PM Marek Vasut marex@denx.de wrote:
On 4/27/20 12:47 PM, Rayagonda Kokatanur wrote:
This patch series adds support for Broadcom Northstar 3 SoC.
Please, do keep the CC sane, don't CC everyone.
+1!
Please, learn how not to spam people with the crazy patch bomb. Next time I will simple mark this as a spam.
I think this is more of a fault of the scripts/get_maintainer or patman, which just blindly added all the addresses. If the series was split in smaller parts, the CC list would probably be smaller too.
On Mon, Apr 27, 2020, 6:55 PM Marek Vasut marex@denx.de wrote:
On 4/27/20 3:13 PM, Andy Shevchenko wrote:
On Mon, Apr 27, 2020 at 2:12 PM Marek Vasut marex@denx.de wrote:
On 4/27/20 12:47 PM, Rayagonda Kokatanur wrote:
This patch series adds support for Broadcom Northstar 3 SoC.
Please, do keep the CC sane, don't CC everyone.
+1!
Please, learn how not to spam people with the crazy patch bomb. Next time I will simple mark this as a spam.
I think this is more of a fault of the scripts/get_maintainer or patman, which just blindly added all the addresses. If the series was split in smaller parts, the CC list would probably be smaller too.
I ran get_maintainer script on my patch set and got all these email id.
Next time I will send only to u-boot@lists.denx.de
Hi Rayagonda,
On Mon, 27 Apr 2020 at 07:29, Rayagonda Kokatanur rayagonda.kokatanur@broadcom.com wrote:
On Mon, Apr 27, 2020, 6:55 PM Marek Vasut marex@denx.de wrote:
On 4/27/20 3:13 PM, Andy Shevchenko wrote:
On Mon, Apr 27, 2020 at 2:12 PM Marek Vasut marex@denx.de wrote:
On 4/27/20 12:47 PM, Rayagonda Kokatanur wrote:
This patch series adds support for Broadcom Northstar 3 SoC.
Please, do keep the CC sane, don't CC everyone.
+1!
Please, learn how not to spam people with the crazy patch bomb. Next time I will simple mark this as a spam.
I think this is more of a fault of the scripts/get_maintainer or patman, which just blindly added all the addresses. If the series was split in smaller parts, the CC list would probably be smaller too.
I ran get_maintainer script on my patch set and got all these email id.
You can use 'patman' which will do this automatically. Also it only does the get_maintainers separately for each patch. Perhaps that is what you are missing here?
Next time I will send only to u-boot@lists.denx.de
As a counterpoint, I don't tend to see patches that just go there, so I like the cc. I have a tag so it doesn't clog up my inbox.
But it is strange that I got every single patch. Perhaps using patman will fix that.
Also two general comments on the series:
- please add a board maintainer - please enable CONFIG_DM_ETH
Regards, Simon
participants (4)
-
Andy Shevchenko -
Marek Vasut -
Rayagonda Kokatanur -
Simon Glass