[U-Boot-Users] [ARM] Add support for AT91CAP9 cpu andAT91CAP9A-DK board
Stelian
Your patch was badly formed and/or mangled by your mail client.
I have reformed it as best I can and it is available from
git://linux-arm.org/u-boot-armdev.git#080116_at91cap9
However you seem to have omitted the file
include/asm-arm/arch-at91cap9/AT91CAP9.h
needed by
./cpu/arm926ejs/at91cap9/ether.c ./include/asm-arm/arch-at91cap9/hardware.h
(or was it to be a link?)
Please supply a patch to the branch so I can examine it further.
Regards
Peter
Le vendredi 25 janvier 2008 à 17:35 +0000, Peter Pearse a écrit :
Stelian
Your patch was badly formed and/or mangled by your mail client.
Hmmm, strange.
I have reformed it as best I can and it is available from
git://linux-arm.org/u-boot-armdev.git#080116_at91cap9
However you seem to have omitted the file
include/asm-arm/arch-at91cap9/AT91CAP9.h
needed by
./cpu/arm926ejs/at91cap9/ether.c ./include/asm-arm/arch-at91cap9/hardware.h
(or was it to be a link?)
As I said in my original posting:
For size reasons, the patch has been hand edited, splitted in several chunks, and the AT91CAP9.h file (440 kB !) is not in the patch at all. Please download the full version from: http://www.popies.net/tmp/uboot-at91cap9-full.patch instead.
Please supply a patch to the branch so I can examine it further.
Can you redo from the patch above ?
If you want I could redo a patch against your branch but I feel it will be easier for you to revert the reconstructed changeset and apply the patch above instead.
Stelian.
In message 1201288627.12296.4.camel@voyager.dsnet you wrote:
As I said in my original posting:
For size reasons, the patch has been hand edited, splitted in several chunks, and the AT91CAP9.h file (440 kB !) is not in the patch at all.
Will you pelase check this file? Only the insane include/asm-arm/mach-types.h has a similar size - al other files are usually much smaller.
Is this stuff really all needed?
Best regards,
Wolfgang Denk
Le samedi 26 janvier 2008 à 01:01 +0100, Wolfgang Denk a écrit :
In message 1201288627.12296.4.camel@voyager.dsnet you wrote:
As I said in my original posting:
For size reasons, the patch has been hand edited, splitted in several chunks, and the AT91CAP9.h file (440 kB !) is not in the patch at all.
Will you pelase check this file? Only the insane include/asm-arm/mach-types.h has a similar size - al other files are usually much smaller.
Is this stuff really all needed?
This header file comes directly from Atmel: it contains the register definitions for _all_ the hardware on the AT91CAP9.
Of course, u-boot does only need a (small) subset of it. If you prefer, I can simplify it.
Thanks,
Stelian.
Hi,
If possible can we keep the all register definition.
Best Regards, J.
Le 26 janv. 08 à 09:24, Stelian Pop stelian@popies.net a écrit :
Le samedi 26 janvier 2008 à 01:01 +0100, Wolfgang Denk a écrit :
In message 1201288627.12296.4.camel@voyager.dsnet you wrote:
As I said in my original posting:
For size reasons, the patch has been hand edited, splitted in several chunks, and the AT91CAP9.h file (440 kB !) is not in the patch at all.
Will you pelase check this file? Only the insane include/asm-arm/mach-types.h has a similar size - al other files are usually much smaller.
Is this stuff really all needed?
This header file comes directly from Atmel: it contains the register definitions for _all_ the hardware on the AT91CAP9.
Of course, u-boot does only need a (small) subset of it. If you prefer, I can simplify it.
Thanks,
Stelian.
Stelian Pop stelian@popies.net
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
On Sat, 26 Jan 2008 09:24:42 +0100 Stelian Pop stelian@popies.net wrote:
This header file comes directly from Atmel: it contains the register definitions for _all_ the hardware on the AT91CAP9.
Most of which are in the tree already. For example, register definitions for the macb ethernet controller is in macb.h, in the same directory as the driver using it.
Of course, u-boot does only need a (small) subset of it. If you prefer, I can simplify it.
IMO, it would be much better if you split it up and put the relevant bits alongside the code that uses them.
Haavard
Le samedi 26 janvier 2008 à 20:28 +0100, Haavard Skinnemoen a écrit :
On Sat, 26 Jan 2008 09:24:42 +0100 Stelian Pop stelian@popies.net wrote:
This header file comes directly from Atmel: it contains the register definitions for _all_ the hardware on the AT91CAP9.
Most of which are in the tree already. For example, register definitions for the macb ethernet controller is in macb.h, in the same directory as the driver using it.
Same for UART registers.
Of course, u-boot does only need a (small) subset of it. If you prefer, I can simplify it.
IMO, it would be much better if you split it up and put the relevant bits alongside the code that uses them.
Yes, it does indeed make sense, at least for cross-platform drivers which live in drivers/.
I removed all the unused parts of AT91CAP9.h, this downs the size up 37 KB (more than 10 times smaller than before).
I'll be submitting a new series of patches shortly.
Thanks,
Stelian.
Le samedi 26 janvier 2008 à 01:01 +0100, Wolfgang Denk a écrit :
In message 1201288627.12296.4.camel@voyager.dsnet you wrote:
As I said in my original posting:
For size reasons, the patch has been hand edited, splitted in several chunks, and the AT91CAP9.h file (440 kB !) is not in the patch at all.
Will you pelase check this file? Only the insane include/asm-arm/mach-types.h has a similar size - al other files are usually much smaller.
Is this stuff really all needed?
This header file comes directly from Atmel: it contains the register definitions for _all_ the hardware on the AT91CAP9.
Of course, u-boot does only need a (small) subset of it. If you prefer, I can simplify it.
==> Which will make it harder to maintain. These files are automatically generated from the chip database, and most of the stuff can conceivably be used by U-Boot. -- Even if they are not used today.
If a bug is detected in the file, then the place to update is inside the database. Obviously ansy script generating the data, should be modified to generate something which can be directly used by U-Boot without any further modification.
It may make sense to split up the file as well, as Haavard proposes, but preferably, the split should be done at the source. I will forward this request to the AT91 & CAP teams
Thanks,
Stelian.
Le lundi 28 janvier 2008 à 18:22 +0100, Ulf Samuelsson a écrit :
Of course, u-boot does only need a (small) subset of it. If you prefer, I can simplify it.
==> Which will make it harder to maintain.
Note however this is the path the Linux kernel developers chose too.
These files are automatically generated from the chip database, and most of the stuff can conceivably be used by U-Boot. -- Even if they are not used today.
Smells like over-engineering at this point.
If a bug is detected in the file, then the place to update is inside the database. Obviously ansy script generating the data, should be modified to generate something which can be directly used by U-Boot without any further modification.
The question is whether it can be possible to make such a script to generate header files in accordance with the coding styles :)
It may make sense to split up the file as well, as Haavard proposes, but preferably, the split should be done at the source. I will forward this request to the AT91 & CAP teams
Sure, if they do this it would be perfect. Meanwhile, let's start with the one I've submitted (30 kb is better than 400 kb anyway). If/when Atmel cooks up clean and splitted header files then we will import those ones.
participants (6)
-
Haavard Skinnemoen -
Jean-Christophe PLAGNIOL-VILLARD -
Peter Pearse -
Stelian Pop -
Ulf Samuelsson -
Wolfgang Denk