[U-Boot] [PATCH] km/common: add toolchain variable
Add a variable "toolchain" and configure the rootpath for the nfsargs with this variable.
Signed-off-by: Holger Brunck holger.brunck@keymile.com cc: Wolfgang Denk wd@denx.de --- board/keymile/scripts/README | 2 +- board/keymile/scripts/develop-common.txt | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/board/keymile/scripts/README b/board/keymile/scripts/README index 7fbcf74..dd935b2 100644 --- a/board/keymile/scripts/README +++ b/board/keymile/scripts/README @@ -7,7 +7,7 @@ default environment must be parsed: run develop : setup environment to configure for rootfs via nfs run ramfs : setup environment to configure for rootfs in ram
-Last change: 20.05.2011 +Last change: 24.11.2011
develop-common.txt ============================ diff --git a/board/keymile/scripts/develop-common.txt b/board/keymile/scripts/develop-common.txt index 93e2967..aa3d659 100644 --- a/board/keymile/scripts/develop-common.txt +++ b/board/keymile/scripts/develop-common.txt @@ -2,6 +2,7 @@ altbootcmd=run ${subbootcmds} bootcmd=run ${subbootcmds} configure=km_setboardid && saveenv && reset subbootcmds=tftpfdt tftpkernel nfsargs add_default boot -nfsargs=setenv bootargs root=/dev/nfs rw nfsroot=${serverip}:/opt/eldk/${arch} +nfsargs=setenv bootargs root=/dev/nfs rw nfsroot=${serverip}:${toolchain}/${arch} tftpkernel=tftpboot ${load_addr_r} ${hostname}/uImage +toolchain=/opt/eldk rootfssize=0
Dear Holger Brunck,
In message 1323879110-8404-1-git-send-email-holger.brunck@keymile.com you wrote:
Add a variable "toolchain" and configure the rootpath for the nfsargs with this variable.
Signed-off-by: Holger Brunck holger.brunck@keymile.com cc: Wolfgang Denk wd@denx.de
board/keymile/scripts/README | 2 +- board/keymile/scripts/develop-common.txt | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/board/keymile/scripts/README b/board/keymile/scripts/README index 7fbcf74..dd935b2 100644 --- a/board/keymile/scripts/README +++ b/board/keymile/scripts/README @@ -7,7 +7,7 @@ default environment must be parsed: run develop : setup environment to configure for rootfs via nfs run ramfs : setup environment to configure for rootfs in ram
-Last change: 20.05.2011 +Last change: 24.11.2011
Does this really make any sense? Which date are you recording here/ When you (think) you last edited the file? When you applied the patch to your local tree? When you submitted it for mainline? When it actually got applied?
I recommend to get rid of this, and rather use git revision information instead.
Best regards,
Wolfgang Denk
Hi Wolfgang,
On 12/17/2011 09:49 PM, Wolfgang Denk wrote:
In message 1323879110-8404-1-git-send-email-holger.brunck@keymile.com you wrote:
Add a variable "toolchain" and configure the rootpath for the nfsargs with this variable.
Signed-off-by: Holger Brunck holger.brunck@keymile.com cc: Wolfgang Denk wd@denx.de
board/keymile/scripts/README | 2 +- board/keymile/scripts/develop-common.txt | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/board/keymile/scripts/README b/board/keymile/scripts/README index 7fbcf74..dd935b2 100644 --- a/board/keymile/scripts/README +++ b/board/keymile/scripts/README @@ -7,7 +7,7 @@ default environment must be parsed: run develop : setup environment to configure for rootfs via nfs run ramfs : setup environment to configure for rootfs in ram
-Last change: 20.05.2011 +Last change: 24.11.2011
Does this really make any sense? Which date are you recording here/ When you (think) you last edited the file? When you applied the patch to your local tree? When you submitted it for mainline? When it actually got applied?
What I want to record is to track the version of the scripts and this makes sense for me. In the end the scripts are copied into /tftpboot on each developers machine and is therefore not under git control. It is an easy indication wether the scripts are uptodate or not, without starting a diff tool and compare them with the latest git tree. Inside the git tree the information is useless, I agree.
I recommend to get rid of this, and rather use git revision information instead.
I would like to keep this, because git does not easily help here.
Best regards Holger
Dear Holger Brunck,
In message 4EEEF0D3.5040302@keymile.com you wrote:
+Last change: 24.11.2011
Does this really make any sense? Which date are you recording here/ When you (think) you last edited the file? When you applied the patch to your local tree? When you submitted it for mainline? When it actually got applied?
What I want to record is to track the version of the scripts and this makes sense for me. In the end the scripts are copied into /tftpboot on each developers machine and is therefore not under git control. It is an easy indication wether the scripts are uptodate or not, without starting a diff tool and compare them with the latest git tree. Inside the git tree the information is useless, I agree.
You can insert such information when you export the files from git, say by adding a line like:
Last commit date: $Format:%H %cD$
That would IMO make much more sense.
See what we do with "snapshot.commit" in U-Boot [see also the entry in .git/info/attributes].
I recommend to get rid of this, and rather use git revision information instead.
I would like to keep this, because git does not easily help here.
Maybe it does - see above.
Best regards,
Wolfgang Denk
Hi Wolfgang,
On 12/19/2011 09:57 AM, Wolfgang Denk wrote:
In message 4EEEF0D3.5040302@keymile.com you wrote:
+Last change: 24.11.2011
Does this really make any sense? Which date are you recording here/ When you (think) you last edited the file? When you applied the patch to your local tree? When you submitted it for mainline? When it actually got applied?
What I want to record is to track the version of the scripts and this makes sense for me. In the end the scripts are copied into /tftpboot on each developers machine and is therefore not under git control. It is an easy indication wether the scripts are uptodate or not, without starting a diff tool and compare them with the latest git tree. Inside the git tree the information is useless, I agree.
You can insert such information when you export the files from git, say by adding a line like:
Last commit date: $Format:%H %cD$
That would IMO make much more sense.
See what we do with "snapshot.commit" in U-Boot [see also the entry in .git/info/attributes].
After reading the doc I don't know how it could be used in my usecase. Please correct me if I am wrong, but this does only work in combination with the "git archive" command. And I don't want to do an archive, I want to export/copy some files out of the git tree into /tftpboot.
Best regards Holger
Dear Holger Brunck,
In message 4EEF13D4.5020304@keymile.com you wrote:
You can insert such information when you export the files from git, say by adding a line like:
Last commit date: $Format:%H %cD$
...
After reading the doc I don't know how it could be used in my usecase. Please correct me if I am wrong, but this does only work in combination with the "git archive" command. And I don't want to do an archive, I want to export/copy some files out of the git tree into /tftpboot.
You could for example use the following command to copy this file into /tftpboot:
$ cd board/keymile/scripts $ git archive --format=tar HEAD README | \ ( cd /tftpboot ; tar -xpvf - )
Best regards,
Wolfgang Denk
Hi Wolfgang,
On 12/19/2011 12:33 PM, Wolfgang Denk wrote:
In message 4EEF13D4.5020304@keymile.com you wrote:
You can insert such information when you export the files from git, say by adding a line like:
Last commit date: $Format:%H %cD$
...
After reading the doc I don't know how it could be used in my usecase. Please correct me if I am wrong, but this does only work in combination with the "git archive" command. And I don't want to do an archive, I want to export/copy some files out of the git tree into /tftpboot.
You could for example use the following command to copy this file into /tftpboot:
$ cd board/keymile/scripts $ git archive --format=tar HEAD README | \ ( cd /tftpboot ; tar -xpvf - )
hm together with the needed git configuration IMO a bit to complicated for my needs. To be honest I would like to keep this date information as it is.
If this is not acceptable then I will remove this string completely from the u-boot tree and force the users to add a VERSION file to /tftpboot/scripts with:
$ git describe > /tftpboot/scripts/VERSION
or I keep it as a OOT patch. Just let me know.
Best regards Holger
Dear Holger Brunck,
In message 4EEF350C.4040501@keymile.com you wrote:
hm together with the needed git configuration IMO a bit to complicated for my needs. To be honest I would like to keep this date information as it is.
OK, as you like it.
If this is not acceptable then I will remove this string completely from the u-boot tree and force the users to add a VERSION file to /tftpboot/scripts with:
I don't like it, that's all. But then I don't have to.
Best regards,
Wolfgang Denk
Dear Holger Brunck,
In message 1323879110-8404-1-git-send-email-holger.brunck@keymile.com you wrote:
Add a variable "toolchain" and configure the rootpath for the nfsargs with this variable.
Signed-off-by: Holger Brunck holger.brunck@keymile.com cc: Wolfgang Denk wd@denx.de
board/keymile/scripts/README | 2 +- board/keymile/scripts/develop-common.txt | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
participants (2)
-
Holger Brunck -
Wolfgang Denk