[U-Boot-Users] [PATCH] Fix bug: `env_get_char' dose not work well on u-boot-1.3.4-rc1

Hi folks, I use Atmel AT91SAM9260-EK boards, arm-linux-gcc (GCC) 4.2.4. After I pulled the latest code from git://git.denx.de/u-boot-at91.git, I found that the env_get_char@common/env_common.c can not work well. The root cause is in u-boot-1.3.4-rc1, `env_get_char' was rewritten. Below is a quick patch to kick the ball rolling.
Thanks!
From 2a1462f7df8aee397fcd1d891c71ea212e1a9f5a Mon Sep 17 00:00:00 2001
From: gnusercn gnusercn@gmail.com Date: Tue, 22 Jul 2008 10:35:58 +0800 Subject: [PATCH] Fix bug: in arch-arm, env_get_char dose not work fine in u-boot 1.3.4-rc1
Signed-off-by: gnusercn gnusercn@gmail.com --- lib_arm/board.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/lib_arm/board.c b/lib_arm/board.c index 80b149b..cd8c9f3 100644 --- a/lib_arm/board.c +++ b/lib_arm/board.c @@ -303,6 +303,8 @@ void start_armboot (void) gd->bd = (bd_t*)((char*)gd - sizeof(bd_t)); memset (gd->bd, 0, sizeof (bd_t));
+ gd->flags |= GD_FLG_RELOC; + monitor_flash_len = _bss_start - _armboot_start;
for (init_fnc_ptr = init_sequence; *init_fnc_ptr; ++init_fnc_ptr) { -- 1.5.0.6

Hello All,
2008/7/22 os user gnusercn@gmail.com:
Hi folks, I use Atmel AT91SAM9260-EK boards, arm-linux-gcc (GCC) 4.2.4. After I pulled the latest code from git://git.denx.de/u-boot-at91.git, I found that the env_get_char@common/env_common.c can not work well. The root cause is in u-boot-1.3.4-rc1, `env_get_char' was rewritten. Below is a quick patch to kick the ball rolling.
Thanks!
This problem was already known, and this patch works only for that board, all AT91 boards are broken. In a few minutes I will post a patch fixing it for all boards.
Kind Regards,
Remy
participants (2)
-
os user
-
Remy Bohmer