I notice that in several places the spartan2/3 and virtex2 download code tests the fn->pre and fn->post pointers for a null and skips calling them if they are null.

The relocation code that moves the pointers never checks them for null and happily adds reloc_offset to the null pointers making non-null ones and leading to a crash when the code tries to call them.

Does it make more sense to remove the checks and always call the functions (assuming everybody using these bits has defined at least a stub for these), or does it make more sense to test the pointers at reloc time and fix all the reloc functions?