[PATCH] pico-imx7d: increase ODT resistor value from 60 to 120 ohm to improve DRAM stability
From: Ray Chang ray.chang@technexion.com
Signed-off-by: Ray Chang ray.chang@technexion.com --- board/technexion/pico-imx7d/spl.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/board/technexion/pico-imx7d/spl.c b/board/technexion/pico-imx7d/spl.c index cb60d3be42..fc97c58ae1 100644 --- a/board/technexion/pico-imx7d/spl.c +++ b/board/technexion/pico-imx7d/spl.c @@ -89,11 +89,11 @@ static struct ddr_phy ddr_phy_regs_val = { static struct mx7_calibration calib_param = { .num_val = 5, .values = { - 0x0E407304, - 0x0E447304, - 0x0E447306, - 0x0E447304, - 0x0E447304, + 0x0E207304, + 0x0E247304, + 0x0E247306, + 0x0E247304, + 0x0E207304, }, };
The subject is too long. Make it succinct:
pico-imx7d: Increase ODT resistor value
On Mon, Oct 14, 2024 at 9:26 PM egyszeregy@freemail.hu wrote:
From: Ray Chang ray.chang@technexion.com
Place here the explanation for this change:
Increase ODT resistor value from 60 to 120 ohm to improve DRAM stability.
Signed-off-by: Ray Chang ray.chang@technexion.com
You missed your Signed-off-by tag.
2024. 10. 16. 20:32 keltezéssel, Fabio Estevam írta:
The subject is too long. Make it succinct:
pico-imx7d: Increase ODT resistor value
On Mon, Oct 14, 2024 at 9:26 PM egyszeregy@freemail.hu wrote:
From: Ray Chang ray.chang@technexion.com
Place here the explanation for this change:
Increase ODT resistor value from 60 to 120 ohm to improve DRAM stability.
Signed-off-by: Ray Chang ray.chang@technexion.com
You missed your Signed-off-by tag.
I am not the author of this patch why i need to Signed-off it? It is a DDR calib optimisation from u-boot-tn-imx repo for pico-imx7d by Technexion maintainers. I can not share any more info why it is needed.
https://github.com/TechNexion/u-boot-tn-imx/commit/8a00e57b697c6f7d3d3abcfc5...
On Wed, Oct 16, 2024 at 4:35 PM Szőke Benjamin egyszeregy@freemail.hu wrote:
I am not the author of this patch why i need to Signed-off it? It is a DDR calib
Because you are in the delivery path of someone else patch. This is explained at:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Docu...
"The Signed-off-by: tag indicates that the signer was involved in the development of the patch, or that he/she was in the patch's delivery path."
optimisation from u-boot-tn-imx repo for pico-imx7d by Technexion maintainers. I can not share any more info why it is needed.
https://github.com/TechNexion/u-boot-tn-imx/commit/8a00e57b697c6f7d3d3abcfc5...
Like I said earlier, write a short explanation as the commit log like the text below:
"Increase ODT resistor value from 60 to 120 ohm to improve DRAM stability.
Based on the following commit from TechNexion U-Boot: https://github.com/TechNexion/u-boot-tn-imx/commit/8a00e57b697c6f7d3d3abcfc5... "
participants (3)
-
egyszeregy＠freemail.hu -
Fabio Estevam -
Szőke Benjamin