[PATCH v1 9/9] rockchip: RK3588: Enable display cpuinfo support on all boards
Imply DISPLAY_CPUINFO Kconfig options to support on all RK3588s and RK3588 boards, Its used to determine the reset cause of the board.
Cc: Jagan Teki jagan@edgeble.ai Signed-off-by: Anand Moon anand@edgeble.ai --- arch/arm/mach-rockchip/Kconfig | 1 + configs/coolpi-4b-rk3588s_defconfig | 1 - configs/coolpi-cm5-evb-rk3588_defconfig | 1 - configs/evb-rk3588_defconfig | 1 - configs/generic-rk3588_defconfig | 1 - configs/jaguar-rk3588_defconfig | 1 - configs/nanopc-t6-rk3588_defconfig | 1 - configs/neu6a-io-rk3588_defconfig | 1 - configs/neu6b-io-rk3588_defconfig | 1 - configs/orangepi-5-plus-rk3588_defconfig | 1 - configs/orangepi-5-rk3588s_defconfig | 1 - configs/quartzpro64-rk3588_defconfig | 1 - configs/rock5a-rk3588s_defconfig | 1 - configs/rock5b-rk3588_defconfig | 1 - configs/toybrick-rk3588_defconfig | 1 - configs/turing-rk1-rk3588_defconfig | 1 - 16 files changed, 1 insertion(+), 15 deletions(-)
diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig index 2e9c71138e..1b5cc34f99 100644 --- a/arch/arm/mach-rockchip/Kconfig +++ b/arch/arm/mach-rockchip/Kconfig @@ -366,6 +366,7 @@ config ROCKCHIP_RK3588 imply SCMI_FIRMWARE imply SPL_ATF_NO_PLATFORM_PARAM if SPL_ATF imply SPL_MMC_HS200_SUPPORT if SPL_MMC && MMC_HS200_SUPPORT + imply DISPLAY_CPUINFO help The Rockchip RK3588 is a ARM-based SoC with quad-core Cortex-A76 and quad-core Cortex-A55 including NEON and GPU, 6TOPS NPU, Mali-G610 MP4, diff --git a/configs/coolpi-4b-rk3588s_defconfig b/configs/coolpi-4b-rk3588s_defconfig index 3d45d939ab..b094224f6e 100644 --- a/configs/coolpi-4b-rk3588s_defconfig +++ b/configs/coolpi-4b-rk3588s_defconfig @@ -23,7 +23,6 @@ CONFIG_SPL_FIT_SIGNATURE=y CONFIG_SPL_LOAD_FIT=y CONFIG_LEGACY_IMAGE_FORMAT=y CONFIG_DEFAULT_FDT_FILE="rockchip/rk3588s-coolpi-4b.dtb" -# CONFIG_DISPLAY_CPUINFO is not set CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_SPL_MAX_SIZE=0x40000 CONFIG_SPL_PAD_TO=0x7f8000 diff --git a/configs/coolpi-cm5-evb-rk3588_defconfig b/configs/coolpi-cm5-evb-rk3588_defconfig index 5190d69c1c..382ee97fc9 100644 --- a/configs/coolpi-cm5-evb-rk3588_defconfig +++ b/configs/coolpi-cm5-evb-rk3588_defconfig @@ -23,7 +23,6 @@ CONFIG_SPL_FIT_SIGNATURE=y CONFIG_SPL_LOAD_FIT=y CONFIG_LEGACY_IMAGE_FORMAT=y CONFIG_DEFAULT_FDT_FILE="rockchip/rk3588-coolpi-cm5-evb.dtb" -# CONFIG_DISPLAY_CPUINFO is not set CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_SPL_MAX_SIZE=0x40000 CONFIG_SPL_PAD_TO=0x7f8000 diff --git a/configs/evb-rk3588_defconfig b/configs/evb-rk3588_defconfig index 1d5585677a..bfc505a4b7 100644 --- a/configs/evb-rk3588_defconfig +++ b/configs/evb-rk3588_defconfig @@ -16,7 +16,6 @@ CONFIG_SPL_FIT_SIGNATURE=y CONFIG_SPL_LOAD_FIT=y CONFIG_LEGACY_IMAGE_FORMAT=y CONFIG_DEFAULT_FDT_FILE="rockchip/rk3588-evb1-v10.dtb" -# CONFIG_DISPLAY_CPUINFO is not set CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_SPL_MAX_SIZE=0x40000 CONFIG_SPL_PAD_TO=0x7f8000 diff --git a/configs/generic-rk3588_defconfig b/configs/generic-rk3588_defconfig index 42bc2c9a76..ddb23b035b 100644 --- a/configs/generic-rk3588_defconfig +++ b/configs/generic-rk3588_defconfig @@ -17,7 +17,6 @@ CONFIG_SPL_LOAD_FIT=y # CONFIG_BOOTMETH_VBE is not set CONFIG_LEGACY_IMAGE_FORMAT=y CONFIG_DEFAULT_FDT_FILE="rockchip/rk3588-generic.dtb" -# CONFIG_DISPLAY_CPUINFO is not set CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_SPL_MAX_SIZE=0x40000 CONFIG_SPL_PAD_TO=0x7f8000 diff --git a/configs/jaguar-rk3588_defconfig b/configs/jaguar-rk3588_defconfig index b69cf4cd05..712a936539 100644 --- a/configs/jaguar-rk3588_defconfig +++ b/configs/jaguar-rk3588_defconfig @@ -22,7 +22,6 @@ CONFIG_SPL_LOAD_FIT=y # CONFIG_BOOTMETH_VBE is not set CONFIG_LEGACY_IMAGE_FORMAT=y CONFIG_DEFAULT_FDT_FILE="rockchip/rk3588-jaguar.dtb" -# CONFIG_DISPLAY_CPUINFO is not set CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_CYCLIC=y CONFIG_SPL_MAX_SIZE=0x40000 diff --git a/configs/nanopc-t6-rk3588_defconfig b/configs/nanopc-t6-rk3588_defconfig index 926267f93a..978c62aee6 100644 --- a/configs/nanopc-t6-rk3588_defconfig +++ b/configs/nanopc-t6-rk3588_defconfig @@ -23,7 +23,6 @@ CONFIG_SPL_FIT_SIGNATURE=y CONFIG_SPL_LOAD_FIT=y CONFIG_LEGACY_IMAGE_FORMAT=y CONFIG_DEFAULT_FDT_FILE="rockchip/rk3588-nanopc-t6.dtb" -# CONFIG_DISPLAY_CPUINFO is not set CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_SPL_MAX_SIZE=0x40000 CONFIG_SPL_PAD_TO=0x7f8000 diff --git a/configs/neu6a-io-rk3588_defconfig b/configs/neu6a-io-rk3588_defconfig index ac281e6539..6f2765c640 100644 --- a/configs/neu6a-io-rk3588_defconfig +++ b/configs/neu6a-io-rk3588_defconfig @@ -16,7 +16,6 @@ CONFIG_SPL_FIT_SIGNATURE=y CONFIG_SPL_LOAD_FIT=y CONFIG_LEGACY_IMAGE_FORMAT=y CONFIG_DEFAULT_FDT_FILE="rockchip/rk3588-edgeble-neu6a-io.dtb" -# CONFIG_DISPLAY_CPUINFO is not set CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_SPL_MAX_SIZE=0x40000 CONFIG_SPL_PAD_TO=0x7f8000 diff --git a/configs/neu6b-io-rk3588_defconfig b/configs/neu6b-io-rk3588_defconfig index c01e5fb0d0..13b542a752 100644 --- a/configs/neu6b-io-rk3588_defconfig +++ b/configs/neu6b-io-rk3588_defconfig @@ -16,7 +16,6 @@ CONFIG_SPL_FIT_SIGNATURE=y CONFIG_SPL_LOAD_FIT=y CONFIG_LEGACY_IMAGE_FORMAT=y CONFIG_DEFAULT_FDT_FILE="rockchip/rk3588-edgeble-neu6b-io.dtb" -# CONFIG_DISPLAY_CPUINFO is not set CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_SPL_MAX_SIZE=0x40000 CONFIG_SPL_PAD_TO=0x7f8000 diff --git a/configs/orangepi-5-plus-rk3588_defconfig b/configs/orangepi-5-plus-rk3588_defconfig index 138a633f32..c8c64bdeaf 100644 --- a/configs/orangepi-5-plus-rk3588_defconfig +++ b/configs/orangepi-5-plus-rk3588_defconfig @@ -24,7 +24,6 @@ CONFIG_SPL_FIT_SIGNATURE=y CONFIG_SPL_LOAD_FIT=y CONFIG_LEGACY_IMAGE_FORMAT=y CONFIG_DEFAULT_FDT_FILE="rockchip/rk3588-orangepi-5-plus.dtb" -# CONFIG_DISPLAY_CPUINFO is not set CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_SPL_MAX_SIZE=0x40000 CONFIG_SPL_PAD_TO=0x7f8000 diff --git a/configs/orangepi-5-rk3588s_defconfig b/configs/orangepi-5-rk3588s_defconfig index 33529d4cac..d71eb7c3f9 100644 --- a/configs/orangepi-5-rk3588s_defconfig +++ b/configs/orangepi-5-rk3588s_defconfig @@ -23,7 +23,6 @@ CONFIG_SPL_FIT_SIGNATURE=y CONFIG_SPL_LOAD_FIT=y CONFIG_LEGACY_IMAGE_FORMAT=y CONFIG_DEFAULT_FDT_FILE="rockchip/rk3588s-orangepi-5.dtb" -# CONFIG_DISPLAY_CPUINFO is not set CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_SPL_MAX_SIZE=0x40000 CONFIG_SPL_PAD_TO=0x7f8000 diff --git a/configs/quartzpro64-rk3588_defconfig b/configs/quartzpro64-rk3588_defconfig index 06c5cff3ca..99422282bc 100644 --- a/configs/quartzpro64-rk3588_defconfig +++ b/configs/quartzpro64-rk3588_defconfig @@ -19,7 +19,6 @@ CONFIG_SPL_FIT_SIGNATURE=y CONFIG_SPL_LOAD_FIT=y CONFIG_LEGACY_IMAGE_FORMAT=y CONFIG_DEFAULT_FDT_FILE="rockchip/rk3588-quartzpro64.dtb" -# CONFIG_DISPLAY_CPUINFO is not set CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_SPL_MAX_SIZE=0x40000 CONFIG_SPL_PAD_TO=0x7f8000 diff --git a/configs/rock5a-rk3588s_defconfig b/configs/rock5a-rk3588s_defconfig index c09e6655f0..a64d8a071d 100644 --- a/configs/rock5a-rk3588s_defconfig +++ b/configs/rock5a-rk3588s_defconfig @@ -16,7 +16,6 @@ CONFIG_SPL_FIT_SIGNATURE=y CONFIG_SPL_LOAD_FIT=y CONFIG_LEGACY_IMAGE_FORMAT=y CONFIG_DEFAULT_FDT_FILE="rockchip/rk3588s-rock-5a.dtb" -# CONFIG_DISPLAY_CPUINFO is not set CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_SPL_MAX_SIZE=0x40000 CONFIG_SPL_PAD_TO=0x7f8000 diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b-rk3588_defconfig index fc118cea7b..234bc76bf2 100644 --- a/configs/rock5b-rk3588_defconfig +++ b/configs/rock5b-rk3588_defconfig @@ -24,7 +24,6 @@ CONFIG_SPL_FIT_SIGNATURE=y CONFIG_SPL_LOAD_FIT=y CONFIG_LEGACY_IMAGE_FORMAT=y CONFIG_DEFAULT_FDT_FILE="rockchip/rk3588-rock-5b.dtb" -# CONFIG_DISPLAY_CPUINFO is not set CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_SPL_MAX_SIZE=0x40000 CONFIG_SPL_PAD_TO=0x7f8000 diff --git a/configs/toybrick-rk3588_defconfig b/configs/toybrick-rk3588_defconfig index 5a190357e4..bd33c648ed 100644 --- a/configs/toybrick-rk3588_defconfig +++ b/configs/toybrick-rk3588_defconfig @@ -16,7 +16,6 @@ CONFIG_SPL_FIT_SIGNATURE=y CONFIG_SPL_LOAD_FIT=y CONFIG_LEGACY_IMAGE_FORMAT=y CONFIG_DEFAULT_FDT_FILE="rockchip/rk3588-toybrick-x0.dtb" -# CONFIG_DISPLAY_CPUINFO is not set CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_SPL_MAX_SIZE=0x40000 CONFIG_SPL_PAD_TO=0x7f8000 diff --git a/configs/turing-rk1-rk3588_defconfig b/configs/turing-rk1-rk3588_defconfig index e6e1bda7ec..0ca33e95d7 100644 --- a/configs/turing-rk1-rk3588_defconfig +++ b/configs/turing-rk1-rk3588_defconfig @@ -19,7 +19,6 @@ CONFIG_SPL_FIT_SIGNATURE=y CONFIG_SPL_LOAD_FIT=y CONFIG_LEGACY_IMAGE_FORMAT=y CONFIG_DEFAULT_FDT_FILE="rockchip/rk3588-turing-rk1.dtb" -# CONFIG_DISPLAY_CPUINFO is not set CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_SPL_MAX_SIZE=0x40000 CONFIG_SPL_PAD_TO=0x7f8000
Hi Anand,
This is patch 9/9 but somehow I didn't receive any other patch, nor did the mailing list? c.f. https://lists.denx.de/pipermail/u-boot/2024-May/thread.html and https://lore.kernel.org/u-boot/. Are you registered on the ML?
On 5/16/24 10:59 AM, Anand Moon wrote:
Imply DISPLAY_CPUINFO Kconfig options to support on all RK3588s and RK3588 boards, Its used to determine the reset cause of the board.
Cc: Jagan Teki jagan@edgeble.ai Signed-off-by: Anand Moon anand@edgeble.ai
arch/arm/mach-rockchip/Kconfig | 1 + configs/coolpi-4b-rk3588s_defconfig | 1 - configs/coolpi-cm5-evb-rk3588_defconfig | 1 - configs/evb-rk3588_defconfig | 1 - configs/generic-rk3588_defconfig | 1 - configs/jaguar-rk3588_defconfig | 1 - configs/nanopc-t6-rk3588_defconfig | 1 - configs/neu6a-io-rk3588_defconfig | 1 - configs/neu6b-io-rk3588_defconfig | 1 - configs/orangepi-5-plus-rk3588_defconfig | 1 - configs/orangepi-5-rk3588s_defconfig | 1 - configs/quartzpro64-rk3588_defconfig | 1 - configs/rock5a-rk3588s_defconfig | 1 - configs/rock5b-rk3588_defconfig | 1 - configs/toybrick-rk3588_defconfig | 1 - configs/turing-rk1-rk3588_defconfig | 1 - 16 files changed, 1 insertion(+), 15 deletions(-)
diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig index 2e9c71138e..1b5cc34f99 100644 --- a/arch/arm/mach-rockchip/Kconfig +++ b/arch/arm/mach-rockchip/Kconfig @@ -366,6 +366,7 @@ config ROCKCHIP_RK3588 imply SCMI_FIRMWARE imply SPL_ATF_NO_PLATFORM_PARAM if SPL_ATF imply SPL_MMC_HS200_SUPPORT if SPL_MMC && MMC_HS200_SUPPORT
- imply DISPLAY_CPUINFO
This is unnecessary, it's already defaulting to y if building for ARM boards: https://elixir.bootlin.com/u-boot/latest/source/common/Kconfig#L596
I also don't think this is SO useful that we need to enable it on all rk3588 boards? But also, doesn't hurt, so... whatever I guess :) ?
While looking at the code, I think we can remove the ifdef in https://elixir.bootlin.com/u-boot/latest/source/arch/arm/mach-rockchip/cpu-i... because this file is anyway only compiled when CONFIG_DISPLAY_CPUINFO is set, c.f. https://elixir.bootlin.com/u-boot/latest/source/arch/arm/mach-rockchip/Makef...
which also means...
https://elixir.bootlin.com/u-boot/latest/source/arch/arm/include/asm/arch-ro... should probably be ifdef'ed
which means...
https://elixir.bootlin.com/u-boot/latest/source/board/firefly/roc-pc-rk3399/... should probably also be ifdef'ed (but the config is enabled already (well... it wouldn't compile otherwsie), so I guess this is fine?).
Cheers, Quentin
Hi Quentin
On Thu, 16 May 2024 at 14:52, Quentin Schulz quentin.schulz@cherry.de wrote:
Hi Anand,
This is patch 9/9 but somehow I didn't receive any other patch, nor did the mailing list? c.f. https://lists.denx.de/pipermail/u-boot/2024-May/thread.html and https://lore.kernel.org/u-boot/. Are you registered on the ML?
Thanks for your review comments.
Something went wrong with git sendmail, Your message have not reached my email client (gmail)
On 5/16/24 10:59 AM, Anand Moon wrote:
Imply DISPLAY_CPUINFO Kconfig options to support on all RK3588s and RK3588 boards, Its used to determine the reset cause of the board.
Cc: Jagan Teki jagan@edgeble.ai Signed-off-by: Anand Moon anand@edgeble.ai
arch/arm/mach-rockchip/Kconfig | 1 + configs/coolpi-4b-rk3588s_defconfig | 1 - configs/coolpi-cm5-evb-rk3588_defconfig | 1 - configs/evb-rk3588_defconfig | 1 - configs/generic-rk3588_defconfig | 1 - configs/jaguar-rk3588_defconfig | 1 - configs/nanopc-t6-rk3588_defconfig | 1 - configs/neu6a-io-rk3588_defconfig | 1 - configs/neu6b-io-rk3588_defconfig | 1 - configs/orangepi-5-plus-rk3588_defconfig | 1 - configs/orangepi-5-rk3588s_defconfig | 1 - configs/quartzpro64-rk3588_defconfig | 1 - configs/rock5a-rk3588s_defconfig | 1 - configs/rock5b-rk3588_defconfig | 1 - configs/toybrick-rk3588_defconfig | 1 - configs/turing-rk1-rk3588_defconfig | 1 - 16 files changed, 1 insertion(+), 15 deletions(-)
diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig index 2e9c71138e..1b5cc34f99 100644 --- a/arch/arm/mach-rockchip/Kconfig +++ b/arch/arm/mach-rockchip/Kconfig @@ -366,6 +366,7 @@ config ROCKCHIP_RK3588 imply SCMI_FIRMWARE imply SPL_ATF_NO_PLATFORM_PARAM if SPL_ATF imply SPL_MMC_HS200_SUPPORT if SPL_MMC && MMC_HS200_SUPPORT
imply DISPLAY_CPUINFOThis is unnecessary, it's already defaulting to y if building for ARM boards: https://elixir.bootlin.com/u-boot/latest/source/common/Kconfig#L596
See below...
I also don't think this is SO useful that we need to enable it on all rk3588 boards? But also, doesn't hurt, so... whatever I guess :) ?
While looking at the code, I think we can remove the ifdef in https://elixir.bootlin.com/u-boot/latest/source/arch/arm/mach-rockchip/cpu-i... because this file is anyway only compiled when CONFIG_DISPLAY_CPUINFO is set, c.f.
Oops I missed this changes, my bad I will dop my changes over here.
https://elixir.bootlin.com/u-boot/latest/source/arch/arm/mach-rockchip/Makef...
On Rockchip SoC CONFIG_DISPLAY_CPUINFO is been disable on most of the configs files.
-# CONFIG_DISPLAY_CPUINFO is not set
My changes are related to determine the reset cause of the board and display the results. its only enable on selected SoC hence I have to used this logic.
U-Boot 2024.07-rc2-00397-g0370324feb-dirty (May 16 2024 - 13:11:14 +0530)
SoC: Rockchip rk3568 Reset cause: POR <----------- Model: Radxa ROCK3 Model A DRAM: 8 GiB (effective 7.7 GiB) PMIC: RK8090 (on=0x40, off=0x00) Core: 344 devices, 31 uclasses,
which also means...
https://elixir.bootlin.com/u-boot/latest/source/arch/arm/include/asm/arch-ro... should probably be ifdef'ed
which means...
https://elixir.bootlin.com/u-boot/latest/source/board/firefly/roc-pc-rk3399/... should probably also be ifdef'ed (but the config is enabled already (well... it wouldn't compile otherwsie), so I guess this is fine?).
This code changes will not affect this feature by default its enable on RK3399 boards.
Cheers, Quentin
Thanks
-Anand
Hi Anand,
On 5/16/24 12:12 PM, Anand Moon wrote:
Hi Quentin
On Thu, 16 May 2024 at 14:52, Quentin Schulz quentin.schulz@cherry.de wrote:
Hi Anand,
This is patch 9/9 but somehow I didn't receive any other patch, nor did the mailing list? c.f. https://lists.denx.de/pipermail/u-boot/2024-May/thread.html and https://lore.kernel.org/u-boot/. Are you registered on the ML?
Thanks for your review comments.
Something went wrong with git sendmail, Your message have not reached my email client (gmail)
A mail server rejected the mail to edgeble.ai domain (both you and Jagan) /me shrugs.
On 5/16/24 10:59 AM, Anand Moon wrote:
Imply DISPLAY_CPUINFO Kconfig options to support on all RK3588s and RK3588 boards, Its used to determine the reset cause of the board.
Cc: Jagan Teki jagan@edgeble.ai Signed-off-by: Anand Moon anand@edgeble.ai
arch/arm/mach-rockchip/Kconfig | 1 + configs/coolpi-4b-rk3588s_defconfig | 1 - configs/coolpi-cm5-evb-rk3588_defconfig | 1 - configs/evb-rk3588_defconfig | 1 - configs/generic-rk3588_defconfig | 1 - configs/jaguar-rk3588_defconfig | 1 - configs/nanopc-t6-rk3588_defconfig | 1 - configs/neu6a-io-rk3588_defconfig | 1 - configs/neu6b-io-rk3588_defconfig | 1 - configs/orangepi-5-plus-rk3588_defconfig | 1 - configs/orangepi-5-rk3588s_defconfig | 1 - configs/quartzpro64-rk3588_defconfig | 1 - configs/rock5a-rk3588s_defconfig | 1 - configs/rock5b-rk3588_defconfig | 1 - configs/toybrick-rk3588_defconfig | 1 - configs/turing-rk1-rk3588_defconfig | 1 - 16 files changed, 1 insertion(+), 15 deletions(-)
diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig index 2e9c71138e..1b5cc34f99 100644 --- a/arch/arm/mach-rockchip/Kconfig +++ b/arch/arm/mach-rockchip/Kconfig @@ -366,6 +366,7 @@ config ROCKCHIP_RK3588 imply SCMI_FIRMWARE imply SPL_ATF_NO_PLATFORM_PARAM if SPL_ATF imply SPL_MMC_HS200_SUPPORT if SPL_MMC && MMC_HS200_SUPPORT
imply DISPLAY_CPUINFOThis is unnecessary, it's already defaulting to y if building for ARM boards: https://elixir.bootlin.com/u-boot/latest/source/common/Kconfig#L596
See below...
I also don't think this is SO useful that we need to enable it on all rk3588 boards? But also, doesn't hurt, so... whatever I guess :) ?
While looking at the code, I think we can remove the ifdef in https://elixir.bootlin.com/u-boot/latest/source/arch/arm/mach-rockchip/cpu-i... because this file is anyway only compiled when CONFIG_DISPLAY_CPUINFO is set, c.f.
Oops I missed this changes, my bad I will dop my changes over here.
https://elixir.bootlin.com/u-boot/latest/source/arch/arm/mach-rockchip/Makef...
On Rockchip SoC CONFIG_DISPLAY_CPUINFO is been disable on most of the configs files.
-# CONFIG_DISPLAY_CPUINFO is not set
My changes are related to determine the reset cause of the board and display the results. its only enable on selected SoC hence I have to used this logic.
It's enabled for all Aarch64/Aarch32 SoCs by default. People explicitly disabled them in their own defconfig, either because the first person who added a board based on rk3588 didn't know or didn't care and everybody just copied it as a base, or because they don't care about it/don't want it.
In any case, you only need to change the defconfigs, nothing else.
U-Boot 2024.07-rc2-00397-g0370324feb-dirty (May 16 2024 - 13:11:14 +0530)
SoC: Rockchip rk3568 Reset cause: POR <----------- Model: Radxa ROCK3 Model A DRAM: 8 GiB (effective 7.7 GiB) PMIC: RK8090 (on=0x40, off=0x00) Core: 344 devices, 31 uclasses,
which also means...
https://elixir.bootlin.com/u-boot/latest/source/arch/arm/include/asm/arch-ro... should probably be ifdef'ed
which means...
https://elixir.bootlin.com/u-boot/latest/source/board/firefly/roc-pc-rk3399/... should probably also be ifdef'ed (but the config is enabled already (well... it wouldn't compile otherwsie), so I guess this is fine?).
This code changes will not affect this feature by default its enable on RK3399 boards.
Yes, but if you disable it, it won't compile anymore. (I'm not asking you to fix anything I've reported here though).
Cheers, Quentin
Hi Quentin
On Thu, 16 May 2024 at 16:13, Quentin Schulz quentin.schulz@cherry.de wrote:
Hi Anand,
On 5/16/24 12:12 PM, Anand Moon wrote:
Hi Quentin
On Thu, 16 May 2024 at 14:52, Quentin Schulz quentin.schulz@cherry.de wrote:
Hi Anand,
This is patch 9/9 but somehow I didn't receive any other patch, nor did the mailing list? c.f. https://lists.denx.de/pipermail/u-boot/2024-May/thread.html and https://lore.kernel.org/u-boot/. Are you registered on the ML?
Thanks for your review comments.
Something went wrong with git sendmail, Your message have not reached my email client (gmail)
A mail server rejected the mail to edgeble.ai domain (both you and Jagan) /me shrugs.
Yeah, something went wrong. It's Gmail server or u-boot mail server blocked I don't know the reason for this.
Remove me and Jagan (edgeble.ai) for now as of now.
On 5/16/24 10:59 AM, Anand Moon wrote:
Imply DISPLAY_CPUINFO Kconfig options to support on all RK3588s and RK3588 boards, Its used to determine the reset cause of the board.
diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig index 2e9c71138e..1b5cc34f99 100644 --- a/arch/arm/mach-rockchip/Kconfig +++ b/arch/arm/mach-rockchip/Kconfig @@ -366,6 +366,7 @@ config ROCKCHIP_RK3588 imply SCMI_FIRMWARE imply SPL_ATF_NO_PLATFORM_PARAM if SPL_ATF imply SPL_MMC_HS200_SUPPORT if SPL_MMC && MMC_HS200_SUPPORT
imply DISPLAY_CPUINFOThis is unnecessary, it's already defaulting to y if building for ARM boards: https://elixir.bootlin.com/u-boot/latest/source/common/Kconfig#L596
See below...
I also don't think this is SO useful that we need to enable it on all rk3588 boards? But also, doesn't hurt, so... whatever I guess :) ?
While looking at the code, I think we can remove the ifdef in https://elixir.bootlin.com/u-boot/latest/source/arch/arm/mach-rockchip/cpu-i... because this file is anyway only compiled when CONFIG_DISPLAY_CPUINFO is set, c.f.
Oops I missed this changes, my bad I will dop my changes over here.
https://elixir.bootlin.com/u-boot/latest/source/arch/arm/mach-rockchip/Makef...
On Rockchip SoC CONFIG_DISPLAY_CPUINFO is been disable on most of the configs files.
-# CONFIG_DISPLAY_CPUINFO is not set
My changes are related to determine the reset cause of the board and display the results. its only enable on selected SoC hence I have to used this logic.
It's enabled for all Aarch64/Aarch32 SoCs by default. People explicitly disabled them in their own defconfig, either because the first person who added a board based on rk3588 didn't know or didn't care and everybody just copied it as a base, or because they don't care about it/don't want it.
My series focuses on determining the reset cause of the boards Do we need to enable this feature ?
We are not compiling DISPLAY_CPUINFO for all for RK3568 and RK3588 But with the following changes enable this to be built for SPL_BUILD ( patch v5) in this series. wow it is built for all SoC.
diff --git a/arch/arm/mach-rockchip/Makefile b/arch/arm/mach-rockchip/Makefile index c07bdaee4c..6722e7c9ea 100644 --- a/arch/arm/mach-rockchip/Makefile +++ b/arch/arm/mach-rockchip/Makefile @@ -25,7 +25,7 @@ obj-y += boot_mode.o obj-$(CONFIG_ROCKCHIP_COMMON_BOARD) += board.o endif
-ifeq ($(CONFIG_TPL_BUILD),) +ifeq ($(CONFIG_SPL_BUILD)$(CONFIG_TPL_BUILD),) obj-$(CONFIG_DISPLAY_CPUINFO) += cpu-info.o endif
In any case, you only need to change the defconfigs, nothing else.
U-Boot 2024.07-rc2-00397-g0370324feb-dirty (May 16 2024 - 13:11:14 +0530)
SoC: Rockchip rk3568 Reset cause: POR <----------- Model: Radxa ROCK3 Model A DRAM: 8 GiB (effective 7.7 GiB) PMIC: RK8090 (on=0x40, off=0x00) Core: 344 devices, 31 uclasses,
which also means...
https://elixir.bootlin.com/u-boot/latest/source/arch/arm/include/asm/arch-ro... should probably be ifdef'ed
which means...
https://elixir.bootlin.com/u-boot/latest/source/board/firefly/roc-pc-rk3399/... should probably also be ifdef'ed (but the config is enabled already (well... it wouldn't compile otherwsie), so I guess this is fine?).
This code changes will not affect this feature by default its enable on RK3399 boards.
Yes, but if you disable it, it won't compile anymore. (I'm not asking you to fix anything I've reported here though).
Ok I will check this.
Cheers, Quentin
Thanks -Anand
participants (3)
-
Anand Moon -
Anand Moon -
Quentin Schulz