[U-Boot] [PATCH] COMMON: Fix HAVE_VENDOR_COMMON_LIB mistake
The conditional clause assigning HAVE_VENDOR_COMMON_LIB generated " y" instead of "y", causing the vendor lib not being built. This in turn made some spear boards and nvidia boards broken.
Signed-off-by: Marek Vasut marex@denx.de Cc: Wolfgang Denk wd@denx.de Cc: Daniel Schwierzeck daniel.schwierzeck@gmail.com --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile index 5ce5cc3..947f3ff 100644 --- a/Makefile +++ b/Makefile @@ -225,7 +225,7 @@ endif
OBJS := $(addprefix $(obj),$(OBJS))
-HAVE_VENDOR_COMMON_LIB = $(if $(wildcard board/$(VENDOR)/common/Makefile), y, n) +HAVE_VENDOR_COMMON_LIB = $(if $(wildcard board/$(VENDOR)/common/Makefile),y,n)
LIBS-y += lib/libgeneric.o LIBS-y += lib/lzma/liblzma.o
Hi Marek,
2012/8/14 Marek Vasut marex@denx.de:
The conditional clause assigning HAVE_VENDOR_COMMON_LIB generated " y" instead of "y", causing the vendor lib not being built. This in turn made some spear boards and nvidia boards broken.
Signed-off-by: Marek Vasut marex@denx.de Cc: Wolfgang Denk wd@denx.de Cc: Daniel Schwierzeck daniel.schwierzeck@gmail.com
Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile index 5ce5cc3..947f3ff 100644 --- a/Makefile +++ b/Makefile @@ -225,7 +225,7 @@ endif
OBJS := $(addprefix $(obj),$(OBJS))
-HAVE_VENDOR_COMMON_LIB = $(if $(wildcard board/$(VENDOR)/common/Makefile), y, n) +HAVE_VENDOR_COMMON_LIB = $(if $(wildcard board/$(VENDOR)/common/Makefile),y,n)
LIBS-y += lib/libgeneric.o LIBS-y += lib/lzma/liblzma.o -- 1.7.10.4
there is already a patch for this http://patchwork.ozlabs.org/patch/177235/
sorry for the inconvenience
Dear Daniel Schwierzeck,
Hi Marek,
2012/8/14 Marek Vasut marex@denx.de:
The conditional clause assigning HAVE_VENDOR_COMMON_LIB generated " y" instead of "y", causing the vendor lib not being built. This in turn made some spear boards and nvidia boards broken.
Signed-off-by: Marek Vasut marex@denx.de Cc: Wolfgang Denk wd@denx.de Cc: Daniel Schwierzeck daniel.schwierzeck@gmail.com
[..]
there is already a patch for this http://patchwork.ozlabs.org/patch/177235/
sorry for the inconvenience
That's ok, don't sweat it :)
Your patch is better, thanks Dan!
Best regards, Marek Vasut
participants (2)
-
Daniel Schwierzeck -
Marek Vasut