Dear Nikita,

In message 545B6844.2060608@compulab.co.il you wrote:

I've been trying to do some cleanup in common/lcd.c, and noticed some unused code:

Thanks!

The other case is MCC200 specific #ifdefs. It handles 1bpp BMPs, which I don't think is likely to be used by current and future boards, and the board itself is old, and has no maintainer. Perhaps this board can be removed?

I agree. We should remove the MCC200 and PRS200 boards.

Can you submit such a patch, please? TIA...

Best regards,

Wolfgang Denk

Hi Nikita,

On 6 November 2014 05:23, Nikita Kiryanov nikita@compulab.co.il wrote:

Hi all,

I've been trying to do some cleanup in common/lcd.c, and noticed some unused code:

One is the CONFIG_LCD_BMP_REL8 stuff. This code was added 2 years ago in patch 45d7f52511f43b71b623a502fdf31feb905f70a1, and so far it has no users (sandbox.h defines it, but only to fix a compilation error, see commit 0156444cf7e77e92fed7a61d6c6123b349f1d600).

No this is not dead code, we use it. It will be enabled on a few other boards before long, but the exynos upsteaming was stalled for a while.

Regards, Simon