[PATCH 1/1] sandbox: fix fall through in sandbox_flash_bulk()
Handling of SANDBOX_FLASH_EP_OUT should never fall through to SANDBOX_FLASH_EP_IN.
This addresses a warning shown when compiling with -Wimplicit-fallthrough.
Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com --- drivers/usb/emul/sandbox_flash.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/usb/emul/sandbox_flash.c b/drivers/usb/emul/sandbox_flash.c index 01ccc4bc17..7c5c1ab3de 100644 --- a/drivers/usb/emul/sandbox_flash.c +++ b/drivers/usb/emul/sandbox_flash.c @@ -266,6 +266,7 @@ static int sandbox_flash_bulk(struct udevice *dev, struct usb_device *udev, default: break; } + break; case SANDBOX_FLASH_EP_IN: switch (info->phase) { case SCSIPH_DATA:
On Sat, 1 Apr 2023 at 19:25, Heinrich Schuchardt < heinrich.schuchardt@canonical.com> wrote:
Handling of SANDBOX_FLASH_EP_OUT should never fall through to SANDBOX_FLASH_EP_IN.
This addresses a warning shown when compiling with -Wimplicit-fallthrough.
Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com
drivers/usb/emul/sandbox_flash.c | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Simon Glass sjg@chromium.org
On Sat, 1 Apr 2023 at 19:25, Heinrich Schuchardt < heinrich.schuchardt@canonical.com> wrote:
Handling of SANDBOX_FLASH_EP_OUT should never fall through to SANDBOX_FLASH_EP_IN.
This addresses a warning shown when compiling with -Wimplicit-fallthrough.
Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com
drivers/usb/emul/sandbox_flash.c | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot-dm, thanks!
participants (2)
-
Heinrich Schuchardt -
Simon Glass