[U-Boot] [PATCH 1/1] arm: bcm235xx: clk_set_rate avoid possible NULL deref

It does not make sense first to dereference c and then to check if it is NULL.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de --- arch/arm/cpu/armv7/bcm235xx/clk-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/cpu/armv7/bcm235xx/clk-core.c b/arch/arm/cpu/armv7/bcm235xx/clk-core.c index ee4b34574a..89e367be82 100644 --- a/arch/arm/cpu/armv7/bcm235xx/clk-core.c +++ b/arch/arm/cpu/armv7/bcm235xx/clk-core.c @@ -493,9 +493,9 @@ int clk_set_rate(struct clk *c, unsigned long rate) { int ret;
- debug("%s: %s rate=%ld\n", __func__, c->name, rate); if (!c || !c->ops || !c->ops->set_rate) return -EINVAL; + debug("%s: %s rate=%ld\n", __func__, c->name, rate);
if (c->use_cnt) return -EINVAL;

On Sun, Jul 30, 2017 at 08:22:47PM +0200, xypron.glpk@gmx.de wrote:
It does not make sense first to dereference c and then to check if it is NULL.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
Applied to u-boot/master, thanks!
participants (2)
-
Heinrich Schuchardt
-
Tom Rini