[PATCH] net: dsa: Fix OF fallback lookup for ports

The variable 'node' was already invalid, so using it for further lookup will not work.
Signed-off-by: Marcus Comstedt marcus.comstedt@requtech.se ---
net/dsa-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/dsa-uclass.c b/net/dsa-uclass.c index dd78e5744d..f64c68e340 100644 --- a/net/dsa-uclass.c +++ b/net/dsa-uclass.c @@ -381,7 +381,7 @@ static int dsa_post_bind(struct udevice *dev)
node = ofnode_find_subnode(node, "ports"); if (!ofnode_valid(node)) - node = ofnode_find_subnode(node, "ethernet-ports"); + node = ofnode_find_subnode(dev_ofnode(dev), "ethernet-ports"); if (!ofnode_valid(node)) { dev_err(dev, "ports node is missing under DSA device!\n"); return -EINVAL;

-----Original Message----- From: Marcus Comstedt marcus.comstedt@requtech.se Sent: Monday, May 15, 2023 6:44 PM To: u-boot@lists.denx.de Cc: Marcus Comstedt marcus.comstedt@requtech.se; Claudiu Manoil claudiu.manoil@nxp.com; Joe Hershberger joe.hershberger@ni.com; Ramon Fried rfried.dev@gmail.com Subject: [PATCH] net: dsa: Fix OF fallback lookup for ports
The variable 'node' was already invalid, so using it for further lookup will not work.
Signed-off-by: Marcus Comstedt marcus.comstedt@requtech.se
Fixes: fc054d563b (net: Introduce DSA class for Ethernet switches) Reviewed-by: Claudiu Manoil claudiu.manoil@nxp.com
Thanks. Funny the issue was caught so late. Apparently the newer 'ethernet-ports' term had a slow adoption.
participants (2)
-
Claudiu Manoil
-
Marcus Comstedt