[U-Boot] [PATCH] cmd_eeprom: fix i2c_{read|write} usage if env is in I2C EEPROM

Data "offset" is not used directly in case of I2C EEPROM. Istead it is split into "block number" and "offset within mentioned block". Which are "addr[0]" and "addr[1]" respectively.
Signed-off-by: Alexey Brodkin abrodkin@synopsys.com
Cc: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com cc: Peter Tyser ptyser@xes-inc.com Cc: Heiko Schocher hs@denx.de Cc: Wolfgang Denk wd@denx.de Cc: Stefan Roese sr@denx.de Cc: Mischa Jonker mjonker@synopsys.com --- common/cmd_eeprom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/cmd_eeprom.c b/common/cmd_eeprom.c index ef694d8..02539c4 100644 --- a/common/cmd_eeprom.c +++ b/common/cmd_eeprom.c @@ -161,7 +161,7 @@ int eeprom_read (unsigned dev_addr, unsigned offset, uchar *buffer, unsigned cnt #if defined(CONFIG_SPI) && !defined(CONFIG_ENV_EEPROM_IS_ON_I2C) spi_read (addr, alen, buffer, len); #else - if (i2c_read (addr[0], offset, alen-1, buffer, len) != 0) + if (i2c_read (addr[0], addr[1], alen-1, buffer, len) != 0) rcode = 1; #endif buffer += len; @@ -339,7 +339,7 @@ int eeprom_write (unsigned dev_addr, unsigned offset, uchar *buffer, unsigned cn /* Write is enabled ... now write eeprom value. */ #endif - if (i2c_write (addr[0], offset, alen-1, buffer, len) != 0) + if (i2c_write (addr[0], addr[1], alen-1, buffer, len) != 0) rcode = 1;
#endif

Hello Alexey,
Am 07.11.2013 14:51, schrieb Alexey Brodkin:
Data "offset" is not used directly in case of I2C EEPROM. Istead it is split into "block number" and "offset within mentioned block". Which are "addr[0]" and "addr[1]" respectively.
Signed-off-by: Alexey Brodkinabrodkin@synopsys.com
Cc: Jean-Christophe PLAGNIOL-VILLARDplagnioj@jcrosoft.com cc: Peter Tyserptyser@xes-inc.com Cc: Heiko Schocherhs@denx.de Cc: Wolfgang Denkwd@denx.de Cc: Stefan Roesesr@denx.de Cc: Mischa Jonkermjonker@synopsys.com
common/cmd_eeprom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks!
Apllied to u-boot-i2c.git
bye, Heiko
participants (2)
-
Alexey Brodkin
-
Heiko Schocher