[U-Boot] [PATCH] thor: cosmetic: Update the cmd_thordown help message to present example usage
Signed-off-by: Lukasz Majewski l.majewski@samsung.com --- common/cmd_thordown.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cmd_thordown.c b/common/cmd_thordown.c index 8ed1dc6..25de048 100644 --- a/common/cmd_thordown.c +++ b/common/cmd_thordown.c @@ -64,7 +64,7 @@ done:
U_BOOT_CMD(thordown, CONFIG_SYS_MAXARGS, 1, do_thor_down, "TIZEN "THOR" downloader", - "<USB_controller> <interface> <dev>\n" + "<USB_controller> <interface> <dev> e.g. thor 0 mmc 0\n" " - device software upgrade via LTHOR TIZEN dowload\n" " program via <USB_controller> on device <dev>,\n" " attached to interface <interface>\n"
On 06/20/2014 01:35 AM, Lukasz Majewski wrote:
diff --git a/common/cmd_thordown.c b/common/cmd_thordown.c
U_BOOT_CMD(thordown, CONFIG_SYS_MAXARGS, 1, do_thor_down, "TIZEN "THOR" downloader",
"<USB_controller> <interface> <dev>\n"
"<USB_controller> <interface> <dev> e.g. thor 0 mmc 0\n" " - device software upgrade via LTHOR TIZEN dowload\n" " program via <USB_controller> on device <dev>,\n" " attached to interface <interface>\n"
I couldn't find any examples of other commands which do this. Rathe than add the "e.g." text, perhaps just add the word "thor" at the start of the command parameter list. That's much more common in existing commands:
- "<USB_controller> <interface> <dev>\n" + "thor <USB_controller> <interface> <dev>\n"
Hi Stephen,
On 06/20/2014 01:35 AM, Lukasz Majewski wrote:
diff --git a/common/cmd_thordown.c b/common/cmd_thordown.c
U_BOOT_CMD(thordown, CONFIG_SYS_MAXARGS, 1, do_thor_down, "TIZEN "THOR" downloader",
"<USB_controller> <interface> <dev>\n"
"<USB_controller> <interface> <dev> e.g. thor 0 mmc 0\n" " - device software upgrade via LTHOR TIZEN dowload\n" " program via <USB_controller> on device <dev>,\n" " attached to interface <interface>\n"I couldn't find any examples of other commands which do this. Rathe than add the "e.g." text, perhaps just add the word "thor" at the start of the command parameter list. That's much more common in existing commands:
"<USB_controller> <interface> <dev>\n"
"thor <USB_controller> <interface> <dev>\n"
Ok. Thanks.
Signed-off-by: Lukasz Majewski l.majewski@samsung.com --- common/cmd_thordown.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cmd_thordown.c b/common/cmd_thordown.c index 2dd7509..96f7d32 100644 --- a/common/cmd_thordown.c +++ b/common/cmd_thordown.c @@ -64,7 +64,7 @@ exit:
U_BOOT_CMD(thordown, CONFIG_SYS_MAXARGS, 1, do_thor_down, "TIZEN "THOR" downloader", - "<USB_controller> <interface> <dev>\n" + "thor <USB_controller> <interface> <dev>\n" " - device software upgrade via LTHOR TIZEN dowload\n" " program via <USB_controller> on device <dev>,\n" " attached to interface <interface>\n"
On Monday, June 23, 2014 at 09:35:04 AM, Lukasz Majewski wrote:
Signed-off-by: Lukasz Majewski l.majewski@samsung.com
common/cmd_thordown.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cmd_thordown.c b/common/cmd_thordown.c index 2dd7509..96f7d32 100644 --- a/common/cmd_thordown.c +++ b/common/cmd_thordown.c @@ -64,7 +64,7 @@ exit:
U_BOOT_CMD(thordown, CONFIG_SYS_MAXARGS, 1, do_thor_down, "TIZEN "THOR" downloader",
"<USB_controller> <interface> <dev>\n"
"thor <USB_controller> <interface> <dev>\n" " - device software upgrade via LTHOR TIZEN dowload\n" " program via <USB_controller> on device <dev>,\n" " attached to interface <interface>\n"
Looks like v2014.07 matter to me. A description in the patch would be appreciated though, so can you do a V3 with it ?
Best regards, Marek Vasut
Dear all,
Signed-off-by: Lukasz Majewski l.majewski@samsung.com
common/cmd_thordown.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cmd_thordown.c b/common/cmd_thordown.c index 2dd7509..96f7d32 100644 --- a/common/cmd_thordown.c +++ b/common/cmd_thordown.c @@ -64,7 +64,7 @@ exit:
U_BOOT_CMD(thordown, CONFIG_SYS_MAXARGS, 1, do_thor_down, "TIZEN "THOR" downloader",
"<USB_controller> <interface> <dev>\n"
"thor <USB_controller> <interface> <dev>\n" " - device software upgrade via LTHOR TIZEN dowload\n" " program via <USB_controller> on device <dev>,\n" " attached to interface <interface>\n"
Please discard this patch. I need to devise more neat solution.
participants (3)
-
Lukasz Majewski -
Marek Vasut -
Stephen Warren