[U-Boot] [PATCH] corenet_ds: Update CONFIG_SYS_GBL_DATA_SIZE to deal with growth in gd_t
The recent change the env code added an additional 32 bytes into gd_t and that causes to grow pass the previous CONFIG_SYS_GBL_DATA_SIZE size.
Signed-off-by: Kumar Gala galak@kernel.crashing.org --- include/configs/corenet_ds.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/configs/corenet_ds.h b/include/configs/corenet_ds.h index 85147d0..2733fb2 100644 --- a/include/configs/corenet_ds.h +++ b/include/configs/corenet_ds.h @@ -213,7 +213,7 @@ #endif #define CONFIG_SYS_INIT_RAM_END 0x00004000 /* End of used area in RAM */
-#define CONFIG_SYS_GBL_DATA_SIZE 128 /* num bytes initial data */ +#define CONFIG_SYS_GBL_DATA_SIZE 256 /* num bytes initial data */ #define CONFIG_SYS_GBL_DATA_OFFSET (CONFIG_SYS_INIT_RAM_END - CONFIG_SYS_GBL_DATA_SIZE) #define CONFIG_SYS_INIT_SP_OFFSET CONFIG_SYS_GBL_DATA_OFFSET
Dear Kumar Gala,
In message 1287731621-19353-1-git-send-email-galak@kernel.crashing.org you wrote:
The recent change the env code added an additional 32 bytes into gd_t and that causes to grow pass the previous CONFIG_SYS_GBL_DATA_SIZE size.
Signed-off-by: Kumar Gala galak@kernel.crashing.org
One thing I always wondered is why we don't simply use sizeof(gd_t) instead. What do you think?
Best regards,
Wolfgang Denk
On Oct 22, 2010, at 2:22 AM, Wolfgang Denk wrote:
Dear Kumar Gala,
In message 1287731621-19353-1-git-send-email-galak@kernel.crashing.org you wrote:
The recent change the env code added an additional 32 bytes into gd_t and that causes to grow pass the previous CONFIG_SYS_GBL_DATA_SIZE size.
Signed-off-by: Kumar Gala galak@kernel.crashing.org
One thing I always wondered is why we don't simply use sizeof(gd_t) instead. What do you think?
I was wondering the same thing, let me try it and see what happens.
- k
On Oct 22, 2010, at 2:24 AM, Kumar Gala wrote:
On Oct 22, 2010, at 2:22 AM, Wolfgang Denk wrote:
Dear Kumar Gala,
In message 1287731621-19353-1-git-send-email-galak@kernel.crashing.org you wrote:
The recent change the env code added an additional 32 bytes into gd_t and that causes to grow pass the previous CONFIG_SYS_GBL_DATA_SIZE size.
Signed-off-by: Kumar Gala galak@kernel.crashing.org
One thing I always wondered is why we don't simply use sizeof(gd_t) instead. What do you think?
I was wondering the same thing, let me try it and see what happens.
Requires asm-offset support like in kernel for us to this properly. Will leave it as is for now and fix for post v2010.12
- k
On Oct 22, 2010, at 2:13 AM, Kumar Gala wrote:
The recent change the env code added an additional 32 bytes into gd_t and that causes to grow pass the previous CONFIG_SYS_GBL_DATA_SIZE size.
Signed-off-by: Kumar Gala galak@kernel.crashing.org
include/configs/corenet_ds.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
applied to 85xx
- k
participants (2)
-
Kumar Gala -
Wolfgang Denk