[U-Boot] [PATCH] rockchip: video: mipi: Fix phy frequency setting
There was an incorrect check when looping and finding the first fast enough frequency in the freq_rang table. The code did actually return the first that was either exactly correct or too slow.
Signed-off-by: Richard Röjfors richard@puffinpack.se --- drivers/video/rockchip/rk_mipi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/rockchip/rk_mipi.c b/drivers/video/rockchip/rk_mipi.c index 4fe8f47441..4fc8c1f3b5 100644 --- a/drivers/video/rockchip/rk_mipi.c +++ b/drivers/video/rockchip/rk_mipi.c @@ -241,7 +241,7 @@ int rk_mipi_phy_enable(struct udevice *dev)
/* select the suitable value for fsfreqrang reg */ for (i = 0; i < ARRAY_SIZE(freq_rang); i++) { - if (ddr_clk / (MHz) >= freq_rang[i][0]) + if (ddr_clk / (MHz) <= freq_rang[i][0]) break; } if (i == ARRAY_SIZE(freq_rang)) {
On 14.11.2018, at 14:13, Richard Röjfors richard.rojfors@gmail.com wrote:
There was an incorrect check when looping and finding the first fast enough frequency in the freq_rang table. The code did actually return the first that was either exactly correct or too slow.
Signed-off-by: Richard Röjfors richard@puffinpack.se
Reviewed-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com
There was an incorrect check when looping and finding the first fast enough frequency in the freq_rang table. The code did actually return the first that was either exactly correct or too slow.
Signed-off-by: Richard Röjfors richard@puffinpack.se Reviewed-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com
drivers/video/rockchip/rk_mipi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to u-boot-rockchip, thanks!
participants (2)
-
Philipp Tomsich -
Richard Röjfors