[PATCH] firmware: ti_sci: Add missing LF in error message
The "Message not acknowledged" error message is missing a line feed, leading to the console log getting garbled and joined together with whatever the next output is in case this error happens:
"ti_sci system-controller@44043000: Message not acknowledgedAuthentication failed!"
Fix ths by adding the missing linefeed character.
Signed-off-by: Andreas Dannenberg dannenberg@ti.com --- drivers/firmware/ti_sci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c index bd7379ae55..72f572d824 100644 --- a/drivers/firmware/ti_sci.c +++ b/drivers/firmware/ti_sci.c @@ -265,7 +265,7 @@ static int ti_sci_do_xfer(struct ti_sci_info *info, if (xfer->rx_len) { ret = ti_sci_get_response(info, xfer, &info->chan_rx); if (!ti_sci_is_response_ack(xfer->tx_message.buf)) { - dev_err(info->dev, "Message not acknowledged"); + dev_err(info->dev, "Message not acknowledged\n"); ret = -ENODEV; } }
On 5/9/23 4:38 PM, Andreas Dannenberg wrote:
The "Message not acknowledged" error message is missing a line feed, leading to the console log getting garbled and joined together with whatever the next output is in case this error happens:
"ti_sci system-controller@44043000: Message not acknowledgedAuthentication failed!"
Fix ths by adding the missing linefeed character.
s/ths/this
Signed-off-by: Andreas Dannenberg dannenberg@ti.com
Good find,
Acked-by: Andrew Davis afd@ti.com
drivers/firmware/ti_sci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c index bd7379ae55..72f572d824 100644 --- a/drivers/firmware/ti_sci.c +++ b/drivers/firmware/ti_sci.c @@ -265,7 +265,7 @@ static int ti_sci_do_xfer(struct ti_sci_info *info, if (xfer->rx_len) { ret = ti_sci_get_response(info, xfer, &info->chan_rx); if (!ti_sci_is_response_ack(xfer->tx_message.buf)) {
dev_err(info->dev, "Message not acknowledged");
dev_err(info->dev, "Message not acknowledged\n"); ret = -ENODEV;
On Wed, May 10, 2023 at 08:46:37AM -0700, Andrew Davis wrote:
On 5/9/23 4:38 PM, Andreas Dannenberg wrote:
The "Message not acknowledged" error message is missing a line feed, leading to the console log getting garbled and joined together with whatever the next output is in case this error happens:
"ti_sci system-controller@44043000: Message not acknowledgedAuthentication failed!"
Fix ths by adding the missing linefeed character.
s/ths/this
Signed-off-by: Andreas Dannenberg dannenberg@ti.com
Good find,
I'll do my best to remember to fix this before pushing (checkpatch will remind me, I think), no need to v2.
On Wed, May 10, 2023 at 12:09:47PM -0400, Tom Rini wrote:
On Wed, May 10, 2023 at 08:46:37AM -0700, Andrew Davis wrote:
On 5/9/23 4:38 PM, Andreas Dannenberg wrote:
The "Message not acknowledged" error message is missing a line feed, leading to the console log getting garbled and joined together with whatever the next output is in case this error happens:
"ti_sci system-controller@44043000: Message not acknowledgedAuthentication failed!"
Fix ths by adding the missing linefeed character.
s/ths/this
This slipped through the cracks on my end...
Signed-off-by: Andreas Dannenberg dannenberg@ti.com
Good find,
I'll do my best to remember to fix this before pushing (checkpatch will remind me, I think), no need to v2.
Thanks Tom, I appreciate it.
-- Andreas Dannenberg Texas Instruments Inc
-- Tom
On Tue, May 09, 2023 at 04:38:13PM -0500, Andreas Dannenberg wrote:
The "Message not acknowledged" error message is missing a line feed, leading to the console log getting garbled and joined together with whatever the next output is in case this error happens:
"ti_sci system-controller@44043000: Message not acknowledgedAuthentication failed!"
Fix ths by adding the missing linefeed character.
Signed-off-by: Andreas Dannenberg dannenberg@ti.com Acked-by: Andrew Davis afd@ti.com
Applied to u-boot/next, thanks!
participants (3)
-
Andreas Dannenberg -
Andrew Davis -
Tom Rini