[U-Boot] [PATCH u-boot git] DaVinci now respects SKIP_LOWLEVEL_INIT
From: David Brownell dbrownell@users.sourceforge.net
Don't needlessly include lowlevel init code; that's only really needed with boot-from NOR (not boot-from-NAND). The 2nd stage loader (UBL) handles that before it loads U-Boot.
Signed-off-by: David Brownell dbrownell@users.sourceforge.net
--- a/cpu/arm926ejs/davinci/lowlevel_init.S +++ b/cpu/arm926ejs/davinci/lowlevel_init.S @@ -45,6 +45,8 @@
#include <config.h>
+#ifndef CONFIG_SKIP_LOWLEVEL_INIT + .globl lowlevel_init lowlevel_init:
@@ -705,3 +707,5 @@ DDR2_START_ADDR: .word 0x80000000 DUMMY_VAL: .word 0xa55aa55a + +#endif /* !CONFIG_SKIP_LOWLEVEL_INIT */
On 15:46 Sun 12 Apr , David Brownell wrote:
From: David Brownell dbrownell@users.sourceforge.net
Don't needlessly include lowlevel init code; that's only really needed with boot-from NOR (not boot-from-NAND). The 2nd stage loader (UBL) handles that before it loads U-Boot.
Signed-off-by: David Brownell dbrownell@users.sourceforge.net
--- a/cpu/arm926ejs/davinci/lowlevel_init.S +++ b/cpu/arm926ejs/davinci/lowlevel_init.S @@ -45,6 +45,8 @@
#include <config.h>
+#ifndef CONFIG_SKIP_LOWLEVEL_INIT
please move this to the Makefile
Best Regards, J.
On Monday 13 April 2009, Jean-Christophe PLAGNIOL-VILLARD wrote:
please move this to the Makefile
===== CUT HERE From: David Brownell dbrownell@users.sourceforge.net
Don't needlessly include lowlevel init code; that's only really needed with boot-from NOR (not boot-from-NAND). The 2nd stage loader (UBL) handles that before it loads U-Boot.
Signed-off-by: David Brownell dbrownell@users.sourceforge.net --- cpu/arm926ejs/davinci/Makefile | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
--- a/cpu/arm926ejs/davinci/Makefile +++ b/cpu/arm926ejs/davinci/Makefile @@ -28,7 +28,11 @@ include $(TOPDIR)/config.mk LIB = $(obj)lib$(SOC).a
COBJS = timer.o ether.o lxt972.o dp83848.o -SOBJS = lowlevel_init.o reset.o +SOBJS = reset.o + +ifndef CONFIG_SKIP_LOWLEVEL_INIT + SOBJS += lowlevel_init.o +endif
SRCS := $(START:.o=.S) $(SOBJS:.o=.S) $(COBJS:.o=.c) OBJS := $(addprefix $(obj),$(COBJS) $(SOBJS))
Dear David Brownell,
In message 200904131617.55202.david-b@pacbell.net you wrote:
COBJS = timer.o ether.o lxt972.o dp83848.o -SOBJS = lowlevel_init.o reset.o +SOBJS = reset.o
+ifndef CONFIG_SKIP_LOWLEVEL_INIT
- SOBJS += lowlevel_init.o
+endif
Please don't do it like this. Please use the same style like everybody else.
Best regards,
Wolfgang Denk
On Tuesday 14 April 2009, Wolfgang Denk wrote:
Please don't do it like this. Please use the same style like everybody else.
Having to guess .. you mean don't indent?
========== CUT HERE From: David Brownell dbrownell@users.sourceforge.net
Don't needlessly include lowlevel init code; that's only really needed with boot-from NOR (not boot-from-NAND). The 2nd stage loader (UBL) handles that before it loads U-Boot.
Signed-off-by: David Brownell dbrownell@users.sourceforge.net --- cpu/arm926ejs/davinci/Makefile | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
--- a/cpu/arm926ejs/davinci/Makefile +++ b/cpu/arm926ejs/davinci/Makefile @@ -28,7 +28,11 @@ include $(TOPDIR)/config.mk LIB = $(obj)lib$(SOC).a
COBJS = timer.o ether.o lxt972.o dp83848.o -SOBJS = lowlevel_init.o reset.o +SOBJS = reset.o + +ifndef CONFIG_SKIP_LOWLEVEL_INIT +SOBJS += lowlevel_init.o +endif
SRCS := $(START:.o=.S) $(SOBJS:.o=.S) $(COBJS:.o=.c) OBJS := $(addprefix $(obj),$(COBJS) $(SOBJS))
Hi
2009/4/14 David Brownell david-b@pacbell.net:
On Tuesday 14 April 2009, Wolfgang Denk wrote:
Please don't do it like this. Please use the same style like everybody else.
Having to guess .. you mean don't indent?
========== CUT HERE From: David Brownell dbrownell@users.sourceforge.net
Don't needlessly include lowlevel init code; that's only really needed with boot-from NOR (not boot-from-NAND). The 2nd stage loader (UBL) handles that before it loads U-Boot.
Signed-off-by: David Brownell dbrownell@users.sourceforge.net
cpu/arm926ejs/davinci/Makefile | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
--- a/cpu/arm926ejs/davinci/Makefile +++ b/cpu/arm926ejs/davinci/Makefile @@ -28,7 +28,11 @@ include $(TOPDIR)/config.mk LIB = $(obj)lib$(SOC).a
COBJS = timer.o ether.o lxt972.o dp83848.o -SOBJS = lowlevel_init.o reset.o +SOBJS = reset.o
+ifndef CONFIG_SKIP_LOWLEVEL_INIT +SOBJS += lowlevel_init.o +endif
I was about to suggest that they were hinting at something like: SOBJS-$(CONFIG_SKIP_LOWLEVEL_INIT) += lowlevel_init.o
But then I realized that lowlevel_init.o should be omitted if SKIP_LOWLEVEL.. is defined, and I don't know how to do that.
Regards, Magnus
On 08:52 Tue 14 Apr , David Brownell wrote:
On Tuesday 14 April 2009, Wolfgang Denk wrote:
Please don't do it like this. Please use the same style like everybody else.
Having to guess .. you mean don't indent?
yes
please move the Makefile to SOBJS-y COBJS-y
Best Regards, J.
On Thursday 16 April 2009, Jean-Christophe PLAGNIOL-VILLARD wrote:
please move the Makefile to SOBJS-y COBJS-y
I'm not following. A quick scan of boards I've used shows most of them using SOBJS, rather than SOBJS-y.
And how would you propose making a *negative* config option (as in $SUBJECT) fit into that SOBJ-$(X) framework?
I'd have expected you to want such a change in a separate patch too, since it's unrelated to $SUBJECT ... ;)
On 23:38 Thu 16 Apr , David Brownell wrote:
On Thursday 16 April 2009, Jean-Christophe PLAGNIOL-VILLARD wrote:
please move the Makefile to SOBJS-y COBJS-y
I'm not following. A quick scan of boards I've used shows most of them using SOBJS, rather than SOBJS-y.
And how would you propose making a *negative* config option (as in $SUBJECT) fit into that SOBJ-$(X) framework?
yes you can not do it so the ifndef is correct
I'd have expected you to want such a change in a separate patch too, since it's unrelated to $SUBJECT ... ;)
yes for the current one the remove of the tab is enough
Best Regards, J.
participants (4)
-
David Brownell -
Jean-Christophe PLAGNIOL-VILLARD -
Magnus Lilja -
Wolfgang Denk