[U-Boot] [PATCH] board: am57xx: Fix missing check for beagle_x15

When beagleboard-X15 is booted, we see the following log: Unidentified board claims BBRDX15_ in eeprom header
This is because of the missing check for x15 (the default) and reports an error for a valid board configuration. fix the same.
Signed-off-by: Nishanth Menon nm@ti.com ---
based on v2016.09-rc2
board/ti/am57xx/board.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/ti/am57xx/board.c b/board/ti/am57xx/board.c index 927d1364fe46..3c3ec8a74e78 100644 --- a/board/ti/am57xx/board.c +++ b/board/ti/am57xx/board.c @@ -342,7 +342,7 @@ static void setup_board_eeprom_env(void) name = "am57xx_evm"; else if (board_is_am572x_idk()) name = "am572x_idk"; - else + else if (!board_is_x15()) printf("Unidentified board claims %s in eeprom header\n", board_ti_get_name());

On Friday 02 September 2016 01:23 PM, Nishanth Menon wrote:
When beagleboard-X15 is booted, we see the following log: Unidentified board claims BBRDX15_ in eeprom header
This is because of the missing check for x15 (the default) and reports an error for a valid board configuration. fix the same.
Signed-off-by: Nishanth Menon nm@ti.com
based on v2016.09-rc2
board/ti/am57xx/board.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/ti/am57xx/board.c b/board/ti/am57xx/board.c index 927d1364fe46..3c3ec8a74e78 100644 --- a/board/ti/am57xx/board.c +++ b/board/ti/am57xx/board.c @@ -342,7 +342,7 @@ static void setup_board_eeprom_env(void) name = "am57xx_evm"; else if (board_is_am572x_idk()) name = "am572x_idk";
- else
- else if (!board_is_x15()) printf("Unidentified board claims %s in eeprom header\n", board_ti_get_name());
Instead an entry can be added for x15 like below? So, that future rev of x15 can be updated
diff --git a/board/ti/am57xx/board.c b/board/ti/am57xx/board.c index bc5ff6e..cf095ce 100644 --- a/board/ti/am57xx/board.c +++ b/board/ti/am57xx/board.c @@ -308,7 +308,9 @@ static void setup_board_eeprom_env(void) if (rc) goto invalid_eeprom;
- if (board_is_am572x_evm()) + if (board_is_x15()) + name = "beagle_x15"; + else if (board_is_am572x_evm()) name = "am57xx_evm"; else if (board_is_am572x_idk()) name = "am572x_idk";

On Fri, Sep 2, 2016 at 6:04 AM, Lokesh Vutla lokeshvutla@ti.com wrote:
On Friday 02 September 2016 01:23 PM, Nishanth Menon wrote:
[...]
Instead an entry can be added for x15 like below? So, that future rev of x15 can be updated
diff --git a/board/ti/am57xx/board.c b/board/ti/am57xx/board.c index bc5ff6e..cf095ce 100644 --- a/board/ti/am57xx/board.c +++ b/board/ti/am57xx/board.c @@ -308,7 +308,9 @@ static void setup_board_eeprom_env(void) if (rc) goto invalid_eeprom;
if (board_is_am572x_evm())
if (board_is_x15())
name = "beagle_x15";
else if (board_is_am572x_evm()) name = "am57xx_evm"; else if (board_is_am572x_idk()) name = "am572x_idk";
Yeah, makes sense to prepare for what we know is incoming anyways...
participants (2)
-
Lokesh Vutla
-
Nishanth Menon