[U-Boot-Users] [PATCH] ide: Remove spurious second include of io.h

Signed-off-by: Marcel Ziswiler marcel@ziswiler.com --- common/cmd_ide.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/common/cmd_ide.c b/common/cmd_ide.c index ead7e10..8280906 100644 --- a/common/cmd_ide.c +++ b/common/cmd_ide.c @@ -31,7 +31,6 @@ #include <command.h> #include <image.h> #include <asm/byteorder.h> -#include <asm/io.h>
#if defined(CONFIG_IDE_8xx_DIRECT) || defined(CONFIG_IDE_PCMCIA) # include <pcmcia.h>

In message 1209688453-30518-1-git-send-email-marcel@ziswiler.com you wrote:
Signed-off-by: Marcel Ziswiler marcel@ziswiler.com
common/cmd_ide.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/common/cmd_ide.c b/common/cmd_ide.c index ead7e10..8280906 100644 --- a/common/cmd_ide.c +++ b/common/cmd_ide.c @@ -31,7 +31,6 @@ #include <command.h> #include <image.h> #include <asm/byteorder.h> -#include <asm/io.h>
Ummm... should we not rather remove the second include, with all the #ifdef around?
Best regards,
Wolfgang Denk

Removed the second include, with all the #ifdef around as suggested by Wolfgang.
Signed-off-by: Marcel Ziswiler marcel@ziswiler.com --- common/cmd_ide.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/common/cmd_ide.c b/common/cmd_ide.c index ead7e10..cac99d5 100644 --- a/common/cmd_ide.c +++ b/common/cmd_ide.c @@ -52,10 +52,6 @@ # include <status_led.h> #endif
-#ifndef __PPC__ -#include <asm/io.h> -#endif - #ifdef CONFIG_IDE_8xx_DIRECT DECLARE_GLOBAL_DATA_PTR; #endif

In message 1209946326-18919-1-git-send-email-marcel@ziswiler.com you wrote:
Removed the second include, with all the #ifdef around as suggested by Wolfgang.
Signed-off-by: Marcel Ziswiler marcel@ziswiler.com
common/cmd_ide.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
participants (2)
-
Marcel Ziswiler
-
Wolfgang Denk