On Fri, May 4, 2018 at 10:30 PM, Nguyen, Dinh dinh.nguyen@intel.com wrote:

...

-----Original Message----- From: Tan, Ley Foon Sent: Friday, May 4, 2018 5:49 AM To: u-boot@lists.denx.de Cc: Marek Vasut marex@denx.de; Ley Foon Tan lftan.linux@gmail.com; See, Chin Liang chin.liang.see@intel.com; Nguyen, Dinh dinh.nguyen@intel.com; Tan, Ley Foon ley.foon.tan@intel.com Subject: [PATCH v2 2/3] serial: ns16550: Add reset ctrl to driver

Add code to reset all reset signals as in serial DT node. A reset property is an optional feature, so do not fail if a reset property is not present.

If a reset property is discovered, then use it to deassert, thus bringing the IP out of reset.

Signed-off-by: Ley Foon Tan ley.foon.tan@intel.com Reviewed-by: Marek Vasut marex@denx.de

---

drivers/serial/ns16550.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c index 53550bf..457b636 100644 --- a/drivers/serial/ns16550.c +++ b/drivers/serial/ns16550.c @@ -9,6 +9,7 @@ #include <dm.h> #include <errno.h> #include <ns16550.h> +#include <reset.h> #include <serial.h> #include <watchdog.h> #include <linux/types.h> @@ -177,6 +178,7 @@ void NS16550_init(NS16550_t com_port, int baud_divisor) #if defined(CONFIG_ARCH_OMAP2PLUS) serial_out(0x7, &com_port->mdr1); /* mode select reset TL16C750*/ #endif

• serial_out(UART_MCRVAL, &com_port->mcr);
  serial_out(ns16550_getfcr(com_port), &com_port->fcr);
  if (baud_divisor != -1)
  

@@ -371,6 +373,16 @@ int ns16550_serial_probe(struct udevice *dev) { struct NS16550 *const com_port = dev_get_priv(dev);

+#ifdef CONFIG_DM_RESET

You don't need this wrapper.

Noted.

...

• struct reset_ctl_bulk reset_bulk;
  

• int ret;
  

• ret = reset_get_bulk(dev, &reset_bulk);
  

• if (!ret)
  

•         reset_deassert_bulk(&reset_bulk);
  

+#endif

• com_port->plat = dev_get_platdata(dev);
  NS16550_init(com_port, -1);
  
  

-- 1.7.1

-----Original Message----- From: Tan, Ley Foon Sent: Friday, May 4, 2018 5:49 AM To: u-boot@lists.denx.de Cc: Marek Vasut marex@denx.de; Ley Foon Tan lftan.linux@gmail.com; See, Chin Liang chin.liang.see@intel.com; Nguyen, Dinh dinh.nguyen@intel.com; Tan, Ley Foon ley.foon.tan@intel.com Subject: [PATCH v2 3/3] net: designware: Add reset ctrl to driver

Add code to reset all reset signals as in Ethernet DT node. A reset property is an optional feature, so only print out a warning and do not fail if a reset property is not present.

If a reset property is discovered, then use it to deassert, thus bringing the IP out of reset.

Signed-off-by: Ley Foon Tan ley.foon.tan@intel.com

drivers/net/designware.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/drivers/net/designware.c b/drivers/net/designware.c index 765e356..03ef1eb 100644 --- a/drivers/net/designware.c +++ b/drivers/net/designware.c @@ -16,6 +16,7 @@ #include <miiphy.h> #include <malloc.h> #include <pci.h> +#include <reset.h> #include <linux/compiler.h> #include <linux/err.h> #include <linux/kernel.h> @@ -711,6 +712,16 @@ int designware_eth_probe(struct udevice *dev) } #endif

+#ifdef CONFIG_DM_RESET

You don't need the above wrapper. It's already checked in reset.h

• struct reset_ctl_bulk reset_bulk;
• ret = reset_get_bulk(dev, &reset_bulk);
• if (ret)

• dev_warn(dev, "Can't get reset: %d\n", ret);
  

• else

• reset_deassert_bulk(&reset_bulk);
  

+#endif

#ifdef CONFIG_DM_PCI /* * If we are on PCI bus, either directly attached to a PCI root port, -- 1.7.1