[U-Boot] [PATCH v2 1/3] x86: Convert minnowmax to use CONFIG_DM_NET
Move to driver model for networking on minnowmax.
Signed-off-by: Simon Glass sjg@chromium.org ---
Changes in v2: None
board/intel/minnowmax/minnowmax.c | 6 ------ configs/minnowmax_defconfig | 1 + 2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/board/intel/minnowmax/minnowmax.c b/board/intel/minnowmax/minnowmax.c index c4f2c33..44e5bf4 100644 --- a/board/intel/minnowmax/minnowmax.c +++ b/board/intel/minnowmax/minnowmax.c @@ -6,7 +6,6 @@
#include <common.h> #include <asm/gpio.h> -#include <netdev.h>
int arch_early_init_r(void) { @@ -20,8 +19,3 @@ void setup_pch_gpios(u16 gpiobase, const struct pch_gpio_map *gpio) { return; } - -int board_eth_init(bd_t *bis) -{ - return pci_eth_init(bis); -} diff --git a/configs/minnowmax_defconfig b/configs/minnowmax_defconfig index e98f5eb..6ba22d6 100644 --- a/configs/minnowmax_defconfig +++ b/configs/minnowmax_defconfig @@ -24,3 +24,4 @@ CONFIG_FRAMEBUFFER_VESA_MODE_11A=y CONFIG_DM_RTC=y CONFIG_USE_PRIVATE_LIBGCC=y CONFIG_SYS_VSNPRINTF=y +CONFIG_DM_ETH=y
Move to driver model for USB on minnowmax.
Signed-off-by: Simon Glass sjg@chromium.org ---
Changes in v2: None
configs/minnowmax_defconfig | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/configs/minnowmax_defconfig b/configs/minnowmax_defconfig index 6ba22d6..4c13968 100644 --- a/configs/minnowmax_defconfig +++ b/configs/minnowmax_defconfig @@ -25,3 +25,5 @@ CONFIG_DM_RTC=y CONFIG_USE_PRIVATE_LIBGCC=y CONFIG_SYS_VSNPRINTF=y CONFIG_DM_ETH=y +CONFIG_DM_USB=y +CONFIG_USB=y
Hi Simon,
On Mon, Aug 3, 2015 at 8:15 AM, Simon Glass sjg@chromium.org wrote:
Move to driver model for USB on minnowmax.
Signed-off-by: Simon Glass sjg@chromium.org
Changes in v2: None
configs/minnowmax_defconfig | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/configs/minnowmax_defconfig b/configs/minnowmax_defconfig index 6ba22d6..4c13968 100644 --- a/configs/minnowmax_defconfig +++ b/configs/minnowmax_defconfig @@ -25,3 +25,5 @@ CONFIG_DM_RTC=y CONFIG_USE_PRIVATE_LIBGCC=y CONFIG_SYS_VSNPRINTF=y CONFIG_DM_ETH=y +CONFIG_DM_USB=y
+CONFIG_USB=y
Can we reorder this with savedefconfig?
Regards, Bin
When trying to figure out where an exception has occured, the relocated address is not a lot of help. Its value depends on various factors. Show the un-relocated IP as well. This can be looked up in System.map directly.
Signed-off-by: Simon Glass sjg@chromium.org ---
Changes in v2: - Tweak the dump_regs() output to say 'Original EIP'
arch/x86/cpu/interrupts.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/arch/x86/cpu/interrupts.c b/arch/x86/cpu/interrupts.c index 3a9c2d4..4c79cb3 100644 --- a/arch/x86/cpu/interrupts.c +++ b/arch/x86/cpu/interrupts.c @@ -103,6 +103,8 @@ static void dump_regs(struct irq_regs *regs)
printf("EIP: %04x:[<%08lx>] EFLAGS: %08lx\n", (u16)cs, eip, eflags); + if (gd->flags & GD_FLG_RELOC) + printf("Original EIP :[<%08lx>]\n", regs->eip - gd->reloc_off);
printf("EAX: %08lx EBX: %08lx ECX: %08lx EDX: %08lx\n", regs->eax, regs->ebx, regs->ecx, regs->edx);
On Sun, Aug 02, 2015 at 06:15:43PM -0600, Simon Glass wrote:
When trying to figure out where an exception has occured, the relocated address is not a lot of help. Its value depends on various factors. Show the un-relocated IP as well. This can be looked up in System.map directly.
Signed-off-by: Simon Glass sjg@chromium.org
I see ARM has something similar, and yes, this is helpful.
Reviewed-by: Tom Rini trini@konsulko.com
Hi Simon,
On Mon, Aug 3, 2015 at 8:15 AM, Simon Glass sjg@chromium.org wrote:
When trying to figure out where an exception has occured, the relocated address is not a lot of help. Its value depends on various factors. Show the un-relocated IP as well. This can be looked up in System.map directly.
Signed-off-by: Simon Glass sjg@chromium.org
Changes in v2:
- Tweak the dump_regs() output to say 'Original EIP'
arch/x86/cpu/interrupts.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/arch/x86/cpu/interrupts.c b/arch/x86/cpu/interrupts.c index 3a9c2d4..4c79cb3 100644 --- a/arch/x86/cpu/interrupts.c +++ b/arch/x86/cpu/interrupts.c @@ -103,6 +103,8 @@ static void dump_regs(struct irq_regs *regs)
printf("EIP: %04x:[<%08lx>] EFLAGS: %08lx\n", (u16)cs, eip, eflags);
if (gd->flags & GD_FLG_RELOC)printf("Original EIP :[<%08lx>]\n", regs->eip - gd->reloc_off);
This should not be 'regs->eip'. It should be just 'eip'.
printf("EAX: %08lx EBX: %08lx ECX: %08lx EDX: %08lx\n", regs->eax, regs->ebx, regs->ecx, regs->edx);--
Regards, Bin
Hi Simon,
On Mon, Aug 3, 2015 at 8:15 AM, Simon Glass sjg@chromium.org wrote:
Move to driver model for networking on minnowmax.
Signed-off-by: Simon Glass sjg@chromium.org
Changes in v2: None
board/intel/minnowmax/minnowmax.c | 6 ------ configs/minnowmax_defconfig | 1 + 2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/board/intel/minnowmax/minnowmax.c b/board/intel/minnowmax/minnowmax.c index c4f2c33..44e5bf4 100644 --- a/board/intel/minnowmax/minnowmax.c +++ b/board/intel/minnowmax/minnowmax.c @@ -6,7 +6,6 @@
#include <common.h> #include <asm/gpio.h> -#include <netdev.h>
int arch_early_init_r(void) { @@ -20,8 +19,3 @@ void setup_pch_gpios(u16 gpiobase, const struct pch_gpio_map *gpio) { return; }
-int board_eth_init(bd_t *bis) -{
return pci_eth_init(bis);-} diff --git a/configs/minnowmax_defconfig b/configs/minnowmax_defconfig index e98f5eb..6ba22d6 100644 --- a/configs/minnowmax_defconfig +++ b/configs/minnowmax_defconfig @@ -24,3 +24,4 @@ CONFIG_FRAMEBUFFER_VESA_MODE_11A=y CONFIG_DM_RTC=y CONFIG_USE_PRIVATE_LIBGCC=y CONFIG_SYS_VSNPRINTF=y
+CONFIG_DM_ETH=y
Can we reorder this with savedefconfig?
Regards, Bin
participants (3)
-
Bin Meng -
Simon Glass -
Tom Rini