Hi Stephan,

At Wed, 7 Apr 2004 09:09:05 +0200, Stephan Linz wrote:

Am Dienstag, 6. April 2004 21:40 schrieb Yasushi SHOJI:

...

Here is a patch against the current CVS for microblaze port of u-boot. I does nothing but boot itself, but this can be a start.

Suggestions, thoughts, and comments are welcome, of course.

[...]

Looks nice - two hints/annotations:

1.) You should avoid the serial_init() & main_loop() calls inside your board_init() function. I think it's an unclean U-Boot coding style. The right place would be in lib_microblaze/board.c functions board_init_[rf]() or board_init() for targets without Flash/RAM abstraction (like Nios). Why do you do so?

That's my mistake. Thank you for pointing out.

2.) As far as I can remember the Microblaze CPU is the Soft CPU by Xilinx like Nios by Altera. So the core will be very very flexible and have to be configurable. Have a look at the differen Nios targets and let you inspire to map your specific CPU configuration into the U-Boot configuration managment.

I've had noticed that NIOS support is there but I'm still tring to grasp what is needed and how it works.

I'll dig into the list archive and read some more documents.

# pointers are always welcome ;)

anyway, here is the incremental patch to move board_init() to lib_microblaze/board.c.

best regards, -- yashi

Hi Wolfgang,

please dump this whole thing if you haven't applied. I'll resubmit revised patch soon.

thanks, -- yashi

At Sat, 26 Jun 2004 23:27:42 +0900, yashi wrote:

Hi Wolfgang,

# sorry for the very late reply

At Sun, 18 Apr 2004 23:06:20 +0200, Wolfgang Denk wrote:

...

Dear Yashi,

in message 20040406194020.B1B153E624@dns1.atmark-techno.com you wrote:

...

Here is a patch against the current CVS for microblaze port of u-boot. I does nothing but boot itself, but this can be a start.

Added, thanks a lot!!

...

Suggestions, thoughts, and comments are welcome, of course.

I omitted the linux/linkage.h header file as I think this is not necessary - please check, though.

yup, you are right.

...

Also, please provide an additional patch to add yourself to the CREDITS and MAINTAINERS files.

attached.

At Sun, 18 Apr 2004 23:25:43 +0200, Wolfgang Denk wrote:

...

In message 20040407111919.6F2503E624@dns1.atmark-techno.com you wrote:

...

anyway, here is the incremental patch to move board_init() to lib_microblaze/board.c.

Thanks, appied.

Please don't forget to provide a CHANGELOG entry for your patches.

attached.

Also I have modified to include MicroBlaze in README. The reason why it's a big change is that the string "lib_microblaze" is too long to fit old indentation. no contents changed.

best regards,

        yashi