[PATCH] arm: dts: imx8mq-pinfunc: add a define for the SION bit
SION (Software Input On Field) - force the select mode input path
Signed-off-by: Angus Ainslie angus@akkea.ca --- arch/arm/dts/imx8mq-pinfunc.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm/dts/imx8mq-pinfunc.h b/arch/arm/dts/imx8mq-pinfunc.h index b94b02080a..b51e4faea5 100644 --- a/arch/arm/dts/imx8mq-pinfunc.h +++ b/arch/arm/dts/imx8mq-pinfunc.h @@ -7,6 +7,7 @@ #ifndef __DTS_IMX8MQ_PINFUNC_H #define __DTS_IMX8MQ_PINFUNC_H
+#define IMX_PAD_SION 0x40000000 /* * The pin function ID is a tuple of * <mux_reg conf_reg input_reg mux_mode input_val>
Hi Angus,
On Fri, Jan 28, 2022 at 1:21 PM Angus Ainslie angus@akkea.ca wrote:
SION (Software Input On Field) - force the select mode input path
Signed-off-by: Angus Ainslie angus@akkea.ca
arch/arm/dts/imx8mq-pinfunc.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm/dts/imx8mq-pinfunc.h b/arch/arm/dts/imx8mq-pinfunc.h index b94b02080a..b51e4faea5 100644 --- a/arch/arm/dts/imx8mq-pinfunc.h +++ b/arch/arm/dts/imx8mq-pinfunc.h @@ -7,6 +7,7 @@ #ifndef __DTS_IMX8MQ_PINFUNC_H #define __DTS_IMX8MQ_PINFUNC_H
+#define IMX_PAD_SION 0x40000000
We want to keep this file in sync with Linux.
If you need to pass IMX_PAD_SION in your board file, please use a different header file.
Also, can't you just set the sion bit via devicetree? The last time we discussed this issue, there seemed to be a DT problem.
Please let us know.
Hi Fabio,
On 2022-01-29 10:58, Fabio Estevam wrote:
Hi Angus,
On Fri, Jan 28, 2022 at 1:21 PM Angus Ainslie angus@akkea.ca wrote:
SION (Software Input On Field) - force the select mode input path
Signed-off-by: Angus Ainslie angus@akkea.ca
arch/arm/dts/imx8mq-pinfunc.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm/dts/imx8mq-pinfunc.h b/arch/arm/dts/imx8mq-pinfunc.h index b94b02080a..b51e4faea5 100644 --- a/arch/arm/dts/imx8mq-pinfunc.h +++ b/arch/arm/dts/imx8mq-pinfunc.h @@ -7,6 +7,7 @@ #ifndef __DTS_IMX8MQ_PINFUNC_H #define __DTS_IMX8MQ_PINFUNC_H
+#define IMX_PAD_SION 0x40000000
We want to keep this file in sync with Linux.
If you need to pass IMX_PAD_SION in your board file, please use a different header file.
I added this because I wanted to use it in the SPL. I can put it in the header file for my board but I think it would be better in an imx8m header file. If not the pinfunc header is there another imx8m header you could suggest ?
Also, can't you just set the sion bit via devicetree? The last time we discussed this issue, there seemed to be a DT problem.
I can set the sion bit via the DT but I'm not using the DT n the SPL so it won't help much.
Thanks Angus
Please let us know.
Hi Angus,
On Sun, Jan 30, 2022 at 10:10 AM Angus Ainslie angus@akkea.ca wrote:
I added this because I wanted to use it in the SPL. I can put it in the header file for my board but I think it would be better in an imx8m header file. If not the pinfunc header is there another imx8m header you could suggest ?
What about arch/arm/include/asm/mach-imx/sys_proto.h ?
I can set the sion bit via the DT but I'm not using the DT n the SPL so it won't help much.
Ok, understood.
On 2022-01-30 05:12, Fabio Estevam wrote:
Hi Angus,
On Sun, Jan 30, 2022 at 10:10 AM Angus Ainslie angus@akkea.ca wrote:
I added this because I wanted to use it in the SPL. I can put it in the header file for my board but I think it would be better in an imx8m header file. If not the pinfunc header is there another imx8m header you could suggest ?
What about arch/arm/include/asm/mach-imx/sys_proto.h ?
So it turns out it's already defined here
drivers/pinctrl/nxp/pinctrl-imx.h
Could that definition be moved here ?
arch/arm/include/asm/mach-imx/iomux-v3.h
On Tue, Feb 1, 2022 at 4:05 PM Angus Ainslie angus@akkea.ca wrote:
So it turns out it's already defined here
drivers/pinctrl/nxp/pinctrl-imx.h
Could that definition be moved here ?
arch/arm/include/asm/mach-imx/iomux-v3.h
Yes, that would work too.
participants (2)
-
Angus Ainslie -
Fabio Estevam