[PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX

The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0. Due to a change in gpiolib-of.c, setting flags to GPIO_ACTIVE_LOW and using output-low DT property leads to the GPIO being set high instead.
Signed-off-by: Marek Vasut marex@denx.de Cc: Patrice Chotard patrice.chotard@st.com Cc: Patrick Delaunay patrick.delaunay@st.com --- arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts b/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts index 7f5cff49b70..59d13713d88 100644 --- a/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts +++ b/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts @@ -37,7 +37,7 @@ */ usb-port-power { gpio-hog; - gpios = <13 GPIO_ACTIVE_LOW>; + gpios = <13 0>; output-low; line-name = "usb-port-power"; };

The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0. Since GPIO_ACTIVE_HIGH is defined as 0, this change only increases the correctness of the DT.
Signed-off-by: Marek Vasut marex@denx.de Cc: Patrice Chotard patrice.chotard@st.com Cc: Patrick Delaunay patrick.delaunay@st.com --- arch/arm/dts/stm32mp15xx-dhcom-drc02.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts b/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts index e8508aa4d5a..4948ccd4014 100644 --- a/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts +++ b/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts @@ -37,7 +37,7 @@ */ usb-hub { gpio-hog; - gpios = <8 GPIO_ACTIVE_HIGH>; + gpios = <8 0>; output-high; line-name = "rs485-rx-en"; }; @@ -65,7 +65,7 @@ */ usb-hub { gpio-hog; - gpios = <2 GPIO_ACTIVE_HIGH>; + gpios = <2 0>; output-high; line-name = "usb-hub-reset"; };

Hi Marek
On 1/2/21 5:44 PM, Marek Vasut wrote:
The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0. Since GPIO_ACTIVE_HIGH is defined as 0, this change only increases the correctness of the DT.
Signed-off-by: Marek Vasut marex@denx.de Cc: Patrice Chotard patrice.chotard@st.com Cc: Patrick Delaunay patrick.delaunay@st.com
arch/arm/dts/stm32mp15xx-dhcom-drc02.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts b/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts index e8508aa4d5a..4948ccd4014 100644 --- a/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts +++ b/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts @@ -37,7 +37,7 @@ */ usb-hub { gpio-hog;
gpios = <8 GPIO_ACTIVE_HIGH>;
output-high; line-name = "rs485-rx-en"; };gpios = <8 0>;
@@ -65,7 +65,7 @@ */ usb-hub { gpio-hog;
gpios = <2 GPIO_ACTIVE_HIGH>;
output-high; line-name = "usb-hub-reset"; };gpios = <2 0>;
Reviewed-by: Patrice Chotard patrice.chotard@st.com
Thanks

On 1/2/21 5:44 PM, Marek Vasut wrote:
The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0. Since GPIO_ACTIVE_HIGH is defined as 0, this change only increases the correctness of the DT.
Signed-off-by: Marek Vasut marex@denx.de Cc: Patrice Chotard patrice.chotard@st.com Cc: Patrick Delaunay patrick.delaunay@st.com
arch/arm/dts/stm32mp15xx-dhcom-drc02.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts b/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts index e8508aa4d5a..4948ccd4014 100644 --- a/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts +++ b/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts @@ -37,7 +37,7 @@ */ usb-hub { gpio-hog;
gpios = <8 GPIO_ACTIVE_HIGH>;
output-high; line-name = "rs485-rx-en"; };gpios = <8 0>;
@@ -65,7 +65,7 @@ */ usb-hub { gpio-hog;
gpios = <2 GPIO_ACTIVE_HIGH>;
output-high; line-name = "usb-hub-reset"; };gpios = <2 0>;
Reviewed-by: Patrick Delaunay patrick.delaunay@foss.st.com
Thanks
Patrick

On 1/2/21 5:44 PM, Marek Vasut wrote:
The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0. Due to a change in gpiolib-of.c, setting flags to GPIO_ACTIVE_LOW and using output-low DT property leads to the GPIO being set high instead.
+CC Tom
These two should be applied to 2021.01 as well, can you pick them ? Thanks

Hi Marek
On 1/2/21 5:44 PM, Marek Vasut wrote:
The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0. Due to a change in gpiolib-of.c, setting flags to GPIO_ACTIVE_LOW and using output-low DT property leads to the GPIO being set high instead.
Signed-off-by: Marek Vasut marex@denx.de Cc: Patrice Chotard patrice.chotard@st.com Cc: Patrick Delaunay patrick.delaunay@st.com
arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts b/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts index 7f5cff49b70..59d13713d88 100644 --- a/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts +++ b/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts @@ -37,7 +37,7 @@ */ usb-port-power { gpio-hog;
gpios = <13 GPIO_ACTIVE_LOW>;
output-low; line-name = "usb-port-power"; };gpios = <13 0>;
Reviewed-by: Patrice Chotard patrice.chotard@st.com
Thanks

Hi Marek,
On 1/2/21 5:44 PM, Marek Vasut wrote:
The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0. Due to a change in gpiolib-of.c, setting flags to GPIO_ACTIVE_LOW and using output-low DT property leads to the GPIO being set high instead.
Signed-off-by: Marek Vasut marex@denx.de Cc: Patrice Chotard patrice.chotard@st.com Cc: Patrick Delaunay patrick.delaunay@st.com
arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts b/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts index 7f5cff49b70..59d13713d88 100644 --- a/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts +++ b/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts @@ -37,7 +37,7 @@ */ usb-port-power { gpio-hog;
gpios = <13 GPIO_ACTIVE_LOW>;
output-low; line-name = "usb-port-power"; };gpios = <13 0>;
Reviewed-by: Patrick Delaunay patrick.delaunay@foss.st.com
Thanks
Patrick
participants (3)
-
Marek Vasut
-
Patrice CHOTARD
-
Patrick DELAUNAY