[U-Boot] [PATCH] dfu: dfu_sf: Use the erase sector size for erase operations
From: Fabio Estevam fabio.estevam@freescale.com
SPI NOR flashes need to erase the entire sector size and we cannot pass any arbitrary length for the erase operation.
To illustrate the problem:
Copying data from PC to DFU device Download [=========================] 100% 478208 bytes Download done. state(7) = dfuMANIFEST, status(0) = No error condition is present state(10) = dfuERROR, status(14) = Something went wrong, but the device does not know what it was Done!
In this case, the binary has 478208 bytes and the M25P32 SPI NOR has an erase sector of 64kB.
478208 = 7 entire sectors of 64kiB + 19456 bytes.
Erasing the first seven 64 kB sectors works fine, but when trying to erase the remainding 19456 causes problem and the board hangs.
Fix the issue by always erasing with the erase sector size.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- drivers/dfu/dfu_sf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/dfu/dfu_sf.c b/drivers/dfu/dfu_sf.c index c3d3c3b..448d95d 100644 --- a/drivers/dfu/dfu_sf.c +++ b/drivers/dfu/dfu_sf.c @@ -28,7 +28,8 @@ static int dfu_write_medium_sf(struct dfu_entity *dfu, { int ret;
- ret = spi_flash_erase(dfu->data.sf.dev, offset, *len); + ret = spi_flash_erase(dfu->data.sf.dev, offset, + dfu->data.sf.dev->sector_size); if (ret) return ret;
Hi Fabio,
From: Fabio Estevam fabio.estevam@freescale.com
SPI NOR flashes need to erase the entire sector size and we cannot pass any arbitrary length for the erase operation.
To illustrate the problem:
Copying data from PC to DFU device Download [=========================] 100% 478208 bytes Download done. state(7) = dfuMANIFEST, status(0) = No error condition is present state(10) = dfuERROR, status(14) = Something went wrong, but the device does not know what it was Done!
In this case, the binary has 478208 bytes and the M25P32 SPI NOR has an erase sector of 64kB.
478208 = 7 entire sectors of 64kiB + 19456 bytes.
Erasing the first seven 64 kB sectors works fine, but when trying to erase the remainding 19456 causes problem and the board hangs.
Fix the issue by always erasing with the erase sector size.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
drivers/dfu/dfu_sf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/dfu/dfu_sf.c b/drivers/dfu/dfu_sf.c index c3d3c3b..448d95d 100644 --- a/drivers/dfu/dfu_sf.c +++ b/drivers/dfu/dfu_sf.c @@ -28,7 +28,8 @@ static int dfu_write_medium_sf(struct dfu_entity *dfu, { int ret;
- ret = spi_flash_erase(dfu->data.sf.dev, offset, *len);
- ret = spi_flash_erase(dfu->data.sf.dev, offset,
dfu->data.sf.dev->sector_size);
Acked-by: Lukasz Majewski l.majewski@samsung.com
Applied to u-boot-dfu tree.
Thanks for your work.
I'm looking forward for more patches :-)
Hi Lukasz,
On Tue, Sep 22, 2015 at 4:46 AM, Lukasz Majewski l.majewski@samsung.com wrote:
Hi Fabio,
From: Fabio Estevam fabio.estevam@freescale.com
SPI NOR flashes need to erase the entire sector size and we cannot pass any arbitrary length for the erase operation.
To illustrate the problem:
Copying data from PC to DFU device Download [=========================] 100% 478208 bytes Download done. state(7) = dfuMANIFEST, status(0) = No error condition is present state(10) = dfuERROR, status(14) = Something went wrong, but the device does not know what it was Done!
In this case, the binary has 478208 bytes and the M25P32 SPI NOR has an erase sector of 64kB.
478208 = 7 entire sectors of 64kiB + 19456 bytes.
Erasing the first seven 64 kB sectors works fine, but when trying to erase the remainding 19456 causes problem and the board hangs.
Fix the issue by always erasing with the erase sector size.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Acked-by: Lukasz Majewski l.majewski@samsung.com
Applied to u-boot-dfu tree.
Thanks for your work.
I'm looking forward for more patches :-)
Any chance of getting this one applied for 2015.10?
Hi Fabio,
Hi Lukasz,
On Tue, Sep 22, 2015 at 4:46 AM, Lukasz Majewski l.majewski@samsung.com wrote:
Hi Fabio,
From: Fabio Estevam fabio.estevam@freescale.com
SPI NOR flashes need to erase the entire sector size and we cannot pass any arbitrary length for the erase operation.
To illustrate the problem:
Copying data from PC to DFU device Download [=========================] 100% 478208 bytes Download done. state(7) = dfuMANIFEST, status(0) = No error condition is present state(10) = dfuERROR, status(14) = Something went wrong, but the device does not know what it was Done!
In this case, the binary has 478208 bytes and the M25P32 SPI NOR has an erase sector of 64kB.
478208 = 7 entire sectors of 64kiB + 19456 bytes.
Erasing the first seven 64 kB sectors works fine, but when trying to erase the remainding 19456 causes problem and the board hangs.
Fix the issue by always erasing with the erase sector size.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Acked-by: Lukasz Majewski l.majewski@samsung.com
Applied to u-boot-dfu tree.
Thanks for your work.
I'm looking forward for more patches :-)
Any chance of getting this one applied for 2015.10?
Probably not :-( since we have now -rc5.
I plan to send pull request in the next merge window.
My apologies, since I was busy with ELCE2015 preparation, so I've forgotten to send early PR to Marek.
On Mon, Oct 19, 2015 at 6:07 AM, Lukasz Majewski l.majewski@samsung.com wrote:
On Tue, Sep 22, 2015 at 4:46 AM, Lukasz Majewski l.majewski@samsung.com wrote:
From: Fabio Estevam fabio.estevam@freescale.com
SPI NOR flashes need to erase the entire sector size and we cannot pass any arbitrary length for the erase operation.
To illustrate the problem:
Copying data from PC to DFU device Download [=========================] 100% 478208 bytes Download done. state(7) = dfuMANIFEST, status(0) = No error condition is present state(10) = dfuERROR, status(14) = Something went wrong, but the device does not know what it was Done!
In this case, the binary has 478208 bytes and the M25P32 SPI NOR has an erase sector of 64kB.
478208 = 7 entire sectors of 64kiB + 19456 bytes.
Erasing the first seven 64 kB sectors works fine, but when trying to erase the remainding 19456 causes problem and the board hangs.
Fix the issue by always erasing with the erase sector size.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Acked-by: Lukasz Majewski l.majewski@samsung.com
Applied to u-boot-dfu tree.
Thanks for your work.
I'm looking forward for more patches :-)
Any chance of getting this one applied for 2015.10?
Probably not :-( since we have now -rc5.
I plan to send pull request in the next merge window.
My apologies, since I was busy with ELCE2015 preparation, so I've forgotten to send early PR to Marek.
This has been acked in September and it is a very trivial change, why not include it?
Hi Otavio,
On Mon, Oct 19, 2015 at 6:07 AM, Lukasz Majewski l.majewski@samsung.com wrote:
On Tue, Sep 22, 2015 at 4:46 AM, Lukasz Majewski l.majewski@samsung.com wrote:
From: Fabio Estevam fabio.estevam@freescale.com
SPI NOR flashes need to erase the entire sector size and we cannot pass any arbitrary length for the erase operation.
To illustrate the problem:
Copying data from PC to DFU device Download [=========================] 100% 478208 bytes Download done. state(7) = dfuMANIFEST, status(0) = No error condition is present state(10) = dfuERROR, status(14) = Something went wrong, but the device does not know what it was Done!
In this case, the binary has 478208 bytes and the M25P32 SPI NOR has an erase sector of 64kB.
478208 = 7 entire sectors of 64kiB + 19456 bytes.
Erasing the first seven 64 kB sectors works fine, but when trying to erase the remainding 19456 causes problem and the board hangs.
Fix the issue by always erasing with the erase sector size.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Acked-by: Lukasz Majewski l.majewski@samsung.com
Applied to u-boot-dfu tree.
Thanks for your work.
I'm looking forward for more patches :-)
Any chance of getting this one applied for 2015.10?
Probably not :-( since we have now -rc5.
I plan to send pull request in the next merge window.
My apologies, since I was busy with ELCE2015 preparation, so I've forgotten to send early PR to Marek.
This has been acked in September and it is a very trivial change, why not include it?
I'm discussing it now with Tom. I hope that he would take those two patches.
Hi Tom,
On Mon, Oct 19, 2015 at 6:07 AM, Lukasz Majewski l.majewski@samsung.com wrote:
On Tue, Sep 22, 2015 at 4:46 AM, Lukasz Majewski l.majewski@samsung.com wrote:
From: Fabio Estevam fabio.estevam@freescale.com
SPI NOR flashes need to erase the entire sector size and we cannot pass any arbitrary length for the erase operation.
To illustrate the problem:
Copying data from PC to DFU device Download [=========================] 100% 478208 bytes Download done. state(7) = dfuMANIFEST, status(0) = No error condition is present state(10) = dfuERROR, status(14) = Something went wrong, but the device does not know what it was Done!
In this case, the binary has 478208 bytes and the M25P32 SPI NOR has an erase sector of 64kB.
478208 = 7 entire sectors of 64kiB + 19456 bytes.
Erasing the first seven 64 kB sectors works fine, but when trying to erase the remainding 19456 causes problem and the board hangs.
Fix the issue by always erasing with the erase sector size.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Acked-by: Lukasz Majewski l.majewski@samsung.com
Applied to u-boot-dfu tree.
Thanks for your work.
I'm looking forward for more patches :-)
Any chance of getting this one applied for 2015.10?
Probably not :-( since we have now -rc5.
I plan to send pull request in the next merge window.
My apologies, since I was busy with ELCE2015 preparation, so I've forgotten to send early PR to Marek.
This has been acked in September and it is a very trivial change, why not include it?
Two patches to be applied as fixes for dfu subsystem.
https://patchwork.ozlabs.org/patch/520827/ https://patchwork.ozlabs.org/patch/521575/
On Tue, Sep 22, 2015 at 12:55:00AM -0300, Fabio Estevam wrote:
From: Fabio Estevam fabio.estevam@freescale.com
SPI NOR flashes need to erase the entire sector size and we cannot pass any arbitrary length for the erase operation.
To illustrate the problem:
Copying data from PC to DFU device Download [=========================] 100% 478208 bytes Download done. state(7) = dfuMANIFEST, status(0) = No error condition is present state(10) = dfuERROR, status(14) = Something went wrong, but the device does not know what it was Done!
In this case, the binary has 478208 bytes and the M25P32 SPI NOR has an erase sector of 64kB.
478208 = 7 entire sectors of 64kiB + 19456 bytes.
Erasing the first seven 64 kB sectors works fine, but when trying to erase the remainding 19456 causes problem and the board hangs.
Fix the issue by always erasing with the erase sector size.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com Acked-by: Lukasz Majewski l.majewski@samsung.com
Applied to u-boot/master, thanks!
participants (4)
-
Fabio Estevam -
Lukasz Majewski -
Otavio Salvador -
Tom Rini