[PATCH 1/1] sandbox: sandbox_serial_pending depends on DM_VIDEO

When building sandbox_defconfig with CONFIG_DM_VIDEO=n a link time error occurs:
in function `sandbox_serial_pending': drivers/serial/sandbox.c:101: undefined reference to `video_sync_all'
video_sync_all() is only defined if we have CONFIG_DM_VIDEO=y.
Calling this function in a serial driver looks quite hackish but at least let's add the missing build constraint.
Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com --- drivers/serial/sandbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/serial/sandbox.c b/drivers/serial/sandbox.c index dbbcea5bb4..0b1756f5c0 100644 --- a/drivers/serial/sandbox.c +++ b/drivers/serial/sandbox.c @@ -97,7 +97,7 @@ static int sandbox_serial_pending(struct udevice *dev, bool input) return 0;
os_usleep(100); - if (!IS_ENABLED(CONFIG_SPL_BUILD)) + if (IS_ENABLED(CONFIG_DM_VIDEO) && !IS_ENABLED(CONFIG_SPL_BUILD)) video_sync_all(); avail = membuff_putraw(&priv->buf, 100, false, &data); if (!avail)

On Fri, 21 Jan 2022 at 08:07, Heinrich Schuchardt heinrich.schuchardt@canonical.com wrote:
When building sandbox_defconfig with CONFIG_DM_VIDEO=n a link time error occurs:
in function `sandbox_serial_pending': drivers/serial/sandbox.c:101: undefined reference to `video_sync_all'
video_sync_all() is only defined if we have CONFIG_DM_VIDEO=y.
Calling this function in a serial driver looks quite hackish but at least let's add the missing build constraint.
Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com
drivers/serial/sandbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org

On Fri, 21 Jan 2022 at 08:07, Heinrich Schuchardt heinrich.schuchardt@canonical.com wrote:
When building sandbox_defconfig with CONFIG_DM_VIDEO=n a link time error occurs:
in function `sandbox_serial_pending': drivers/serial/sandbox.c:101: undefined reference to `video_sync_all'
video_sync_all() is only defined if we have CONFIG_DM_VIDEO=y.
Calling this function in a serial driver looks quite hackish but at least let's add the missing build constraint.
Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com
drivers/serial/sandbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot-dm, thanks!
participants (2)
-
Heinrich Schuchardt
-
Simon Glass