[U-Boot] [PATCH v2] OMAP3: Introduce CONFIG option for power code

Some OMAP3 boards need control for external power companion chips. Introduce a CONFIG option for this, to avoid Makefile changes for each board.
Signed-off-by: Dirk Behme dirk.behme@googlemail.com ---
Compile tested with ./MAKEALL ARM_CORTEX_A8, boot tested on OMAP3 based BeagleBoard.
Note: This patch trys to fix the first comment of
http://lists.denx.de/pipermail/u-boot/2009-April/051383.html
Changes in v2: - Mention about which power companion chips we talk here
This version v2 replaces all previous patches
board/omap3/common/Makefile | 5 +---- doc/README.omap3 | 11 +++++++++++ include/configs/omap3_beagle.h | 1 + include/configs/omap3_overo.h | 1 + include/configs/omap3_pandora.h | 1 + include/configs/omap3_zoom1.h | 1 + 6 files changed, 16 insertions(+), 4 deletions(-)
Index: u-boot-main/doc/README.omap3 =================================================================== --- u-boot-main.orig/doc/README.omap3 +++ u-boot-main/doc/README.omap3 @@ -77,6 +77,17 @@ For all other commands see
help
+Custom configs +============== + +CONFIG_OMAP3_POWER + +Some OMAP3 boards use external power companion chips to be configured. Enable +this CONFIG option in your board specific configuration file if your board +uses such a companion chip. E.g. TWL4030 or compatible TPS65950. + +This enables compilation of board/omap3/common/power.c. + Acknowledgements ================
Index: u-boot-main/board/omap3/common/Makefile =================================================================== --- u-boot-main.orig/board/omap3/common/Makefile +++ u-boot-main/board/omap3/common/Makefile @@ -29,10 +29,7 @@ endif
LIB = $(obj)lib$(VENDOR).a
-COBJS-$(CONFIG_OMAP3_BEAGLE) += power.o -COBJS-$(CONFIG_OMAP3_OVERO) += power.o -COBJS-$(CONFIG_OMAP3_PANDORA) += power.o -COBJS-$(CONFIG_OMAP3_ZOOM1) += power.o +COBJS-$(CONFIG_OMAP3_POWER) += power.o
COBJS := $(COBJS-y) SRCS := $(COBJS:.o=.c) Index: u-boot-main/include/configs/omap3_beagle.h =================================================================== --- u-boot-main.orig/include/configs/omap3_beagle.h +++ u-boot-main/include/configs/omap3_beagle.h @@ -37,6 +37,7 @@ #define CONFIG_OMAP34XX 1 /* which is a 34XX */ #define CONFIG_OMAP3430 1 /* which is in a 3430 */ #define CONFIG_OMAP3_BEAGLE 1 /* working with BEAGLE */ +#define CONFIG_OMAP3_POWER 1 /* use power code, see README.omap3 */
#include <asm/arch/cpu.h> /* get chip and board defs */ #include <asm/arch/omap3.h> Index: u-boot-main/include/configs/omap3_overo.h =================================================================== --- u-boot-main.orig/include/configs/omap3_overo.h +++ u-boot-main/include/configs/omap3_overo.h @@ -29,6 +29,7 @@ #define CONFIG_OMAP34XX 1 /* which is a 34XX */ #define CONFIG_OMAP3430 1 /* which is in a 3430 */ #define CONFIG_OMAP3_OVERO 1 /* working with overo */ +#define CONFIG_OMAP3_POWER 1 /* use power code, see README.omap3 */
#include <asm/arch/cpu.h> /* get chip and board defs */ #include <asm/arch/omap3.h> Index: u-boot-main/include/configs/omap3_pandora.h =================================================================== --- u-boot-main.orig/include/configs/omap3_pandora.h +++ u-boot-main/include/configs/omap3_pandora.h @@ -32,6 +32,7 @@ #define CONFIG_OMAP34XX 1 /* which is a 34XX */ #define CONFIG_OMAP3430 1 /* which is in a 3430 */ #define CONFIG_OMAP3_PANDORA 1 /* working with pandora */ +#define CONFIG_OMAP3_POWER 1 /* use power code, see README.omap3 */
#include <asm/arch/cpu.h> /* get chip and board defs */ #include <asm/arch/omap3.h> Index: u-boot-main/include/configs/omap3_zoom1.h =================================================================== --- u-boot-main.orig/include/configs/omap3_zoom1.h +++ u-boot-main/include/configs/omap3_zoom1.h @@ -38,6 +38,7 @@ #define CONFIG_OMAP34XX 1 /* which is a 34XX */ #define CONFIG_OMAP3430 1 /* which is in a 3430 */ #define CONFIG_OMAP3_ZOOM1 1 /* working with Zoom MDK Rev1 */ +#define CONFIG_OMAP3_POWER 1 /* use power code, see README.omap3 */
#include <asm/arch/cpu.h> /* get chip and board defs */ #include <asm/arch/omap3.h>

On 07:56 Sat 16 May , Dirk Behme wrote:
Some OMAP3 boards need control for external power companion chips. Introduce a CONFIG option for this, to avoid Makefile changes for each board.
Signed-off-by: Dirk Behme dirk.behme@googlemail.com
IIRC the Revc Change it's companion chip is this code still compatible?
Best Regards, J.

Dear Jean-Christophe,
Jean-Christophe PLAGNIOL-VILLARD wrote:
On 07:56 Sat 16 May , Dirk Behme wrote:
Some OMAP3 boards need control for external power companion chips. Introduce a CONFIG option for this, to avoid Makefile changes for each board.
Signed-off-by: Dirk Behme dirk.behme@googlemail.com
IIRC the Revc Change it's companion chip is this code still compatible?
Yes, the code is still compatible. And yes, the companion chip changed. And yes, this is quite confusing ;) Do you still remember what I wrote in one of the other mails "only TI marketing department might understand their chip naming"?
What I understood is that revision A & B BeagleBoards used "OEM" companion chip you will only get in large quantities and manual is NDA. Revision C now uses the "catalogue" device, you will e.g. able to get from DigiKey and manual is publically available. So different chip names, but compatible.
Recent U-Boot mainline is used on rev B and C boards without any difference :)
Best regards
Dirk
participants (2)
-
Dirk Behme
-
Jean-Christophe PLAGNIOL-VILLARD