ID is decimal not hexadecimal that's why passing hex number all the time end's up as 0 that's why check it. Node ID 0 is not valid anyway. Also properly say it in help.

Signed-off-by: Michal Simek michal.simek@amd.com ---

board/xilinx/zynqmp/cmds.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/board/xilinx/zynqmp/cmds.c b/board/xilinx/zynqmp/cmds.c index e20030ecda79..c1224bdf821f 100644 --- a/board/xilinx/zynqmp/cmds.c +++ b/board/xilinx/zynqmp/cmds.c @@ -216,6 +216,10 @@ static int do_zynqmp_pmufw(struct cmd_tbl *cmdtp, int flag, int argc, return zynqmp_pmufw_config_close();

id = dectoul(argv[3], NULL); + if (!id) { + printf("Incorrect ID passed\n"); + return CMD_RET_USAGE; + }

printf("Enable permission for node ID %d\n", id);

@@ -429,7 +433,7 @@ static char zynqmp_help_text[] = " lock(0)/split(1)\n" #endif "zynqmp pmufw address size - load PMU FW configuration object\n" - "zynqmp pmufw node <id> - load PMU FW configuration object\n" + "zynqmp pmufw node <id> - load PMU FW configuration object, <id> in dec\n" "zynqmp pmufw node close - disable config object loading\n" " node: keyword, id: NODE_ID in decimal format\n" "zynqmp rsa srcaddr srclen mod exp rsaop -\n"