[U-Boot] [PATCH] board_r: return 0 from show_model_r

The show_model_r function should return an int but didn't. Return 0 to indicate inevitable success and avoid the following if it is used:
common/board_r.c: In function 'show_model_r': common/board_r.c:531:1: warning: no return statement in function returning non-void [-Wreturn-type] } ^
Cc: Simon Glass sjg@chromium.org Signed-off-by: Paul Burton paul.burton@imgtec.com --- common/board_r.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/common/board_r.c b/common/board_r.c index 8629a65..d1f0aa9 100644 --- a/common/board_r.c +++ b/common/board_r.c @@ -528,6 +528,7 @@ static int show_model_r(void) # else checkboard(); # endif + return 0; } #endif

On 4 April 2014 05:23, Paul Burton paul.burton@imgtec.com wrote:
The show_model_r function should return an int but didn't. Return 0 to indicate inevitable success and avoid the following if it is used:
common/board_r.c: In function 'show_model_r': common/board_r.c:531:1: warning: no return statement in function returning non-void [-Wreturn-type] } ^
Cc: Simon Glass sjg@chromium.org Signed-off-by: Paul Burton paul.burton@imgtec.com
Acked-by: Simon Glass sjg@chromium.org

On Fri, Apr 04, 2014 at 12:23:24PM +0100, Paul Burton wrote:
The show_model_r function should return an int but didn't. Return 0 to indicate inevitable success and avoid the following if it is used:
common/board_r.c: In function 'show_model_r': common/board_r.c:531:1: warning: no return statement in function returning non-void [-Wreturn-type] } ^
Cc: Simon Glass sjg@chromium.org Signed-off-by: Paul Burton paul.burton@imgtec.com Acked-by: Simon Glass sjg@chromium.org
Applied to u-boot/master, thanks!
participants (3)
-
Paul Burton
-
Simon Glass
-
Tom Rini