[U-Boot] [PATCH v2] drivers: usb: xhci-fsl: Change burst beat and outstanding pipelined transfers requests
This is required for better performance, and performs below tuning: 1. Enable burst length set, and define it as 4/8/16. 2. Set burst request limit to 16 requests.
Signed-off-by: Rajesh Bhagat rajesh.bhagat@nxp.com Signed-off-by: Sriram Dash sriram.dash@nxp.com --- Changes in v2: - using clrsetbits_le32 and setbits_le32 instead of writel
drivers/usb/host/xhci-fsl.c | 10 ++++++++++ include/linux/usb/xhci-fsl.h | 3 +++ 2 files changed, 13 insertions(+)
diff --git a/drivers/usb/host/xhci-fsl.c b/drivers/usb/host/xhci-fsl.c index bdcd4f1..0e3e056 100644 --- a/drivers/usb/host/xhci-fsl.c +++ b/drivers/usb/host/xhci-fsl.c @@ -58,6 +58,13 @@ static void fsl_apply_xhci_errata(void) } }
+static void fsl_xhci_set_beat_burst_length(struct dwc3 *dwc3_reg) +{ + clrsetbits_le32(&dwc3_reg->g_sbuscfg0, USB3_ENABLE_BEAT_BURST_MASK, + USB3_ENABLE_BEAT_BURST); + setbits_le32(&dwc3_reg->g_sbuscfg1, USB3_SET_BEAT_BURST_LIMIT); +} + static int fsl_xhci_core_init(struct fsl_xhci *fsl_xhci) { int ret = 0; @@ -74,6 +81,9 @@ static int fsl_xhci_core_init(struct fsl_xhci *fsl_xhci) /* Set GFLADJ_30MHZ as 20h as per XHCI spec default value */ dwc3_set_fladj(fsl_xhci->dwc3_reg, GFLADJ_30MHZ_DEFAULT);
+ /* Change beat burst and outstanding pipelined transfers requests */ + fsl_xhci_set_beat_burst_length(fsl_xhci->dwc3_reg); + return ret; }
diff --git a/include/linux/usb/xhci-fsl.h b/include/linux/usb/xhci-fsl.h index 199f366..1032763 100644 --- a/include/linux/usb/xhci-fsl.h +++ b/include/linux/usb/xhci-fsl.h @@ -20,6 +20,9 @@ #define USB3_PHY_TX_RX_POWERON (USB3_PHY_RX_POWERON | USB3_PHY_TX_POWERON) #define USB3_PWRCTL_CLK_CMD_SHIFT 14 #define USB3_PWRCTL_CLK_FREQ_SHIFT 22 +#define USB3_ENABLE_BEAT_BURST 0xF +#define USB3_ENABLE_BEAT_BURST_MASK 0xFF +#define USB3_SET_BEAT_BURST_LIMIT 0xF00
/* USBOTGSS_WRAPPER definitions */ #define USBOTGSS_WRAPRESET BIT(17)
On 08/22/2016 02:25 PM, Sriram Dash wrote:
This is required for better performance, and performs below tuning:
- Enable burst length set, and define it as 4/8/16.
- Set burst request limit to 16 requests.
Signed-off-by: Rajesh Bhagat rajesh.bhagat@nxp.com Signed-off-by: Sriram Dash sriram.dash@nxp.com
Looks OK to me. York ?
On 08/22/2016 06:54 AM, Marek Vasut wrote:
On 08/22/2016 02:25 PM, Sriram Dash wrote:
This is required for better performance, and performs below tuning:
- Enable burst length set, and define it as 4/8/16.
Isn't it odd to put a date here?
- Set burst request limit to 16 requests.
Signed-off-by: Rajesh Bhagat rajesh.bhagat@nxp.com Signed-off-by: Sriram Dash sriram.dash@nxp.com
Looks OK to me. York ?
Other than that, Reviewed-by: York Sun york.sun@nxp.com
From: york sun On 08/22/2016 06:54 AM, Marek Vasut wrote:
On 08/22/2016 02:25 PM, Sriram Dash wrote:
This is required for better performance, and performs below tuning:
- Enable burst length set, and define it as 4/8/16.
Isn't it odd to put a date here?
Hello York, Here we are enabling the INCR4, INCR 8 and INCR16 burst type for the usb transfers.
- Set burst request limit to 16 requests.
Signed-off-by: Rajesh Bhagat rajesh.bhagat@nxp.com Signed-off-by: Sriram Dash sriram.dash@nxp.com
Looks OK to me. York ?
Other than that, Reviewed-by: York Sun york.sun@nxp.com
On 08/23/2016 09:33 PM, Sriram Dash wrote:
From: york sun On 08/22/2016 06:54 AM, Marek Vasut wrote:
On 08/22/2016 02:25 PM, Sriram Dash wrote:
This is required for better performance, and performs below tuning:
- Enable burst length set, and define it as 4/8/16.
Isn't it odd to put a date here?
Hello York, Here we are enabling the INCR4, INCR 8 and INCR16 burst type for the usb transfers.
It doesn't answer my question. Why do you put a date 4/8/16 there? It doesn't make much sense.
York
On 08/24/2016 06:44 PM, york sun wrote:
On 08/23/2016 09:33 PM, Sriram Dash wrote:
From: york sun On 08/22/2016 06:54 AM, Marek Vasut wrote:
On 08/22/2016 02:25 PM, Sriram Dash wrote:
This is required for better performance, and performs below tuning:
- Enable burst length set, and define it as 4/8/16.
Isn't it odd to put a date here?
Hello York, Here we are enabling the INCR4, INCR 8 and INCR16 burst type for the usb transfers.
It doesn't answer my question. Why do you put a date 4/8/16 there? It doesn't make much sense.
What are you talking about ? Could it be your mailer that does something funny with that string ?
York
Ha! I misunderstood. I read this "Enable burst length set, and define it as 4/8/16" and somehow my brain interpreted it as a date. I must be traveling too much recently. :)
York
-------- Original Message -------- From: Marek Vasut marex@denx.de Sent: Wednesday, August 24, 2016 10:10 AM To: york sun york.sun@nxp.com,Sriram Dash sriram.dash@nxp.com,u-boot@lists.denx.de Subject: Re: [PATCH v2] drivers: usb: xhci-fsl: Change burst beat and outstanding pipelined transfers requests CC: Suresh Gupta suresh.gupta@nxp.com,Rajesh Bhagat rajesh.bhagat@nxp.com
On 08/24/2016 06:44 PM, york sun wrote:
On 08/23/2016 09:33 PM, Sriram Dash wrote:
From: york sun On 08/22/2016 06:54 AM, Marek Vasut wrote:
On 08/22/2016 02:25 PM, Sriram Dash wrote:
This is required for better performance, and performs below tuning:
- Enable burst length set, and define it as 4/8/16.
Isn't it odd to put a date here?
Hello York, Here we are enabling the INCR4, INCR 8 and INCR16 burst type for the usb transfers.
It doesn't answer my question. Why do you put a date 4/8/16 there? It doesn't make much sense.
What are you talking about ? Could it be your mailer that does something funny with that string ?
York
-- Best regards, Marek Vasut
On 08/24/2016 07:41 PM, york sun wrote:
Ha! I misunderstood. I read this "Enable burst length set, and define it as 4/8/16" and somehow my brain interpreted it as a date. I must be traveling too much recently. :)
And now you're even top-posting and sending html mail , yeah , you should take a break :)
Ahyway, are we ok on the patch then ?
York
-------- Original Message -------- From: Marek Vasut marex@denx.de Sent: Wednesday, August 24, 2016 10:10 AM To: york sun york.sun@nxp.com,Sriram Dash sriram.dash@nxp.com,u-boot@lists.denx.de Subject: Re: [PATCH v2] drivers: usb: xhci-fsl: Change burst beat and outstanding pipelined transfers requests CC: Suresh Gupta suresh.gupta@nxp.com,Rajesh Bhagat rajesh.bhagat@nxp.com
On 08/24/2016 06:44 PM, york sun wrote:
On 08/23/2016 09:33 PM, Sriram Dash wrote:
From: york sun On 08/22/2016 06:54 AM, Marek Vasut wrote:
On 08/22/2016 02:25 PM, Sriram Dash wrote:
This is required for better performance, and performs below tuning:
- Enable burst length set, and define it as 4/8/16.
Isn't it odd to put a date here?
Hello York, Here we are enabling the INCR4, INCR 8 and INCR16 burst type for the usb transfers.
It doesn't answer my question. Why do you put a date 4/8/16 there? It doesn't make much sense.
What are you talking about ? Could it be your mailer that does something funny with that string ?
York
-- Best regards, Marek Vasut
On 08/24/2016 07:25 PM, Marek Vasut wrote:
On 08/24/2016 07:41 PM, york sun wrote:
Ha! I misunderstood. I read this "Enable burst length set, and define it as 4/8/16" and somehow my brain interpreted it as a date. I must be traveling too much recently. :)
And now you're even top-posting and sending html mail , yeah , you should take a break :)
When I reply from my phone, it always does top posting. Any suggestion on a good email client for Android?
Ahyway, are we ok on the patch then ?
Yes, the patch is OK.
York
On 08/25/2016 06:34 PM, york sun wrote:
On 08/24/2016 07:25 PM, Marek Vasut wrote:
On 08/24/2016 07:41 PM, york sun wrote:
Ha! I misunderstood. I read this "Enable burst length set, and define it as 4/8/16" and somehow my brain interpreted it as a date. I must be traveling too much recently. :)
And now you're even top-posting and sending html mail , yeah , you should take a break :)
When I reply from my phone, it always does top posting. Any suggestion on a good email client for Android?
K9 mail maybe ?
Ahyway, are we ok on the patch then ?
Yes, the patch is OK.
Thanks, I'll pick it for next.
York
On 08/22/2016 06:54 AM, Marek Vasut wrote:
On 08/22/2016 02:25 PM, Sriram Dash wrote:
This is required for better performance, and performs below tuning:
- Enable burst length set, and define it as 4/8/16.
- Set burst request limit to 16 requests.
Signed-off-by: Rajesh Bhagat rajesh.bhagat@nxp.com Signed-off-by: Sriram Dash sriram.dash@nxp.com
Looks OK to me. York ?
Reviewed-by: York Sun york.sun@nxp.com
On 09/27/2016 10:30 PM, york sun wrote:
On 08/22/2016 06:54 AM, Marek Vasut wrote:
On 08/22/2016 02:25 PM, Sriram Dash wrote:
This is required for better performance, and performs below tuning:
- Enable burst length set, and define it as 4/8/16.
- Set burst request limit to 16 requests.
Signed-off-by: Rajesh Bhagat rajesh.bhagat@nxp.com Signed-off-by: Sriram Dash sriram.dash@nxp.com
Looks OK to me. York ?
Reviewed-by: York Sun york.sun@nxp.com
This one has already been applied, check u-boot-usb/master
participants (3)
-
Marek Vasut -
Sriram Dash -
york sun