Tom wrote:

The v4 is looking good. No regressions on MAKEALL arm

Are there any outstanding issues besides needing lowercase variable names and the pin multiplex dependency ?

Tom

Sekhar Nori over at TI was kind enough to review this for me prior to submission. The only outstanding question was whether clk_get() should be used by the rest of DaVinci as well as DA8xx.

The answer is probably yes, but this implementation relies on the C structure register overlays, which DaVinci devices do not yet use. Changing DaVinci is outside the remit of adding DA8xx support I believe.

One question relating to lower case variable names. You said:

...

+#define PINMUX &DAVINCI_SYSCFG_REGS->pinmux

Lowercase variables Apply globally.

These are not true variables, but #defines. Is it considered okay to use lowercase in this kind of situation? I would be happier with lowercase, I admit.

I would have preferred to use static "const" variables, but of coursse C doesn't allow those to be used in static assignments as they are not really constant. Bah.

Thanks, Nick.