On 03/25/2012 03:44 PM, Marek Vasut wrote:

Dear Eric Nelson,

...

Hi Marek,

Have you had a chance to review this V4 patch for the fec_mxc driver?

http://lists.denx.de/pipermail/u-boot/2012-March/120205.html

If I didn't review, I was probably fine with it as it was ;-) Though I think I acked it.

Thanks Marek,

I was trying to clean up my "Changes requested" items in patchwork to keep Graeme happy and it appears that this wasn't acked.

http://patchwork.ozlabs.org/patch/146658/

I think Mike also hinted at an ack of V3: http://lists.denx.de/pipermail/u-boot/2012-March/120217.html

Regards,

Eric

Dear Stefano Babic,

On 26/03/2012 00:11, Eric Nelson wrote:

...

Hi Marek,

Hi Eric,

...

Have you had a chance to review this V4 patch for the fec_mxc driver?

http://lists.denx.de/pipermail/u-boot/2012-March/120205.html

Marek has sent all cache relevant patches together in the same patchset. If I am not wrong, your V4 was sent as :

That's true ... also, I'm afraid the arm926ejs stuff won't be Acked by AA since he's gone ... somewhere, noone knows where :-(

http://patchwork.ozlabs.org/patch/147143/

and he added his own Ack.

...

Note that Stefano pointed out yesterday that PPC doesn't properly implement "invalidate_dcache_range".

http://lists.denx.de/pipermail/u-boot/2012-March/120918.html

I believe you mentioned previously that the fec_mxc driver was compatible with certain PPC SOCs, so this might temporarily block any such transition.

For FEC it is easier as for ESDHC. The controller on PowerPC has the same name, but it is different - and there is a different driver. The fec_mxc.c is only for i.MX SOCs, and we are sure we do not break other architectures, except i.MX. I know it breaks MX3x, I will check it.

The whole serie depends on the first patch: http://patchwork.ozlabs.org/patch/147135/

This must be acked / merged by Albert, because it is for all arm926 SOCs.

Best regards, Stefano Babic

Best regards, Marek Vasut