[PATCH] usb: xhci-dwc3: Add support for USB 3.1 controllers
This adds support for the DWC_sub31 controllers such as those found on Apple's M1 SoC. This version of the controller seems to work fine with the existing driver.
Signed-off-by: Mark Kettenis kettenis@openbsd.org --- drivers/usb/host/xhci-dwc3.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-dwc3.c b/drivers/usb/host/xhci-dwc3.c index 3e0ae80cec..a2ea40bae0 100644 --- a/drivers/usb/host/xhci-dwc3.c +++ b/drivers/usb/host/xhci-dwc3.c @@ -70,7 +70,8 @@ int dwc3_core_init(struct dwc3 *dwc3_reg)
revision = readl(&dwc3_reg->g_snpsid); /* This should read as U3 followed by revision number */ - if ((revision & DWC3_GSNPSID_MASK) != 0x55330000) { + if ((revision & DWC3_GSNPSID_MASK) != 0x55330000 && + (revision & DWC3_GSNPSID_MASK) != 0x33310000) { puts("this is not a DesignWare USB3 DRD Core\n"); return -1; }
On Thu, Sep 16, 2021 at 10:00 PM Mark Kettenis kettenis@openbsd.org wrote:
This adds support for the DWC_sub31 controllers such as those found on Apple's M1 SoC. This version of the controller seems to work fine with the existing driver.
Signed-off-by: Mark Kettenis kettenis@openbsd.org
drivers/usb/host/xhci-dwc3.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
Hi Marek,
On Thu, Sep 16, 2021 at 10:08 PM Bin Meng bmeng.cn@gmail.com wrote:
On Thu, Sep 16, 2021 at 10:00 PM Mark Kettenis kettenis@openbsd.org wrote:
This adds support for the DWC_sub31 controllers such as those found on Apple's M1 SoC. This version of the controller seems to work fine with the existing driver.
Signed-off-by: Mark Kettenis kettenis@openbsd.org
drivers/usb/host/xhci-dwc3.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
I see this is assigned to me on patchwork. Would you like this to go via the x86 tree?
Regards, Bin
On 9/19/21 10:40 AM, Bin Meng wrote:
Hi Marek,
On Thu, Sep 16, 2021 at 10:08 PM Bin Meng bmeng.cn@gmail.com wrote:
On Thu, Sep 16, 2021 at 10:00 PM Mark Kettenis kettenis@openbsd.org wrote:
This adds support for the DWC_sub31 controllers such as those found on Apple's M1 SoC. This version of the controller seems to work fine with the existing driver.
Signed-off-by: Mark Kettenis kettenis@openbsd.org
drivers/usb/host/xhci-dwc3.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
I see this is assigned to me on patchwork. Would you like this to go via the x86 tree?
Since it's just one patch, I suspect Tom can just pick it directly.
On Mon, Sep 20, 2021 at 6:44 AM Marek Vasut marex@denx.de wrote:
On 9/19/21 10:40 AM, Bin Meng wrote:
Hi Marek,
On Thu, Sep 16, 2021 at 10:08 PM Bin Meng bmeng.cn@gmail.com wrote:
On Thu, Sep 16, 2021 at 10:00 PM Mark Kettenis kettenis@openbsd.org wrote:
This adds support for the DWC_sub31 controllers such as those found on Apple's M1 SoC. This version of the controller seems to work fine with the existing driver.
Signed-off-by: Mark Kettenis kettenis@openbsd.org
drivers/usb/host/xhci-dwc3.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
I see this is assigned to me on patchwork. Would you like this to go via the x86 tree?
Since it's just one patch, I suspect Tom can just pick it directly.
Thanks, I have re-assigned it to Tom on patchwork.
Regards, Bin
participants (3)
-
Bin Meng -
Marek Vasut -
Mark Kettenis