[U-Boot-Users] MC68360 port
Hi all,
I have ported U-Boot-1.1.6 to MC68360 based board. See the attached file for details. E-mail me if you have any questions :)
Best regards, Matvejchikov Ilya, Russia, Moscow.
On Tuesday 21 November 2006 07:48, Matvejchikov Ilya wrote:
I have ported U-Boot-1.1.6 to MC68360 based board. See the attached file for details. E-mail me if you have any questions :)
Thanks.
Some comments: - Are you sure that you can't use the common CFI FLASH driver? - Please don't use C++ style comments. - Use tabs for indentation (for example in board/mc68360/mc68360.c). - Please rework your board config file. There is no comment at all so this is not readable.
Best regards, Stefan
2006/11/22, Stefan Roese sr@denx.de:
Some comments:
- Are you sure that you can't use the common CFI FLASH driver?
No, I'am not sure about it. Is it so important?
- Please don't use C++ style comments.
- Use tabs for indentation (for example in board/mc68360/mc68360.c).
- Please rework your board config file. There is no comment at all so this is not readable.
ok
On Thursday 23 November 2006 09:06, Matvejchikov Ilya wrote:
2006/11/22, Stefan Roese sr@denx.de:
Some comments:
- Are you sure that you can't use the common CFI FLASH driver?
No, I'am not sure about it. Is it so important?
Yes. Most of the board specific FLASH driver are error prone, since the code and it's error are copied over and over again. This is not maintainable. The CFI driver has a very broad test basis and is maintained quite good.
And a new board port with a board specific flash driver that is not needed, meaning when CFI compliant FLASH chips are used, will not be accepted anymore.
What FLASH chips are you using?
- Please don't use C++ style comments.
- Use tabs for indentation (for example in board/mc68360/mc68360.c).
- Please rework your board config file. There is no comment at all so this is not readable.
ok
Thanks.
Best regards, Stefan
2006/11/23, Stefan Roese sr@denx.de:
On Thursday 23 November 2006 09:06, Matvejchikov Ilya wrote:
2006/11/22, Stefan Roese sr@denx.de:
Some comments:
- Are you sure that you can't use the common CFI FLASH driver?
No, I'am not sure about it. Is it so important?
Yes. Most of the board specific FLASH driver are error prone, since the code and it's error are copied over and over again. This is not maintainable. The CFI driver has a very broad test basis and is maintained quite good.
Right you are! It's the reverse of the 'copy-n-paste' method...
And a new board port with a board specific flash driver that is not needed, meaning when CFI compliant FLASH chips are used, will not be accepted anymore.
What FLASH chips are you using?
Unfortunately, we are use very old AMD flash chips - AM29F800BT. They are not CFI compliant.
On Saturday 25 November 2006 17:42, Matvejchikov Ilya wrote:
And a new board port with a board specific flash driver that is not needed, meaning when CFI compliant FLASH chips are used, will not be accepted anymore.
What FLASH chips are you using?
Unfortunately, we are use very old AMD flash chips - AM29F800BT. They are not CFI compliant.
Autsch. OK, that's a different story then.
Best regards, Stefan
Stefan Roese wrote:
On Saturday 25 November 2006 17:42, Matvejchikov Ilya wrote:
And a new board port with a board specific flash driver that is not needed, meaning when CFI compliant FLASH chips are used, will not be accepted anymore.
What FLASH chips are you using?
Unfortunately, we are use very old AMD flash chips - AM29F800BT. They are not CFI compliant.
Autsch. OK, that's a different story then.
Best regards, Stefan
Most of cfi_flash is probably usable for a non-cfi flash part.
The cfi detection etc. will not work but perhaps if we preset the interface settings from board configuration and do a jedec probe and setup some of the timing based on jedec probe we might be able to use the cfi flash driver for non-cfi flash as well. This should eliminate more custom board drivers. Someone else also was asking if cfi flash driver is able to handle a cfi flash and non-cfi flash at the same time. Perhaps we can handle that as well.
This week, I might be able to come up with such an extension patch. I do not have such an environment to test but with someone taking some time doing testing and providing feedback, I can manage to do this.
Best regards, Tolunay
(resending from correct address, please reply to this mail instead)
Stefan Roese wrote:
On Saturday 25 November 2006 17:42, Matvejchikov Ilya wrote:
And a new board port with a board specific flash driver that is not needed, meaning when CFI compliant FLASH chips are used, will not be accepted anymore.
What FLASH chips are you using?
Unfortunately, we are use very old AMD flash chips - AM29F800BT. They are not CFI compliant.
Autsch. OK, that's a different story then.
Best regards, Stefan
Most of cfi_flash is probably usable for a non-cfi flash part.
The cfi detection etc. will not work but perhaps if we preset the interface settings from board configuration and do a jedec probe and setup some of the timing based on jedec probe we might be able to use the cfi flash driver for non-cfi flash as well. This should eliminate more custom board drivers. Someone else also was asking if cfi flash driver is able to handle a cfi flash and non-cfi flash at the same time. Perhaps we can handle that as well.
This week, I might be able to come up with such an extension patch. I do not have such an environment to test but with someone taking some time doing testing and providing feedback, I can manage to do this.
Best regards, Tolunay
Hi Tolunay,
On Sunday 26 November 2006 07:19, Tolunay Orkun wrote:
Unfortunately, we are use very old AMD flash chips - AM29F800BT. They are not CFI compliant.
Autsch. OK, that's a different story then.
Best regards, Stefan
Most of cfi_flash is probably usable for a non-cfi flash part.
Yes, I though about this option too.
The cfi detection etc. will not work but perhaps if we preset the interface settings from board configuration and do a jedec probe and setup some of the timing based on jedec probe we might be able to use the cfi flash driver for non-cfi flash as well. This should eliminate more custom board drivers. Someone else also was asking if cfi flash driver is able to handle a cfi flash and non-cfi flash at the same time. Perhaps we can handle that as well.
Good idea.
This week, I might be able to come up with such an extension patch. I do not have such an environment to test but with someone taking some time doing testing and providing feedback, I can manage to do this.
This patch would be very welcome. I have to admit, that my time is very limited in the next few weeks. So hopefully someone else has a board and the time to do the testing. Any volunteers? Perhaps Ilya with the AM29F800BT for a start?
Best regards, Stefan
2006/11/26, Stefan Roese sr@denx.de:
Most of cfi_flash is probably usable for a non-cfi flash part.
Yes, I though about this option too.
The cfi detection etc. will not work but perhaps if we preset the interface settings from board configuration and do a jedec probe and setup some of the timing based on jedec probe we might be able to use the cfi flash driver for non-cfi flash as well. This should eliminate more custom board drivers. Someone else also was asking if cfi flash driver is able to handle a cfi flash and non-cfi flash at the same time. Perhaps we can handle that as well.
Good idea.
Yes, It would be a nice thing to do.
This week, I might be able to come up with such an extension patch. I do not have such an environment to test but with someone taking some time doing testing and providing feedback, I can manage to do this.
This patch would be very welcome. I have to admit, that my time is very limited in the next few weeks. So hopefully someone else has a board and the time to do the testing. Any volunteers? Perhaps Ilya with the AM29F800BT for a start?
I'll be happy to help you. Just give me the patch and some time :)
participants (4)
-
Matvejchikov Ilya -
Stefan Roese -
Tolunay Orkun -
Tolunay Orkun