[U-Boot] [PATCH 1/2] ARM: tegra: remove redundant mkdirs from board Makefiles

From: Stephen Warren swarren@nvidia.com
None of harmony, seaboard, ventana, whistler directly build files from ../common/, so there's no need to mkdir the obj directory for such files.
Signed-off-by: Stephen Warren swarren@nvidia.com --- board/nvidia/harmony/Makefile | 4 ---- board/nvidia/seaboard/Makefile | 4 ---- board/nvidia/ventana/Makefile | 2 +- board/nvidia/whistler/Makefile | 4 ---- 4 files changed, 1 insertions(+), 13 deletions(-)
diff --git a/board/nvidia/harmony/Makefile b/board/nvidia/harmony/Makefile index b6efa1c..88b9dcf 100644 --- a/board/nvidia/harmony/Makefile +++ b/board/nvidia/harmony/Makefile @@ -24,10 +24,6 @@
include $(TOPDIR)/config.mk
-ifneq ($(OBJTREE),$(SRCTREE)) -$(shell mkdir -p $(obj)../common) -endif - LIB = $(obj)lib$(BOARD).o
COBJS := $(BOARD).o diff --git a/board/nvidia/seaboard/Makefile b/board/nvidia/seaboard/Makefile index b6efa1c..88b9dcf 100644 --- a/board/nvidia/seaboard/Makefile +++ b/board/nvidia/seaboard/Makefile @@ -24,10 +24,6 @@
include $(TOPDIR)/config.mk
-ifneq ($(OBJTREE),$(SRCTREE)) -$(shell mkdir -p $(obj)../common) -endif - LIB = $(obj)lib$(BOARD).o
COBJS := $(BOARD).o diff --git a/board/nvidia/ventana/Makefile b/board/nvidia/ventana/Makefile index e3b7435..611520c 100644 --- a/board/nvidia/ventana/Makefile +++ b/board/nvidia/ventana/Makefile @@ -25,7 +25,7 @@ include $(TOPDIR)/config.mk
ifneq ($(OBJTREE),$(SRCTREE)) -$(shell mkdir -p $(obj)../common $(obj)../seaboard) +$(shell mkdir -p $(obj)../seaboard) endif
LIB = $(obj)lib$(BOARD).o diff --git a/board/nvidia/whistler/Makefile b/board/nvidia/whistler/Makefile index a910577..913f1ce 100644 --- a/board/nvidia/whistler/Makefile +++ b/board/nvidia/whistler/Makefile @@ -24,10 +24,6 @@
include $(TOPDIR)/config.mk
-ifneq ($(OBJTREE),$(SRCTREE)) -$(shell mkdir -p $(obj)../common) -endif - LIB = $(obj)lib$(BOARD).o
COBJS := $(BOARD).o

From: Stephen Warren swarren@nvidia.com
Ventana always pulls in files from the Seaboard directory, so needs to mkdir $(obj)../seaboard unconditionally. This fixes:
git clean -f -d -x ./MAKEALL ventana
"MAKEALL -s tegra20" passes without this change, because Seaboard happens to be built before Ventana, and hence the directory has already been created.
I believe the mkdir is only needed for out-of-tree builds, since the seaboard directory is part of the source tree. However, since we always build an SPL for Tegra now, which I believe is effectively an out-of-tree build, we will always need this at some time. The overhead of just uncondtionally executing the mkdir is minimal, and simplifies the Makefile, since we don't need to code up the exact minimal condition to execute the mkdir.
Signed-off-by: Stephen Warren swarren@nvidia.com --- board/nvidia/ventana/Makefile | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/board/nvidia/ventana/Makefile b/board/nvidia/ventana/Makefile index 611520c..147d0bc 100644 --- a/board/nvidia/ventana/Makefile +++ b/board/nvidia/ventana/Makefile @@ -24,9 +24,7 @@
include $(TOPDIR)/config.mk
-ifneq ($(OBJTREE),$(SRCTREE)) $(shell mkdir -p $(obj)../seaboard) -endif
LIB = $(obj)lib$(BOARD).o

Stephen,
-----Original Message----- From: Stephen Warren [mailto:swarren@wwwdotorg.org] Sent: Friday, August 03, 2012 9:55 AM To: Tom Warren Cc: Allen Martin; Thierry Reding; Simon Glass; U-Boot Mailing List; Stephen Warren Subject: [PATCH 2/2] ARM: tegra: fix Ventana standalone build
This series (2 patches) applied to u-boot-tegra/next.
Thanks,
Tom

Stephen,
-----Original Message----- From: Stephen Warren [mailto:swarren@wwwdotorg.org] Sent: Friday, August 03, 2012 9:55 AM To: Tom Warren Cc: Allen Martin; Thierry Reding; Simon Glass; U-Boot Mailing List; Stephen Warren Subject: [PATCH 1/2] ARM: tegra: remove redundant mkdirs from board Makefiles
From: Stephen Warren swarren@nvidia.com
None of harmony, seaboard, ventana, whistler directly build files from ../common/, so there's no need to mkdir the obj directory for such files.
Signed-off-by: Stephen Warren swarren@nvidia.com
This patchset (2 parts, including "ARM: tegra: fix Ventana standalone build") applied to u-boot-tegra/next.
Thanks,
Tom
board/nvidia/harmony/Makefile | 4 ---- board/nvidia/seaboard/Makefile | 4 ---- board/nvidia/ventana/Makefile | 2 +- board/nvidia/whistler/Makefile | 4 ---- 4 files changed, 1 insertions(+), 13 deletions(-)
diff --git a/board/nvidia/harmony/Makefile b/board/nvidia/harmony/Makefile index b6efa1c..88b9dcf 100644 --- a/board/nvidia/harmony/Makefile +++ b/board/nvidia/harmony/Makefile @@ -24,10 +24,6 @@
include $(TOPDIR)/config.mk
-ifneq ($(OBJTREE),$(SRCTREE)) -$(shell mkdir -p $(obj)../common) -endif
LIB = $(obj)lib$(BOARD).o
COBJS := $(BOARD).o diff --git a/board/nvidia/seaboard/Makefile b/board/nvidia/seaboard/Makefile index b6efa1c..88b9dcf 100644 --- a/board/nvidia/seaboard/Makefile +++ b/board/nvidia/seaboard/Makefile @@ -24,10 +24,6 @@
include $(TOPDIR)/config.mk
-ifneq ($(OBJTREE),$(SRCTREE)) -$(shell mkdir -p $(obj)../common) -endif
LIB = $(obj)lib$(BOARD).o
COBJS := $(BOARD).o diff --git a/board/nvidia/ventana/Makefile b/board/nvidia/ventana/Makefile index e3b7435..611520c 100644 --- a/board/nvidia/ventana/Makefile +++ b/board/nvidia/ventana/Makefile @@ -25,7 +25,7 @@ include $(TOPDIR)/config.mk
ifneq ($(OBJTREE),$(SRCTREE)) -$(shell mkdir -p $(obj)../common $(obj)../seaboard) +$(shell mkdir -p $(obj)../seaboard) endif
LIB = $(obj)lib$(BOARD).o diff --git a/board/nvidia/whistler/Makefile b/board/nvidia/whistler/Makefile index a910577..913f1ce 100644 --- a/board/nvidia/whistler/Makefile +++ b/board/nvidia/whistler/Makefile @@ -24,10 +24,6 @@
include $(TOPDIR)/config.mk
-ifneq ($(OBJTREE),$(SRCTREE)) -$(shell mkdir -p $(obj)../common) -endif
LIB = $(obj)lib$(BOARD).o
COBJS := $(BOARD).o
1.7.0.4
participants (2)
-
Stephen Warren
-
Tom Warren