[U-Boot] [PATCH] OMAP3: EVM: Convert omap3_evm_version to u32

Convert the variable omap3_evm_version to u32 to work around some broken linkers from older tool chains. E.g. CodeSourcery's 2009q1-203 ld 2.19.51.20090205. Without this, these linkers stop linking 'omap3_evm' or at least issue a warning. Like
arm-none-linux-gnueabi-ld: section .bss [8003f5e0 -> 8007e337] overlaps section .rel.dyn [8003f5e0 -> 80044e57] arm-none-linux-gnueabi-ld: section .dynsym [80044e58 -> 80044ef7] overlaps section.bss [8003f5e0 -> 8007e337] arm-none-linux-gnueabi-ld: u-boot: section .bss vma 0x8003f5e0 overlaps previous sections
CC: Sanjeev Premi premi@ti.com Signed-off-by: Dirk Behme dirk.behme@googlemail.com
---
For a discussion of this see
http://lists.denx.de/pipermail/u-boot/2010-December/083706.html
board/ti/evm/evm.c | 4 ++-- board/ti/evm/evm.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
Index: u-boot.git/board/ti/evm/evm.c =================================================================== --- u-boot.git.orig/board/ti/evm/evm.c +++ u-boot.git/board/ti/evm/evm.c @@ -37,9 +37,9 @@ #include <asm/mach-types.h> #include "evm.h"
-static u8 omap3_evm_version; +static u32 omap3_evm_version;
-u8 get_omap3_evm_rev(void) +u32 get_omap3_evm_rev(void) { return omap3_evm_version; } Index: u-boot.git/board/ti/evm/evm.h =================================================================== --- u-boot.git.orig/board/ti/evm/evm.h +++ u-boot.git/board/ti/evm/evm.h @@ -45,7 +45,7 @@ enum { OMAP3EVM_BOARD_GEN_2, /* EVM Rev >= Rev E */ };
-u8 get_omap3_evm_rev(void); +u32 get_omap3_evm_rev(void);
#if defined(CONFIG_CMD_NET) static void setup_net_chip(void);

Dear Dirk Behme,
In message 1292654428-19095-1-git-send-email-dirk.behme@gmail.com you wrote:
Convert the variable omap3_evm_version to u32 to work around some broken linkers from older tool chains. E.g. CodeSourcery's 2009q1-203 ld 2.19.51.20090205. Without this, these linkers stop linking 'omap3_evm' or at least issue a warning. Like
arm-none-linux-gnueabi-ld: section .bss [8003f5e0 -> 8007e337] overlaps section .rel.dyn [8003f5e0 -> 80044e57] arm-none-linux-gnueabi-ld: section .dynsym [80044e58 -> 80044ef7] overlaps section.bss [8003f5e0 -> 8007e337] arm-none-linux-gnueabi-ld: u-boot: section .bss vma 0x8003f5e0 overlaps previous sections
CC: Sanjeev Premi premi@ti.com Signed-off-by: Dirk Behme dirk.behme@googlemail.com
For a discussion of this see
http://lists.denx.de/pipermail/u-boot/2010-December/083706.html
board/ti/evm/evm.c | 4 ++-- board/ti/evm/evm.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
I'm still unhappy about this solution, but as it appears to be the only fix we can come up with now I pull this now.
Sandeep, hope this is OK with you.
Best regards,
Wolfgang Denk

Signed-off-by: Dirk Behme dirk.behme@googlemail.com
For a discussion of this see
http://lists.denx.de/pipermail/u-boot/2010-December/083706.html
board/ti/evm/evm.c | 4 ++-- board/ti/evm/evm.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
I'm still unhappy about this solution, but as it appears to be the only fix we can come up with now I pull this now.
Sandeep, hope this is OK with you.
For the time being yes
Best regards,
Wolfgang Denk
participants (3)
-
Dirk Behme
-
Paulraj, Sandeep
-
Wolfgang Denk