[PATCH 0/7] Updates for Allied Telesis boards

This is a small series to update some of the Allied Telesis boards. The x240 is converted to bootstd. I've turned off MKEFICAPSULE as the boards don't need it (and our toolchains can't build it). Finally I've enabled IPV6 support so this gets a bit more coverage.
Chris Packham (7): arm: mvebu: x240: Use default baudrate table arm: mvebu: x240: Switch to standard boot arm: mvebu: x240: Don't build mkeficapsule arm: mvebu: x240: Enable IPV6 support arm: mvebu: x530: Remove dead comments arm: mvebu: x530: Don't build mkeficapsule arm: mvebu: x530: Enable IPV6 support
arch/arm/mach-mvebu/Kconfig | 1 + configs/x240_defconfig | 8 ++------ configs/x530_defconfig | 2 ++ include/configs/x240.h | 12 ++---------- include/configs/x530.h | 16 ---------------- 5 files changed, 7 insertions(+), 32 deletions(-)

Remove CFG_SYS_BAUDRATE_TABLE as there's no reason not to use the defaults defined via config_fallbacks.h.
Signed-off-by: Chris Packham judge.packham@gmail.com ---
include/configs/x240.h | 3 --- 1 file changed, 3 deletions(-)
diff --git a/include/configs/x240.h b/include/configs/x240.h index 3601df588d56..bc66e4e3c8e6 100644 --- a/include/configs/x240.h +++ b/include/configs/x240.h @@ -11,9 +11,6 @@ /* additions for new ARM relocation support */ #define CFG_SYS_SDRAM_BASE 0x200000000
-#define CFG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, \ - 115200, 230400, 460800, 921600 } - /* Default Env vars */
#define BOOT_TARGET_DEVICES(func) \

On 22.11.24 01:30, Chris Packham wrote:
Remove CFG_SYS_BAUDRATE_TABLE as there's no reason not to use the defaults defined via config_fallbacks.h.
Signed-off-by: Chris Packham judge.packham@gmail.com
Reviewed-by: Stefan Roese sr@denx.de
Thanks, Stefan
include/configs/x240.h | 3 --- 1 file changed, 3 deletions(-)
diff --git a/include/configs/x240.h b/include/configs/x240.h index 3601df588d56..bc66e4e3c8e6 100644 --- a/include/configs/x240.h +++ b/include/configs/x240.h @@ -11,9 +11,6 @@ /* additions for new ARM relocation support */ #define CFG_SYS_SDRAM_BASE 0x200000000
-#define CFG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, \
115200, 230400, 460800, 921600 }
/* Default Env vars */
#define BOOT_TARGET_DEVICES(func) \
Viele Grüße, Stefan Roese

Use standard boot instead of the distro boot scripts. Regenerate the board defconfig now that some options are selected automatically.
Signed-off-by: Chris Packham judge.packham@gmail.com ---
arch/arm/mach-mvebu/Kconfig | 1 + configs/x240_defconfig | 6 ------ include/configs/x240.h | 9 ++------- 3 files changed, 3 insertions(+), 13 deletions(-)
diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig index b422bb09e023..adb816982f87 100644 --- a/arch/arm/mach-mvebu/Kconfig +++ b/arch/arm/mach-mvebu/Kconfig @@ -224,6 +224,7 @@ config TARGET_X250 config TARGET_X240 bool "Support Allied Telesis x240" select ALLEYCAT_5 + imply BOOTSTD_DEFAULTS
config TARGET_DB_XC3_24G4XG bool "Support DB-XC3-24G4XG" diff --git a/configs/x240_defconfig b/configs/x240_defconfig index f930d28de2dd..4fca1096e740 100644 --- a/configs/x240_defconfig +++ b/configs/x240_defconfig @@ -27,14 +27,9 @@ CONFIG_CMD_PCI=y CONFIG_CMD_SPI=y CONFIG_CMD_USB=y # CONFIG_CMD_SETEXPR is not set -CONFIG_CMD_DHCP=y -CONFIG_CMD_PING=y CONFIG_CMD_CACHE=y CONFIG_CMD_TIME=y CONFIG_CMD_REGULATOR=y -CONFIG_CMD_EXT4=y -CONFIG_CMD_FAT=y -CONFIG_CMD_FS_GENERIC=y CONFIG_CMD_UBI=y CONFIG_ENV_IS_IN_SPI_FLASH=y CONFIG_CLK=y @@ -74,7 +69,6 @@ CONFIG_DM_THERMAL=y CONFIG_USB=y CONFIG_USB_XHCI_HCD=y CONFIG_USB_EHCI_HCD=y -CONFIG_USB_STORAGE=y CONFIG_USB_HOST_ETHER=y CONFIG_USB_ETHER_ASIX=y CONFIG_USB_ETHER_ASIX88179=y diff --git a/include/configs/x240.h b/include/configs/x240.h index bc66e4e3c8e6..05241f33d74f 100644 --- a/include/configs/x240.h +++ b/include/configs/x240.h @@ -12,18 +12,13 @@ #define CFG_SYS_SDRAM_BASE 0x200000000
/* Default Env vars */ - -#define BOOT_TARGET_DEVICES(func) \ - func(USB, usb, 0) \ - func(DHCP, dhcp, na) - -#include <config_distro_bootcmd.h> +#define BOOT_TARGETS "usb dhcp"
#define CFG_EXTRA_ENV_SETTINGS \ - BOOTENV \ "kernel_addr_r=0x202000000\0" \ "fdt_addr_r=0x201000000\0" \ "ramdisk_addr_r=0x206000000\0" \ + "boot_targets=" BOOT_TARGETS "\0" \ "fdtfile=marvell/" CONFIG_DEFAULT_DEVICE_TREE ".dtb\0"
/*

On 22.11.24 01:30, Chris Packham wrote:
Use standard boot instead of the distro boot scripts. Regenerate the board defconfig now that some options are selected automatically.
Signed-off-by: Chris Packham judge.packham@gmail.com
Reviewed-by: Stefan Roese sr@denx.de
Thanks, Stefan
arch/arm/mach-mvebu/Kconfig | 1 + configs/x240_defconfig | 6 ------ include/configs/x240.h | 9 ++------- 3 files changed, 3 insertions(+), 13 deletions(-)
diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig index b422bb09e023..adb816982f87 100644 --- a/arch/arm/mach-mvebu/Kconfig +++ b/arch/arm/mach-mvebu/Kconfig @@ -224,6 +224,7 @@ config TARGET_X250 config TARGET_X240 bool "Support Allied Telesis x240" select ALLEYCAT_5
imply BOOTSTD_DEFAULTS
config TARGET_DB_XC3_24G4XG bool "Support DB-XC3-24G4XG"
diff --git a/configs/x240_defconfig b/configs/x240_defconfig index f930d28de2dd..4fca1096e740 100644 --- a/configs/x240_defconfig +++ b/configs/x240_defconfig @@ -27,14 +27,9 @@ CONFIG_CMD_PCI=y CONFIG_CMD_SPI=y CONFIG_CMD_USB=y # CONFIG_CMD_SETEXPR is not set -CONFIG_CMD_DHCP=y -CONFIG_CMD_PING=y CONFIG_CMD_CACHE=y CONFIG_CMD_TIME=y CONFIG_CMD_REGULATOR=y -CONFIG_CMD_EXT4=y -CONFIG_CMD_FAT=y -CONFIG_CMD_FS_GENERIC=y CONFIG_CMD_UBI=y CONFIG_ENV_IS_IN_SPI_FLASH=y CONFIG_CLK=y @@ -74,7 +69,6 @@ CONFIG_DM_THERMAL=y CONFIG_USB=y CONFIG_USB_XHCI_HCD=y CONFIG_USB_EHCI_HCD=y -CONFIG_USB_STORAGE=y CONFIG_USB_HOST_ETHER=y CONFIG_USB_ETHER_ASIX=y CONFIG_USB_ETHER_ASIX88179=y diff --git a/include/configs/x240.h b/include/configs/x240.h index bc66e4e3c8e6..05241f33d74f 100644 --- a/include/configs/x240.h +++ b/include/configs/x240.h @@ -12,18 +12,13 @@ #define CFG_SYS_SDRAM_BASE 0x200000000
/* Default Env vars */
-#define BOOT_TARGET_DEVICES(func) \
- func(USB, usb, 0) \
- func(DHCP, dhcp, na)
-#include <config_distro_bootcmd.h> +#define BOOT_TARGETS "usb dhcp"
#define CFG_EXTRA_ENV_SETTINGS \
- BOOTENV \ "kernel_addr_r=0x202000000\0" \ "fdt_addr_r=0x201000000\0" \ "ramdisk_addr_r=0x206000000\0" \
"boot_targets=" BOOT_TARGETS "\0" \ "fdtfile=marvell/" CONFIG_DEFAULT_DEVICE_TREE ".dtb\0"
/*
Viele Grüße, Stefan Roese

The x240 board doesn't use EFI and our toolchains don't include gnutls so disable the tool in the defconfig.
Signed-off-by: Chris Packham judge.packham@gmail.com ---
configs/x240_defconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/configs/x240_defconfig b/configs/x240_defconfig index 4fca1096e740..5e5b467b7bac 100644 --- a/configs/x240_defconfig +++ b/configs/x240_defconfig @@ -77,3 +77,4 @@ CONFIG_USB_ETHER_RTL8152=y CONFIG_USB_ETHER_SMSC95XX=y # CONFIG_FAT_WRITE is not set # CONFIG_SMBIOS is not set +# CONFIG_TOOLS_MKEFICAPSULE is not set

On 22.11.24 01:30, Chris Packham wrote:
The x240 board doesn't use EFI and our toolchains don't include gnutls so disable the tool in the defconfig.
Signed-off-by: Chris Packham judge.packham@gmail.com
Reviewed-by: Stefan Roese sr@denx.de
Thanks, Stefan
configs/x240_defconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/configs/x240_defconfig b/configs/x240_defconfig index 4fca1096e740..5e5b467b7bac 100644 --- a/configs/x240_defconfig +++ b/configs/x240_defconfig @@ -77,3 +77,4 @@ CONFIG_USB_ETHER_RTL8152=y CONFIG_USB_ETHER_SMSC95XX=y # CONFIG_FAT_WRITE is not set # CONFIG_SMBIOS is not set +# CONFIG_TOOLS_MKEFICAPSULE is not set
Viele Grüße, Stefan Roese

Enable IPV6 support for the x240 board.
Signed-off-by: Chris Packham judge.packham@gmail.com ---
configs/x240_defconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/configs/x240_defconfig b/configs/x240_defconfig index 5e5b467b7bac..ff64916204cc 100644 --- a/configs/x240_defconfig +++ b/configs/x240_defconfig @@ -32,6 +32,7 @@ CONFIG_CMD_TIME=y CONFIG_CMD_REGULATOR=y CONFIG_CMD_UBI=y CONFIG_ENV_IS_IN_SPI_FLASH=y +CONFIG_IPV6=y CONFIG_CLK=y CONFIG_CLK_MVEBU=y CONFIG_GPIO_HOG=y

On 22.11.24 01:30, Chris Packham wrote:
Enable IPV6 support for the x240 board.
Signed-off-by: Chris Packham judge.packham@gmail.com
Reviewed-by: Stefan Roese sr@denx.de
Thanks, Stefan
configs/x240_defconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/configs/x240_defconfig b/configs/x240_defconfig index 5e5b467b7bac..ff64916204cc 100644 --- a/configs/x240_defconfig +++ b/configs/x240_defconfig @@ -32,6 +32,7 @@ CONFIG_CMD_TIME=y CONFIG_CMD_REGULATOR=y CONFIG_CMD_UBI=y CONFIG_ENV_IS_IN_SPI_FLASH=y +CONFIG_IPV6=y CONFIG_CLK=y CONFIG_CLK_MVEBU=y CONFIG_GPIO_HOG=y
Viele Grüße, Stefan Roese

As things have been moved to Kconfig there are a number of dead comments left over in x530.h. Remove them.
Signed-off-by: Chris Packham judge.packham@gmail.com ---
include/configs/x530.h | 16 ---------------- 1 file changed, 16 deletions(-)
diff --git a/include/configs/x530.h b/include/configs/x530.h index 982b12928734..c7bfd1de17c5 100644 --- a/include/configs/x530.h +++ b/include/configs/x530.h @@ -18,30 +18,14 @@ #define CFG_SYS_NS16550_COM1 MV_UART_CONSOLE_BASE #endif
-/* - * Serial Port configuration - * The following definitions let you select what serial you want to use - * for your console driver. - */ - /* NAND */
#define BBT_CUSTOM_SCAN #define BBT_CUSTOM_SCAN_PAGE 0 #define BBT_CUSTOM_SCAN_POSITION 2048
-/* SPI NOR flash default params, used by sf commands */ - #define MTDPARTS_MTDOOPS "errlog"
-/* Partition support */ - -/* Additional FS support/configuration */ - -/* Environment in SPI NOR flash */ - -/* NAND */ - #include <asm/arch/config.h>
/* Keep device tree and initrd in low memory so the kernel can access them */

On 22.11.24 01:30, Chris Packham wrote:
As things have been moved to Kconfig there are a number of dead comments left over in x530.h. Remove them.
Signed-off-by: Chris Packham judge.packham@gmail.com
Reviewed-by: Stefan Roese sr@denx.de
Thanks, Stefan
include/configs/x530.h | 16 ---------------- 1 file changed, 16 deletions(-)
diff --git a/include/configs/x530.h b/include/configs/x530.h index 982b12928734..c7bfd1de17c5 100644 --- a/include/configs/x530.h +++ b/include/configs/x530.h @@ -18,30 +18,14 @@ #define CFG_SYS_NS16550_COM1 MV_UART_CONSOLE_BASE #endif
-/*
- Serial Port configuration
- The following definitions let you select what serial you want to use
- for your console driver.
*/
/* NAND */
#define BBT_CUSTOM_SCAN #define BBT_CUSTOM_SCAN_PAGE 0 #define BBT_CUSTOM_SCAN_POSITION 2048
-/* SPI NOR flash default params, used by sf commands */
- #define MTDPARTS_MTDOOPS "errlog"
-/* Partition support */
-/* Additional FS support/configuration */
-/* Environment in SPI NOR flash */
-/* NAND */
#include <asm/arch/config.h>
/* Keep device tree and initrd in low memory so the kernel can access them */
Viele Grüße, Stefan Roese

The x530 board doesn't use EFI and our toolchains don't include gnutls so disable the tool in the defconfig.
Signed-off-by: Chris Packham judge.packham@gmail.com ---
configs/x530_defconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/configs/x530_defconfig b/configs/x530_defconfig index 89612be631e3..a5b1cc3f8e89 100644 --- a/configs/x530_defconfig +++ b/configs/x530_defconfig @@ -95,3 +95,4 @@ CONFIG_USB_ETHER_ASIX88179=y CONFIG_WDT=y CONFIG_WDT_ORION=y CONFIG_SPL_TINY_MEMSET=y +# CONFIG_TOOLS_MKEFICAPSULE is not set

On 22.11.24 01:30, Chris Packham wrote:
The x530 board doesn't use EFI and our toolchains don't include gnutls so disable the tool in the defconfig.
Signed-off-by: Chris Packham judge.packham@gmail.com
Reviewed-by: Stefan Roese sr@denx.de
Thanks, Stefan
configs/x530_defconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/configs/x530_defconfig b/configs/x530_defconfig index 89612be631e3..a5b1cc3f8e89 100644 --- a/configs/x530_defconfig +++ b/configs/x530_defconfig @@ -95,3 +95,4 @@ CONFIG_USB_ETHER_ASIX88179=y CONFIG_WDT=y CONFIG_WDT_ORION=y CONFIG_SPL_TINY_MEMSET=y +# CONFIG_TOOLS_MKEFICAPSULE is not set
Viele Grüße, Stefan Roese

Enable IPV6 support for the x530 board.
Signed-off-by: Chris Packham judge.packham@gmail.com ---
configs/x530_defconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/configs/x530_defconfig b/configs/x530_defconfig index a5b1cc3f8e89..815370c90ecc 100644 --- a/configs/x530_defconfig +++ b/configs/x530_defconfig @@ -65,6 +65,7 @@ CONFIG_CMD_UBI=y CONFIG_ENV_OVERWRITE=y CONFIG_ARP_TIMEOUT=200 CONFIG_NET_RETRY_COUNT=50 +CONFIG_IPV6=y CONFIG_SPL_OF_TRANSLATE=y CONFIG_DM_I2C=y CONFIG_SYS_I2C_MVTWSI=y

On 22.11.24 01:30, Chris Packham wrote:
Enable IPV6 support for the x530 board.
Signed-off-by: Chris Packham judge.packham@gmail.com
Reviewed-by: Stefan Roese sr@denx.de
Thanks, Stefan
configs/x530_defconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/configs/x530_defconfig b/configs/x530_defconfig index a5b1cc3f8e89..815370c90ecc 100644 --- a/configs/x530_defconfig +++ b/configs/x530_defconfig @@ -65,6 +65,7 @@ CONFIG_CMD_UBI=y CONFIG_ENV_OVERWRITE=y CONFIG_ARP_TIMEOUT=200 CONFIG_NET_RETRY_COUNT=50 +CONFIG_IPV6=y CONFIG_SPL_OF_TRANSLATE=y CONFIG_DM_I2C=y CONFIG_SYS_I2C_MVTWSI=y
Viele Grüße, Stefan Roese
participants (2)
-
Chris Packham
-
Stefan Roese