[U-Boot] [PATCH v3] generic-board: make compile-time noise for non-generic boards

Commit 0f605c1501f6 (Start the deprecation process for generic board) added a run-time warning message. Let's be noisier for non-generic boards to inform the dead line of the conversion.
This commit intentionally outputs a warning message to stdout. We still have many unconverted boards. If we print the message to stderr, MAKEALL and buildman will report tons of broken boards and really important information will be buried.
Signed-off-by: Masahiro Yamada yamada.m@jp.panasonic.com Acked-by: Marek Vasut marex@denx.de Acked-by: Simon Glass sjg@chromium.org Cc: Tom Rini trini@ti.com ---
Which is better v2(below) and this version? http://patchwork.ozlabs.org/patch/402048/
The difference between the two is which stream is used, stdout or stderr.
Changes in v3: - Print warning messages to stdout rather than stderr
Changes in v2: - Mention to see doc/README.generic-board
Makefile | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/Makefile b/Makefile index f6e1173..76c0876 100644 --- a/Makefile +++ b/Makefile @@ -777,6 +777,13 @@ quiet_cmd_pad_cat = CAT $@ cmd_pad_cat = $(cmd_objcopy) && $(append) || rm -f $@
all: $(ALL-y) +ifneq ($(CONFIG_SYS_GENERIC_BOARD),y) + @echo "===================== WARNING ======================" + @echo "Please convert this board to generic board." + @echo "Otherwise it will be removed by the end of 2014." + @echo "See doc/README.generic-board for further information" + @echo "====================================================" +endif
PHONY += dtbs dtbs dts/dt.dtb: checkdtc u-boot

On Fri, Nov 07, 2014 at 03:32:07AM +0900, Masahiro Yamada wrote:
Commit 0f605c1501f6 (Start the deprecation process for generic board) added a run-time warning message. Let's be noisier for non-generic boards to inform the dead line of the conversion.
This commit intentionally outputs a warning message to stdout. We still have many unconverted boards. If we print the message to stderr, MAKEALL and buildman will report tons of broken boards and really important information will be buried.
Signed-off-by: Masahiro Yamada yamada.m@jp.panasonic.com Acked-by: Marek Vasut marex@denx.de Acked-by: Simon Glass sjg@chromium.org Cc: Tom Rini trini@ti.com
Applied to u-boot/master, thanks!
participants (2)
-
Masahiro Yamada
-
Tom Rini