[U-Boot] [PATCH 1/3, v2] armv8: dts: fsl-ls1043a: add sata node support

Add sata node to support ls1043a.
Signed-off-by: Peng Ma peng.ma@nxp.com --- v2: -no changes
arch/arm/dts/fsl-ls1043a-qds.dtsi | 4 ++++ arch/arm/dts/fsl-ls1043a.dtsi | 8 ++++++++ 2 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/arch/arm/dts/fsl-ls1043a-qds.dtsi b/arch/arm/dts/fsl-ls1043a-qds.dtsi index addb9ab..3841aee 100644 --- a/arch/arm/dts/fsl-ls1043a-qds.dtsi +++ b/arch/arm/dts/fsl-ls1043a-qds.dtsi @@ -174,3 +174,7 @@ &lpuart0 { status = "okay"; }; + +&sata { + status = "okay"; +}; diff --git a/arch/arm/dts/fsl-ls1043a.dtsi b/arch/arm/dts/fsl-ls1043a.dtsi index a804f51..bb70992 100644 --- a/arch/arm/dts/fsl-ls1043a.dtsi +++ b/arch/arm/dts/fsl-ls1043a.dtsi @@ -287,5 +287,13 @@ ranges = <0x81000000 0x0 0x00000000 0x50 0x00020000 0x0 0x00010000 /* downstream I/O */ 0x82000000 0x0 0x40000000 0x50 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */ }; + + sata: sata@3200000 { + compatible = "fsl,ls1043a-ahci"; + reg = <0x0 0x3200000 0x0 0x10000>; + interrupts = <0 69 4>; + clocks = <&clockgen 4 0>; + status = "disabled"; + }; }; };

Add ahci compatible support for ls1043a soc.
Signed-off-by: Peng Ma peng.ma@nxp.com --- v2: -move compatible to orginal position -rebase from master
drivers/ata/sata_ceva.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/ata/sata_ceva.c b/drivers/ata/sata_ceva.c index 047cff7..327ffa5 100644 --- a/drivers/ata/sata_ceva.c +++ b/drivers/ata/sata_ceva.c @@ -88,6 +88,7 @@ enum ceva_soc { CEVA_1V84, CEVA_LS1012A, + CEVA_LS1043A, };
struct ceva_sata_priv { @@ -114,6 +115,7 @@ static int ceva_init_sata(struct ceva_sata_priv *priv) break;
case CEVA_LS1012A: + case CEVA_LS1043A: writel(ECC_DIS_ADDR_CH2, ECC_DIS_VAL_CH2); writel(CEVA_PHY1_CFG, base + AHCI_VEND_PPCFG); writel(CEVA_TRANS_CFG, base + AHCI_VEND_PTC); @@ -144,6 +146,7 @@ static int sata_ceva_probe(struct udevice *dev) static const struct udevice_id sata_ceva_ids[] = { { .compatible = "ceva,ahci-1v84", .data = CEVA_1V84 }, { .compatible = "fsl,ls1012a-ahci", .data = CEVA_LS1012A }, + { .compatible = "fsl,ls1043a-ahci", .data = CEVA_LS1043A }, { } };

Enable related configs to support sata DM feature.
Signed-off-by: Peng Ma peng.ma@nxp.com --- v2: -no changes
configs/ls1043aqds_defconfig | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/configs/ls1043aqds_defconfig b/configs/ls1043aqds_defconfig index 73f7f8a..5510509 100644 --- a/configs/ls1043aqds_defconfig +++ b/configs/ls1043aqds_defconfig @@ -48,3 +48,8 @@ CONFIG_USB_XHCI_DWC3=y CONFIG_USB_STORAGE=y CONFIG_BLK=y CONFIG_DM_MMC=y +CONFIG_DM_SCSI=y +CONFIG_SATA_CEVA=y +CONFIG_SCSI_AHCI=y +CONFIG_SCSI=y +CONFIG_AHCI=y

On 07/31/2018 08:37 PM, Peng Ma wrote:
Enable related configs to support sata DM feature.
Signed-off-by: Peng Ma peng.ma@nxp.com
v2: -no changes
configs/ls1043aqds_defconfig | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/configs/ls1043aqds_defconfig b/configs/ls1043aqds_defconfig index 73f7f8a..5510509 100644 --- a/configs/ls1043aqds_defconfig +++ b/configs/ls1043aqds_defconfig @@ -48,3 +48,8 @@ CONFIG_USB_XHCI_DWC3=y CONFIG_USB_STORAGE=y CONFIG_BLK=y CONFIG_DM_MMC=y +CONFIG_DM_SCSI=y +CONFIG_SATA_CEVA=y +CONFIG_SCSI_AHCI=y +CONFIG_SCSI=y +CONFIG_AHCI=y
Peng,
I noticed your code base seems to have CONFIG_BLK=y. However upstream code doesn't have this option enabled. I can add it for you, but I am afraid I may miss other things you have locally. Please rebase your patch and confirm SATA works as you expected.
York

Hi york,
This patch depend on https://patchwork.ozlabs.org/patch/941093/ , At V2 review I forgot to write depend on. Could I add "depend on" in My patch at V3 or not?
Best regards Peng Ma
-----Original Message----- From: York Sun Sent: 2018年8月8日 5:44 To: Peng Ma peng.ma@nxp.com Cc: albert.u.boot@aribaud.net; Mingkai Hu mingkai.hu@nxp.com; Pankaj Bansal pankaj.bansal@nxp.com; Fabio Estevam fabio.estevam@nxp.com; Yinbo Zhu yinbo.zhu@nxp.com; michal.simek@xilinx.com; sjg@chromium.org; Andy Tang andy.tang@nxp.com; u-boot@lists.denx.de Subject: Re: [PATCH 3/3,v2] arm64: ls1043aqds: enable DM support for sata
On 07/31/2018 08:37 PM, Peng Ma wrote:
Enable related configs to support sata DM feature.
Signed-off-by: Peng Ma peng.ma@nxp.com
v2: -no changes
configs/ls1043aqds_defconfig | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/configs/ls1043aqds_defconfig b/configs/ls1043aqds_defconfig index 73f7f8a..5510509 100644 --- a/configs/ls1043aqds_defconfig +++ b/configs/ls1043aqds_defconfig @@ -48,3 +48,8 @@ CONFIG_USB_XHCI_DWC3=y CONFIG_USB_STORAGE=y CONFIG_BLK=y CONFIG_DM_MMC=y +CONFIG_DM_SCSI=y +CONFIG_SATA_CEVA=y +CONFIG_SCSI_AHCI=y +CONFIG_SCSI=y +CONFIG_AHCI=y
Peng,
I noticed your code base seems to have CONFIG_BLK=y. However upstream code doesn't have this option enabled. I can add it for you, but I am afraid I may miss other things you have locally. Please rebase your patch and confirm SATA works as you expected.
York

On 08/07/2018 06:51 PM, Peng Ma wrote:
Hi york,
This patch depend on https://patchwork.ozlabs.org/patch/941093/ , At V2 review I forgot to write depend on. Could I add "depend on" in My patch at V3 or not?
Do not send another version just to explain the dependency, since I know it now.
York

-----Original Message----- From: York Sun Sent: 2018年8月8日 10:00 To: Peng Ma peng.ma@nxp.com Cc: albert.u.boot@aribaud.net; Mingkai Hu mingkai.hu@nxp.com; Pankaj Bansal pankaj.bansal@nxp.com; Fabio Estevam fabio.estevam@nxp.com; Yinbo Zhu yinbo.zhu@nxp.com; michal.simek@xilinx.com; sjg@chromium.org; Andy Tang andy.tang@nxp.com; u-boot@lists.denx.de Subject: Re: [PATCH 3/3,v2] arm64: ls1043aqds: enable DM support for sata
On 08/07/2018 06:51 PM, Peng Ma wrote:
Hi york,
This patch depend on https://patchwork.ozlabs.org/patch/941093/ , At V2 review I forgot to write depend on. Could I add "depend on" in My patch at V3 or not?
Do not send another version just to explain the dependency, since I know it now.
York
OK, THANKS Peng

On 07/31/2018 08:37 PM, Peng Ma wrote:
Add sata node to support ls1043a.
Signed-off-by: Peng Ma peng.ma@nxp.com
v2: -no changes
This patch set has been applied to fsl-qoriq master, awaiting upstream. Thanks.
York
participants (2)
-
Peng Ma
-
York Sun