[U-Boot] [PATCH] cmd_usb_mass_storage: Remove extra 'ums' string in the usage text

Currently the usage text for the 'ums' command looks like this:
Usage: ums ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0
,so remove the extra 'ums' in the text.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- common/cmd_usb_mass_storage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cmd_usb_mass_storage.c b/common/cmd_usb_mass_storage.c index 2c879ea..51c3fff 100644 --- a/common/cmd_usb_mass_storage.c +++ b/common/cmd_usb_mass_storage.c @@ -159,6 +159,6 @@ exit:
U_BOOT_CMD(ums, 4, 1, do_usb_mass_storage, "Use the UMS [User Mass Storage]", - "ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0\n" + "<USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0\n" " devtype defaults to mmc" );

On Wed, Feb 25, 2015 at 1:03 PM, Fabio Estevam fabio.estevam@freescale.com wrote:
Currently the usage text for the 'ums' command looks like this:
Usage: ums ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0
,so remove the extra 'ums' in the text.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Acked-by: Otavio Salvador otavio@ossystems.com.br

On Wednesday, February 25, 2015 at 05:03:19 PM, Fabio Estevam wrote:
Currently the usage text for the 'ums' command looks like this:
Usage: ums ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0
,so remove the extra 'ums' in the text.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Acked-by: Marek Vasut marex@denx.de
Best regards, Marek Vasut

Currently the usage text for the 'ums' command looks like this:
Usage: ums ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0
,so remove the extra 'ums' in the text.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
When fixing the ums help text, I think we also should change the "long name" from "User Mass Storage" to "USB Mass Storage".
Regards, Soeren

Hi Soeren,
On Fri, Feb 27, 2015 at 10:20 AM, Soeren Moch smoch@web.de wrote:
Currently the usage text for the 'ums' command looks like this:
Usage: ums ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0
,so remove the extra 'ums' in the text.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
When fixing the ums help text, I think we also should change the "long name" from "User Mass Storage" to "USB Mass Storage".
Maybe a separate patch for this?
Regards,
Fabio Estevam

On Saturday, February 28, 2015 at 05:04:09 PM, Fabio Estevam wrote:
Hi Soeren,
On Fri, Feb 27, 2015 at 10:20 AM, Soeren Moch smoch@web.de wrote:
Currently the usage text for the 'ums' command looks like this:
Usage: ums ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0
,so remove the extra 'ums' in the text.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
When fixing the ums help text, I think we also should change the "long name" from "User Mass Storage" to "USB Mass Storage".
Maybe a separate patch for this?
Separate please .
Best regards, Marek Vasut

Hi Fabio,
On 28.02.2015 17:04, Fabio Estevam wrote:
Hi Soeren,
On Fri, Feb 27, 2015 at 10:20 AM, Soeren Moch smoch@web.de wrote:
Currently the usage text for the 'ums' command looks like this:
Usage: ums ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0
,so remove the extra 'ums' in the text.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
When fixing the ums help text, I think we also should change the "long name" from "User Mass Storage" to "USB Mass Storage".
Maybe a separate patch for this?
Thank you for preparing and sending the patch.
Regards, Soeren

On Wed, Feb 25, 2015 at 01:03:19PM -0300, Fabio Estevam wrote:
Currently the usage text for the 'ums' command looks like this:
Usage: ums ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0
,so remove the extra 'ums' in the text.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com Acked-by: Otavio Salvador otavio@ossystems.com.br Acked-by: Marek Vasut marex@denx.de
Applied to u-boot/master, thanks!
participants (6)
-
Fabio Estevam
-
Fabio Estevam
-
Marek Vasut
-
Otavio Salvador
-
Soeren Moch
-
Tom Rini