Re: [U-Boot] [PATCH v3 00/27] spi/sf: Updates on flash detection

On 08/11/2016 08:12 AM, york.sun@nxp.com wrote:
On 08/11/2016 01:15 AM, Jagan Teki wrote:
Tested on microzed and sandbox
Tested-by: Jagan Teki jteki@openedev.com
I've some host issues while running buildman, can anyone please run buildman?
I can compile for power and (limited) arm for you.
I can't compile test your v3 patch. They are not in mailing list, or patchwork. I only got some of them.
York

On 11 August 2016 at 20:47, york sun york.sun@nxp.com wrote:
On 08/11/2016 08:12 AM, york.sun@nxp.com wrote:
On 08/11/2016 01:15 AM, Jagan Teki wrote:
Tested on microzed and sandbox
Tested-by: Jagan Teki jteki@openedev.com
I've some host issues while running buildman, can anyone please run buildman?
I can compile for power and (limited) arm for you.
I can't compile test your v3 patch. They are not in mailing list, or patchwork. I only got some of them.
Ohh..look like these are not in patchwork, Tom any idea?

On 08/11/2016 09:17 AM, Jagan Teki wrote:
On 11 August 2016 at 20:47, york sun york.sun@nxp.com wrote:
On 08/11/2016 08:12 AM, york.sun@nxp.com wrote:
On 08/11/2016 01:15 AM, Jagan Teki wrote:
Tested on microzed and sandbox
Tested-by: Jagan Teki jteki@openedev.com
I've some host issues while running buildman, can anyone please run buildman?
I can compile for power and (limited) arm for you.
I can't compile test your v3 patch. They are not in mailing list, or patchwork. I only got some of them.
Ohh..look like these are not in patchwork, Tom any idea?
Jagan,
Maybe it takes time to show up in mailing list. It happened to me many times. Please send me the patches, or point me to your repository.
York

On 11 August 2016 at 21:50, york sun york.sun@nxp.com wrote:
On 08/11/2016 09:17 AM, Jagan Teki wrote:
On 11 August 2016 at 20:47, york sun york.sun@nxp.com wrote:
On 08/11/2016 08:12 AM, york.sun@nxp.com wrote:
On 08/11/2016 01:15 AM, Jagan Teki wrote:
Tested on microzed and sandbox
Tested-by: Jagan Teki jteki@openedev.com
I've some host issues while running buildman, can anyone please run buildman?
I can compile for power and (limited) arm for you.
I can't compile test your v3 patch. They are not in mailing list, or patchwork. I only got some of them.
Ohh..look like these are not in patchwork, Tom any idea?
Jagan,
Maybe it takes time to show up in mailing list. It happened to me many times. Please send me the patches, or point me to your repository.
Please take the u-boot-spi/next [1]
[1] http://git.denx.de/?p=u-boot-spi.git;a=shortlog;h=refs/heads/next

I saw some errors when compiling for arm. Compiling for power is still going.
York
------------------------------------------ [...truncated 15335 lines...] aarch64: + ls1043aqds_sdcard_ifc + u16 jedec, ext_jedec; + ^ + ^ w+../drivers/mtd/spi/spi_flash.c: In function ‘spi_flash_scan’: w+../drivers/mtd/spi/spi_flash.c:1043:13: warning: variable ‘ext_jedec’ set but not used [-Wunused-but-set-variable] w+../drivers/mtd/spi/spi_flash.c:1043:6: warning: variable ‘jedec’ set but not used [-Wunused-but-set-variable] 2429 529 15 /3000 0:03:38 : ls1043aqds_sdcard_ifc 25: sf: Remove non-meaningful comments 2430 529 15 /3000 0:03:14 : ls1043ardb_sdcard 30: spi: Remove dual flash code 2431 529 15 /3000 0:03:06 : xilinx_zynqmp_zc1751_xm016_dc2 30: spi: Remove dual flash code 2432 529 15 /3000 0:03:04 : hikey 26: sf: Rename sf_params.c to spi_flash_ids 2433 529 15 /3000 0:03:04 : xilinx_zynqmp_zcu102_revB 26: sf: Rename sf_params.c to spi_flash_ids 2434 529 15 /3000 0:03:04 : sandbox 26: sf: Rename sf_params.c to spi_flash_ids 2435 529 15 /3000 0:02:50 : ls1043ardb_sdcard 22: sf: Add INFO6 flash_info macro aarch64: + ls1043aqds_sdcard_ifc + u16 jedec, ext_jedec; + ^ + ^ w+../drivers/mtd/spi/spi_flash.c: In function ‘spi_flash_scan’: w+../drivers/mtd/spi/spi_flash.c:1043:13: warning: variable ‘ext_jedec’ set but not used [-Wunused-but-set-variable] w+../drivers/mtd/spi/spi_flash.c:1043:6: warning: variable ‘jedec’ set but not used [-Wunused-but-set-variable] 2435 530 15 /3000 0:02:50 : ls1043aqds_sdcard_ifc 27: sf: ids: Use small letter's with flash name 2436 530 15 /3000 0:02:56 : sandbox 27: sf: ids: Use small letter's with flash name 2437 530 15 /3000 0:02:37 : xilinx_zynqmp_zcu102_revB 27: sf: ids: Use small letter's with flash name 2438 530 15 /3000 0:02:33 : ls1043ardb_sdcard 23: sf: params: Add S25FS256S_64K spi flash support aarch64: + ls1043aqds_sdcard_ifc + u16 jedec, ext_jedec; + ^ + ^ w+../drivers/mtd/spi/spi_flash.c: In function ‘spi_flash_scan’: w+../drivers/mtd/spi/spi_flash.c:1043:13: warning: variable ‘ext_jedec’ set but not used [-Wunused-but-set-variable] w+../drivers/mtd/spi/spi_flash.c:1043:6: warning: variable ‘jedec’ set but not used [-Wunused-but-set-variable] 2438 531 15 /3000 0:02:33 : ls1043aqds_sdcard_ifc 28: sf: ids: Use small letter in ext_jedec 2439 531 15 /3000 0:02:26 : sandbox 28: sf: ids: Use small letter in ext_jedec 2440 531 15 /3000 0:02:11 : xilinx_zynqmp_zcu102_revB 28: sf: ids: Use small letter in ext_jedec 2441 531 15 /3000 0:02:09 : ls1043ardb_sdcard 24: sf: Remove legacy idcode detection code 2442 531 15 /3000 0:01:59 : ls1043aqds_sdcard_ifc 29: sf: Rename few local functions 2443 531 15 /3000 0:01:56 : sandbox 29: sf: Rename few local functions 2444 531 15 /3000 0:01:46 : xilinx_zynqmp_zcu102_revB 29: sf: Rename few local functions 2445 531 15 /3000 0:01:40 : ls1043ardb_sdcard 25: sf: Remove non-meaningful comments 2446 531 15 /3000 0:01:26 : ls1043aqds_sdcard_ifc 30: spi: Remove dual flash code 2447 531 15 /3000 0:01:13 : sandbox 30: spi: Remove dual flash code 2448 531 15 /3000 0:01:05 : xilinx_zynqmp_zcu102_revB 30: spi: Remove dual flash code 2449 531 15 /3000 0:00:58 : ls1043ardb_sdcard 26: sf: Rename sf_params.c to spi_flash_ids 2450 531 15 /3000 0:00:46 : ls1043aqds_sdcard_ifc 27: sf: ids: Use small letter's with flash name 2451 531 15 /3000 0:00:40 : ls1043aqds_sdcard_ifc 28: sf: ids: Use small letter in ext_jedec 2452 531 15 /3000 0:00:30 : ls1043aqds_sdcard_ifc 29: sf: Rename few local functions 2453 531 15 /3000 0:00:16 : ls1043aqds_sdcard_ifc 30: spi: Remove dual flash code 2454 531 15 /3000 ls1043aqds_sdcard_ifc + retval=128 + ./tools/buildman/buildman -b working_upstream_qoriq 'arm & freescale' aarch64 sandbox --exclude=taishan,dlvision,mx28evk,mx28evk_spi,mx28evk_nand,mx28evk_auart_console,mx23evk -seul boards.cfg is up to date. Nothing to do. Summary of 30 commits for 100 boards (24 threads, 1 job per thread) 01: Merge git://www.denx.de/git/u-boot-ppc4xx aarch64: + pine64_plus +(pine64_plus) himport_r(&env_htab, (char *)spl->fel_script_address, +(pine64_plus) ^ w+(pine64_plus) ../board/sunxi/board.c: In function ‘parse_spl_header’: w+(pine64_plus) ../board/sunxi/board.c:605:24: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 02: spi: zynq_spi: Fix infinite looping while xfer 03: dm: at91: Add driver model support for the spi driver 04: sf: Simplify fastest read cmd code 05: sf: Remove e_rd_cmd from param table 06: spi: Use mode for rx mode flags 07: spi: Remove SPI_RX_FAST 08: sf: Remove SECT_32K 09: sf: Add CONFIG_SPI_FLASH_USE_4K_SECTORS in spi_flash 10: sf: Move flags macro's to spi_flash_params{} members 11: sf: Adopt flash table INFO macro from Linux aarch64: + ls2080aqds_SECURE_BOOT ls1043aqds ls1043ardb p2571 xilinx_zynqmp_ep evb-rk3399 ls2080ardb_SECURE_BOOT ls1043aqds_nand ls1043ardb_SECURE_BOOT ls1043aqds_lpuart ls1043ardb_nand ls2080aqds ls2080ardb p2371-0000 ls1043aqds_nor_ddr3 p2371-2180 xilinx_zynqmp_zc1751_xm016_dc2 e2220-1170 ls1043ardb_sdcard ls1043aqds_sdcard_ifc sandbox: + sandbox_noblk sandbox_spl sandbox arm: + mx6sabresd_spl vf610twr_nand mx6slevk_spinor ls1021atwr_sdcard_qspi vf610twr mx6sxsabresd_spl mx6ul_14x14_evk mx6slevk_spl mx6slevk mx6sxsabreauto mx6sxsabresd mx6qsabreauto mx6dlsabresd mx6qpsabreauto mx6dlsabreauto mx6ul_9x9_evk ls1021atwr_qspi mx6qsabresd +(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) ext_jedec = idcode[3] << 8 | idcode[4]; +(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) ^ +(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) if (idcode[0] == SPI_FLASH_CFI_MFR_ATMEL || +(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) ^ +(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) jedec = idcode[1] << 8 | idcode[2]; +(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) ^ +(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) ^ +(sandbox_noblk,sandbox_spl,sandbox) ../drivers/mtd/spi/sandbox.c: In function ‘sandbox_sf_xfer’: +(sandbox_noblk,sandbox_spl,sandbox) ../drivers/mtd/spi/sandbox.c:362:20: error: ‘const struct spi_flash_params’ has no member named ‘jedec’ +(sandbox_noblk,sandbox_spl,sandbox) make[2]: *** [drivers/mtd/spi/sandbox.o] Error 1 +(sandbox_noblk,sandbox_spl,sandbox) make[1]: *** [drivers/mtd/spi] Error 2 +(sandbox_noblk,sandbox_spl,sandbox) make: *** [sub-make] Error 2 w+(mx6sabresd_spl,p2371-2180,ls2080aqds_SECURE_BOOT,vf610twr_nand,ls1043aqds,ls1043ardb,mx6slevk_spinor,p2571,ls1021atwr_sdcard_qspi,vf610twr,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,mx6sxsabresd_spl,mx6ul_14x14_evk,mx6slevk_spl,mx6slevk,mx6sxsabreauto,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,mx6sxsabresd,ls2080ardb,mx6qsabreauto,mx6dlsabresd,mx6qpsabreauto,mx6dlsabreauto,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,mx6ul_9x9_evk,e2220-1170,ls1043ardb_sdcard,ls1021atwr_qspi,ls1043aqds_sdcard_ifc,mx6qsabresd) ../drivers/mtd/spi/spi_flash.c: In function ‘spi_flash_scan’: w+(mx6sabresd_spl,mx6sxsabresd_spl,mx6ul_14x14_evk,mx6slevk_spl,mx6ul_9x9_evk) ../drivers/mtd/spi/spi_flash.c:1088:43: warning: ‘idcode[0]’ may be used uninitialized in this function [-Wuninitialized] w+(mx6sabresd_spl,vf610twr_nand,mx6slevk_spinor,ls1021atwr_sdcard_qspi,vf610twr,mx6sxsabresd_spl,mx6ul_14x14_evk,mx6slevk_spl,mx6slevk,mx6sxsabreauto,mx6sxsabresd,mx6qsabreauto,mx6dlsabresd,mx6qpsabreauto,mx6dlsabreauto,mx6ul_9x9_evk,ls1021atwr_qspi,mx6qsabresd) ../drivers/mtd/spi/spi_flash.c:1048:8: warning: ‘idcode[2]’ may be used uninitialized in this function [-Wuninitialized] w+(mx6sabresd_spl,vf610twr_nand,mx6slevk_spinor,ls1021atwr_sdcard_qspi,vf610twr,mx6sxsabresd_spl,mx6ul_14x14_evk,mx6slevk_spl,mx6slevk,mx6sxsabreauto,mx6sxsabresd,mx6qsabreauto,mx6dlsabresd,mx6qpsabreauto,mx6dlsabreauto,mx6ul_9x9_evk,ls1021atwr_qspi,mx6qsabresd) ../drivers/mtd/spi/spi_flash.c:1048:20: warning: ‘idcode[1]’ may be used uninitialized in this function [-Wuninitialized] w+(mx6sabresd_spl,vf610twr_nand,mx6slevk_spinor,ls1021atwr_sdcard_qspi,vf610twr,mx6sxsabresd_spl,mx6ul_14x14_evk,mx6slevk_spl,mx6slevk,mx6sxsabreauto,mx6sxsabresd,mx6qsabreauto,mx6dlsabresd,mx6qpsabreauto,mx6dlsabreauto,mx6ul_9x9_evk,ls1021atwr_qspi,mx6qsabresd) ../drivers/mtd/spi/spi_flash.c:1049:24: warning: ‘idcode[3]’ may be used uninitialized in this function [-Wuninitialized] w+(mx6sabresd_spl,vf610twr_nand,mx6slevk_spinor,ls1021atwr_sdcard_qspi,vf610twr,mx6sxsabresd_spl,mx6ul_14x14_evk,mx6slevk_spl,mx6slevk,mx6sxsabreauto,mx6sxsabresd,mx6qsabreauto,mx6dlsabresd,mx6qpsabreauto,mx6dlsabreauto,mx6ul_9x9_evk,ls1021atwr_qspi,mx6qsabresd) ../drivers/mtd/spi/spi_flash.c:1049:12: warning: ‘idcode[4]’ may be used uninitialized in this function [-Wuninitialized] w+(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) ../drivers/mtd/spi/spi_flash.c:1049:24: warning: ‘idcode[3]’ may be used uninitialized in this function [-Wmaybe-uninitialized] w+(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) ../drivers/mtd/spi/spi_flash.c:1049:12: warning: ‘idcode[4]’ may be used uninitialized in this function [-Wmaybe-uninitialized] w+(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) ../drivers/mtd/spi/spi_flash.c:1088:43: warning: ‘idcode[0]’ may be used uninitialized in this function [-Wmaybe-uninitialized] w+(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) ../drivers/mtd/spi/spi_flash.c:1048:8: warning: ‘idcode[2]’ may be used uninitialized in this function [-Wmaybe-uninitialized] w+(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) ../drivers/mtd/spi/spi_flash.c:1048:20: warning: ‘idcode[1]’ may be used uninitialized in this function [-Wmaybe-uninitialized] w+(vf610twr_nand,mx6slevk_spinor,ls1021atwr_sdcard_qspi,vf610twr,mx6slevk,mx6sxsabreauto,mx6sxsabresd,mx6qsabreauto,mx6dlsabresd,mx6qpsabreauto,mx6dlsabreauto,ls1021atwr_qspi,mx6qsabresd) ../drivers/mtd/spi/spi_flash.c:1089:46: warning: ‘idcode[0]’ may be used uninitialized in this function [-Wuninitialized] w+(mx6sxsabresd_spl) ../drivers/mtd/spi/spi_flash.c:1042:6: warning: ‘ret’ may be used uninitialized in this function [-Wuninitialized] 12: sf: Add JEDEC_ID and JEDEC_EXT macro -(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) ext_jedec = idcode[3] << 8 | idcode[4]; -(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) ^ -(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) jedec = idcode[1] << 8 | idcode[2]; -(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) ^ -(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) ^ +(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) u16 jedec, ext_jedec; +(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) ^ +(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) ^ w-(mx6sabresd_spl,vf610twr_nand,mx6slevk_spinor,ls1021atwr_sdcard_qspi,vf610twr,mx6sxsabresd_spl,mx6ul_14x14_evk,mx6slevk_spl,mx6slevk,mx6sxsabreauto,mx6sxsabresd,mx6qsabreauto,mx6dlsabresd,mx6qpsabreauto,mx6dlsabreauto,mx6ul_9x9_evk,ls1021atwr_qspi,mx6qsabresd) ../drivers/mtd/spi/spi_flash.c:1048:8: warning: ‘idcode[2]’ may be used uninitialized in this function [-Wuninitialized] w-(mx6sabresd_spl,vf610twr_nand,mx6slevk_spinor,ls1021atwr_sdcard_qspi,vf610twr,mx6sxsabresd_spl,mx6ul_14x14_evk,mx6slevk_spl,mx6slevk,mx6sxsabreauto,mx6sxsabresd,mx6qsabreauto,mx6dlsabresd,mx6qpsabreauto,mx6dlsabreauto,mx6ul_9x9_evk,ls1021atwr_qspi,mx6qsabresd) ../drivers/mtd/spi/spi_flash.c:1048:20: warning: ‘idcode[1]’ may be used uninitialized in this function [-Wuninitialized] w-(mx6sabresd_spl,vf610twr_nand,mx6slevk_spinor,ls1021atwr_sdcard_qspi,vf610twr,mx6sxsabresd_spl,mx6ul_14x14_evk,mx6slevk_spl,mx6slevk,mx6sxsabreauto,mx6sxsabresd,mx6qsabreauto,mx6dlsabresd,mx6qpsabreauto,mx6dlsabreauto,mx6ul_9x9_evk,ls1021atwr_qspi,mx6qsabresd) ../drivers/mtd/spi/spi_flash.c:1049:24: warning: ‘idcode[3]’ may be used uninitialized in this function [-Wuninitialized] w-(mx6sabresd_spl,vf610twr_nand,mx6slevk_spinor,ls1021atwr_sdcard_qspi,vf610twr,mx6sxsabresd_spl,mx6ul_14x14_evk,mx6slevk_spl,mx6slevk,mx6sxsabreauto,mx6sxsabresd,mx6qsabreauto,mx6dlsabresd,mx6qpsabreauto,mx6dlsabreauto,mx6ul_9x9_evk,ls1021atwr_qspi,mx6qsabresd) ../drivers/mtd/spi/spi_flash.c:1049:12: warning: ‘idcode[4]’ may be used uninitialized in this function [-Wuninitialized] w-(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) ../drivers/mtd/spi/spi_flash.c:1049:24: warning: ‘idcode[3]’ may be used uninitialized in this function [-Wmaybe-uninitialized] w-(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) ../drivers/mtd/spi/spi_flash.c:1049:12: warning: ‘idcode[4]’ may be used uninitialized in this function [-Wmaybe-uninitialized] w-(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) ../drivers/mtd/spi/spi_flash.c:1048:8: warning: ‘idcode[2]’ may be used uninitialized in this function [-Wmaybe-uninitialized] w-(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) ../drivers/mtd/spi/spi_flash.c:1048:20: warning: ‘idcode[1]’ may be used uninitialized in this function [-Wmaybe-uninitialized] w+(mx6sabresd_spl,p2371-2180,ls2080aqds_SECURE_BOOT,vf610twr_nand,ls1043aqds,ls1043ardb,mx6slevk_spinor,p2571,ls1021atwr_sdcard_qspi,vf610twr,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,mx6sxsabresd_spl,mx6ul_14x14_evk,mx6slevk_spl,mx6slevk,mx6sxsabreauto,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,mx6sxsabresd,ls2080ardb,mx6qsabreauto,mx6dlsabresd,mx6qpsabreauto,mx6dlsabreauto,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,mx6ul_9x9_evk,e2220-1170,ls1043ardb_sdcard,ls1021atwr_qspi,ls1043aqds_sdcard_ifc,mx6qsabresd) ../drivers/mtd/spi/spi_flash.c:1040:13: warning: variable ‘ext_jedec’ set but not used [-Wunused-but-set-variable] w+(mx6sabresd_spl,p2371-2180,ls2080aqds_SECURE_BOOT,vf610twr_nand,ls1043aqds,ls1043ardb,mx6slevk_spinor,p2571,ls1021atwr_sdcard_qspi,vf610twr,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,mx6sxsabresd_spl,mx6ul_14x14_evk,mx6slevk_spl,mx6slevk,mx6sxsabreauto,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,mx6sxsabresd,ls2080ardb,mx6qsabreauto,mx6dlsabresd,mx6qpsabreauto,mx6dlsabreauto,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,mx6ul_9x9_evk,e2220-1170,ls1043ardb_sdcard,ls1021atwr_qspi,ls1043aqds_sdcard_ifc,mx6qsabresd) ../drivers/mtd/spi/spi_flash.c:1040:6: warning: variable ‘jedec’ set but not used [-Wunused-but-set-variable] 13: sf: Rename spi_flash_params => spi_flash_info -(sandbox_noblk,sandbox_spl,sandbox) ../drivers/mtd/spi/sandbox.c:362:20: error: ‘const struct spi_flash_params’ has no member named ‘jedec’ +(sandbox_noblk,sandbox_spl,sandbox) ../drivers/mtd/spi/sandbox.c:362:20: error: ‘const struct spi_flash_info’ has no member named ‘jedec’ 14: sf: Add JEDEC_MFR -(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) if (idcode[0] == SPI_FLASH_CFI_MFR_ATMEL || -(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) ^ w-(mx6sabresd_spl,p2371-2180,ls2080aqds_SECURE_BOOT,vf610twr_nand,ls1043aqds,ls1043ardb,mx6slevk_spinor,p2571,ls1021atwr_sdcard_qspi,vf610twr,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,mx6sxsabresd_spl,mx6ul_14x14_evk,mx6slevk_spl,mx6slevk,mx6sxsabreauto,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,mx6sxsabresd,ls2080ardb,mx6qsabreauto,mx6dlsabresd,mx6qpsabreauto,mx6dlsabreauto,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,mx6ul_9x9_evk,e2220-1170,ls1043ardb_sdcard,ls1021atwr_qspi,ls1043aqds_sdcard_ifc,mx6qsabresd) ../drivers/mtd/spi/spi_flash.c:1040:13: warning: variable ‘ext_jedec’ set but not used [-Wunused-but-set-variable] w-(mx6sabresd_spl,p2371-2180,ls2080aqds_SECURE_BOOT,vf610twr_nand,ls1043aqds,ls1043ardb,mx6slevk_spinor,p2571,ls1021atwr_sdcard_qspi,vf610twr,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,mx6sxsabresd_spl,mx6ul_14x14_evk,mx6slevk_spl,mx6slevk,mx6sxsabreauto,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,mx6sxsabresd,ls2080ardb,mx6qsabreauto,mx6dlsabresd,mx6qpsabreauto,mx6dlsabreauto,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,mx6ul_9x9_evk,e2220-1170,ls1043ardb_sdcard,ls1021atwr_qspi,ls1043aqds_sdcard_ifc,mx6qsabresd) ../drivers/mtd/spi/spi_flash.c:1040:6: warning: variable ‘jedec’ set but not used [-Wunused-but-set-variable] w-(mx6sabresd_spl,mx6sxsabresd_spl,mx6ul_14x14_evk,mx6slevk_spl,mx6ul_9x9_evk) ../drivers/mtd/spi/spi_flash.c:1088:43: warning: ‘idcode[0]’ may be used uninitialized in this function [-Wuninitialized] w-(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) ../drivers/mtd/spi/spi_flash.c:1088:43: warning: ‘idcode[0]’ may be used uninitialized in this function [-Wmaybe-uninitialized] w-(vf610twr_nand,mx6slevk_spinor,ls1021atwr_sdcard_qspi,vf610twr,mx6slevk,mx6sxsabreauto,mx6sxsabresd,mx6qsabreauto,mx6dlsabresd,mx6qpsabreauto,mx6dlsabreauto,ls1021atwr_qspi,mx6qsabresd) ../drivers/mtd/spi/spi_flash.c:1089:46: warning: ‘idcode[0]’ may be used uninitialized in this function [-Wuninitialized] w-(mx6sxsabresd_spl) ../drivers/mtd/spi/spi_flash.c:1042:6: warning: ‘ret’ may be used uninitialized in this function [-Wuninitialized] w+(mx6sabresd_spl,p2371-2180,ls2080aqds_SECURE_BOOT,vf610twr_nand,ls1043aqds,ls1043ardb,mx6slevk_spinor,p2571,ls1021atwr_sdcard_qspi,vf610twr,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,mx6sxsabresd_spl,mx6ul_14x14_evk,mx6slevk_spl,mx6slevk,mx6sxsabreauto,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,mx6sxsabresd,ls2080ardb,mx6qsabreauto,mx6dlsabresd,mx6qpsabreauto,mx6dlsabreauto,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,mx6ul_9x9_evk,e2220-1170,ls1043ardb_sdcard,ls1021atwr_qspi,ls1043aqds_sdcard_ifc,mx6qsabresd) ../drivers/mtd/spi/spi_flash.c:1043:13: warning: variable ‘ext_jedec’ set but not used [-Wunused-but-set-variable] w+(mx6sabresd_spl,p2371-2180,ls2080aqds_SECURE_BOOT,vf610twr_nand,ls1043aqds,ls1043ardb,mx6slevk_spinor,p2571,ls1021atwr_sdcard_qspi,vf610twr,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,mx6sxsabresd_spl,mx6ul_14x14_evk,mx6slevk_spl,mx6slevk,mx6sxsabreauto,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,mx6sxsabresd,ls2080ardb,mx6qsabreauto,mx6dlsabresd,mx6qpsabreauto,mx6dlsabreauto,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,mx6ul_9x9_evk,e2220-1170,ls1043ardb_sdcard,ls1021atwr_qspi,ls1043aqds_sdcard_ifc,mx6qsabresd) ../drivers/mtd/spi/spi_flash.c:1043:6: warning: variable ‘jedec’ set but not used [-Wunused-but-set-variable] w+(mx6sxsabresd_spl) ../drivers/mtd/spi/spi_flash.c:1045:6: warning: ‘ret’ may be used uninitialized in this function [-Wuninitialized] 15: sf: Simplify lock ops detection code 16: sf: sandbox: Fix ID exctract from spi_flash_info sandbox: sandbox_noblk sandbox_spl sandbox -(sandbox_noblk,sandbox_spl,sandbox) ../drivers/mtd/spi/sandbox.c: In function ‘sandbox_sf_xfer’: -(sandbox_noblk,sandbox_spl,sandbox) ../drivers/mtd/spi/sandbox.c:362:20: error: ‘const struct spi_flash_info’ has no member named ‘jedec’ -(sandbox_noblk,sandbox_spl,sandbox) make[2]: *** [drivers/mtd/spi/sandbox.o] Error 1 -(sandbox_noblk,sandbox_spl,sandbox) make[1]: *** [drivers/mtd/spi] Error 2 -(sandbox_noblk,sandbox_spl,sandbox) make: *** [sub-make] Error 2 17: sf: Cleanup spi_flash_info{} 18: sf: Cleanup sf_params 19: sf: nr_sectors -> n_sectors 20: sf: Add SPI_FLASH_MAX_ID_LEN 21: sf: Increase max id length by 1 byte 22: sf: Add INFO6 flash_info macro 23: sf: params: Add S25FS256S_64K spi flash support 24: sf: Remove legacy idcode detection code aarch64: ls2080aqds_SECURE_BOOT ls1043aqds ls1043ardb p2571 xilinx_zynqmp_ep evb-rk3399 ls2080ardb_SECURE_BOOT ls1043aqds_nand ls1043ardb_SECURE_BOOT ls1043aqds_lpuart ls1043ardb_nand ls2080aqds ls2080ardb p2371-0000 ls1043aqds_nor_ddr3 p2371-2180 xilinx_zynqmp_zc1751_xm016_dc2 e2220-1170 ls1043ardb_sdcard ls1043aqds_sdcard_ifc arm: mx6sabresd_spl vf610twr_nand mx6slevk_spinor ls1021atwr_sdcard_qspi vf610twr mx6ul_14x14_evk mx6slevk_spl mx6slevk mx6sxsabreauto mx6sxsabresd mx6qsabreauto mx6dlsabresd mx6qpsabreauto mx6dlsabreauto mx6ul_9x9_evk ls1021atwr_qspi mx6qsabresd -(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) u16 jedec, ext_jedec; -(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) ^ -(p2371-2180,ls2080aqds_SECURE_BOOT,ls1043aqds,ls1043ardb,p2571,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,ls2080ardb,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,e2220-1170,ls1043ardb_sdcard,ls1043aqds_sdcard_ifc) ^ w-(mx6sabresd_spl,p2371-2180,ls2080aqds_SECURE_BOOT,vf610twr_nand,ls1043aqds,ls1043ardb,mx6slevk_spinor,p2571,ls1021atwr_sdcard_qspi,vf610twr,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,mx6sxsabresd_spl,mx6ul_14x14_evk,mx6slevk_spl,mx6slevk,mx6sxsabreauto,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,mx6sxsabresd,ls2080ardb,mx6qsabreauto,mx6dlsabresd,mx6qpsabreauto,mx6dlsabreauto,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,mx6ul_9x9_evk,e2220-1170,ls1043ardb_sdcard,ls1021atwr_qspi,ls1043aqds_sdcard_ifc,mx6qsabresd) ../drivers/mtd/spi/spi_flash.c:1043:13: warning: variable ‘ext_jedec’ set but not used [-Wunused-but-set-variable] w-(mx6sabresd_spl,p2371-2180,ls2080aqds_SECURE_BOOT,vf610twr_nand,ls1043aqds,ls1043ardb,mx6slevk_spinor,p2571,ls1021atwr_sdcard_qspi,vf610twr,xilinx_zynqmp_ep,evb-rk3399,ls2080ardb_SECURE_BOOT,mx6sxsabresd_spl,mx6ul_14x14_evk,mx6slevk_spl,mx6slevk,mx6sxsabreauto,ls1043aqds_nand,ls1043ardb_SECURE_BOOT,ls1043aqds_lpuart,ls1043ardb_nand,ls2080aqds,mx6sxsabresd,ls2080ardb,mx6qsabreauto,mx6dlsabresd,mx6qpsabreauto,mx6dlsabreauto,p2371-0000,ls1043aqds_nor_ddr3,xilinx_zynqmp_zc1751_xm016_dc2,mx6ul_9x9_evk,e2220-1170,ls1043ardb_sdcard,ls1021atwr_qspi,ls1043aqds_sdcard_ifc,mx6qsabresd) ../drivers/mtd/spi/spi_flash.c:1043:6: warning: variable ‘jedec’ set but not used [-Wunused-but-set-variable] w-(mx6sxsabresd_spl) ../drivers/mtd/spi/spi_flash.c:1045:6: warning: ‘ret’ may be used uninitialized in this function [-Wuninitialized] w+(mx6sxsabresd_spl) ../drivers/mtd/spi/spi_flash.c:1006:6: warning: ‘ret’ may be used uninitialized in this function [-Wuninitialized] 25: sf: Remove non-meaningful comments 26: sf: Rename sf_params.c to spi_flash_ids 27: sf: ids: Use small letter's with flash name 28: sf: ids: Use small letter in ext_jedec 29: sf: Rename few local functions w-(mx6sxsabresd_spl) ../drivers/mtd/spi/spi_flash.c:1006:6: warning: ‘ret’ may be used uninitialized in this function [-Wuninitialized] w+(mx6sxsabresd_spl) ../drivers/mtd/spi/spi_flash.c:1005:6: warning: ‘ret’ may be used uninitialized in this function [-Wuninitialized] 30: spi: Remove dual flash code + exit 128 Build step 'Execute shell' marked build as failure
-------- Original Message -------- From: Jagan Teki jagannadh.teki@gmail.com Sent: Thursday, August 11, 2016 09:31 AM To: york sun york.sun@nxp.com Subject: Re: [PATCH v3 00/27] spi/sf: Updates on flash detection CC: Tom Rini trini@konsulko.com,u-boot@lists.denx.de,Simon Glass sjg@chromium.org,Bin Meng bmeng.cn@gmail.com,Vignesh R vigneshr@ti.com,Mugunthan V N mugunthanvnm@ti.com,Michal Simek michal.simek@xilinx.com,Siva Durga Prasad Paladugu sivadur@xilinx.com
On 11 August 2016 at 21:50, york sun york.sun@nxp.com wrote:
On 08/11/2016 09:17 AM, Jagan Teki wrote:
On 11 August 2016 at 20:47, york sun york.sun@nxp.com wrote:
On 08/11/2016 08:12 AM, york.sun@nxp.com wrote:
On 08/11/2016 01:15 AM, Jagan Teki wrote:
Tested on microzed and sandbox
Tested-by: Jagan Teki jteki@openedev.com
I've some host issues while running buildman, can anyone please run buildman?
I can compile for power and (limited) arm for you.
I can't compile test your v3 patch. They are not in mailing list, or patchwork. I only got some of them.
Ohh..look like these are not in patchwork, Tom any idea?
Jagan,
Maybe it takes time to show up in mailing list. It happened to me many times. Please send me the patches, or point me to your repository.
Please take the u-boot-spi/next [1]
[1] http://git.denx.de/?p=u-boot-spi.git;a=shortlog;h=refs/heads/next
-- Jagan.

On 12 August 2016 at 04:37, york sun york.sun@nxp.com wrote:
I saw some errors when compiling for arm. Compiling for power is still going.
Can you please try again?

Hi Bin,
On 12 August 2016 at 23:28, Jagan Teki jagannadh.teki@gmail.com wrote:
On 12 August 2016 at 04:37, york sun york.sun@nxp.com wrote:
I saw some errors when compiling for arm. Compiling for power is still going.
Can you please try again?
Please let me know in case if you find any buildman issues?

Hi Jagan,
On Mon, Aug 15, 2016 at 6:09 PM, Jagan Teki jagannadh.teki@gmail.com wrote:
Hi Bin,
On 12 August 2016 at 23:28, Jagan Teki jagannadh.teki@gmail.com wrote:
On 12 August 2016 at 04:37, york sun york.sun@nxp.com wrote:
I saw some errors when compiling for arm. Compiling for power is still going.
Can you please try again?
Please let me know in case if you find any buildman issues?
I am not sure why you can't run buildman yourself. You are the u-boot-spi maintainer and you need make sure every commit builds without any warnings or errors. Anyway, here are some logs:
+../drivers/spi/atmel_spi.c:17:31: error: asm/arch/at91_spi.h: No such file or directory +../drivers/spi/atmel_spi.c:18:22: error: asm/gpio.h: No such file or directory +make[2]: *** [drivers/spi/atmel_spi.o] Error 1 +make[1]: *** [drivers/spi] Error 2
+ ext_jedec = idcode[3] << 8 | idcode[4]; + if (idcode[0] == SPI_FLASH_CFI_MFR_ATMEL || + ^ + jedec = idcode[1] << 8 | idcode[2]; + ^ + ^ + ^ +../drivers/mtd/spi/spi_flash.c: In function ‘spi_flash_scan’: +../drivers/mtd/spi/spi_flash.c:1088: warning: ‘idcode[0]’ may be used uninitialized in this function +../drivers/mtd/spi/spi_flash.c:1049: warning: ‘idcode[4]’ may be used uninitialized in this function +../drivers/mtd/spi/spi_flash.c:1049: warning: ‘idcode[3]’ may be used uninitialized in this function +../drivers/mtd/spi/spi_flash.c:1048: warning: ‘idcode[2]’ may be used uninitialized in this function +../drivers/mtd/spi/spi_flash.c:1048: warning: ‘idcode[1]’ may be used uninitialized in this function +../drivers/mtd/spi/spi_flash.c:1042: warning: ‘ret’ may be used uninitialized in this function + int ret; + ^ +../drivers/mtd/spi/spi_flash.c: In function 'spi_flash_scan': +../drivers/mtd/spi/spi_flash.c:1088: warning: 'idcode[0]' is used uninitialized in this function +../drivers/mtd/spi/spi_flash.c:1049: warning: 'idcode[4]' is used uninitialized in this function +../drivers/mtd/spi/spi_flash.c:1049: warning: 'idcode[3]' is used uninitialized in this function +../drivers/mtd/spi/spi_flash.c:1048: warning: 'idcode[2]' is used uninitialized in this function +../drivers/mtd/spi/spi_flash.c:1048: warning: 'idcode[1]' is used uninitialized in this function +../drivers/mtd/spi/spi_flash.c:1042: warning: 'ret' may be used uninitialized in this function
w+../drivers/mtd/spi/spi_flash.c:1043:13: warning: variable 'ext_jedec' set but not used [-Wunused-but-set-variable] w+../drivers/mtd/spi/spi_flash.c:1043:6: warning: variable 'jedec' set but not used [-Wunused-but-set-variable] w+../drivers/mtd/spi/spi_flash.c:1045:6: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
Regards, Bin

Hi Bin,
On 16 August 2016 at 06:55, Bin Meng bmeng.cn@gmail.com wrote:
Hi Jagan,
On Mon, Aug 15, 2016 at 6:09 PM, Jagan Teki jagannadh.teki@gmail.com wrote:
Hi Bin,
On 12 August 2016 at 23:28, Jagan Teki jagannadh.teki@gmail.com wrote:
On 12 August 2016 at 04:37, york sun york.sun@nxp.com wrote:
I saw some errors when compiling for arm. Compiling for power is still going.
Can you please try again?
Please let me know in case if you find any buildman issues?
I am not sure why you can't run buildman yourself. You are the u-boot-spi maintainer and you need make sure every commit builds without any warnings or errors. Anyway, here are some logs:
Thanks for running buildman, Since I've an issue on my host with overheating issues, I couldn't able to run buildman - reported the same on previous mail. Anyway I will run it from my end once host fixed.
thanks!

Sorry I am out of office this week.
York
-------- Original Message -------- From: Jagan Teki jagannadh.teki@gmail.com Sent: Friday, August 12, 2016 11:58 AM To: york sun york.sun@nxp.com Subject: Re: [PATCH v3 00/27] spi/sf: Updates on flash detection CC: Tom Rini trini@konsulko.com,u-boot@lists.denx.de,sjg@chromium.org,bmeng.cn@gmail.com,vigneshr@ti.com,mugunthanvnm@ti.com,michal.simek@xilinx.com,sivadur@xilinx.com
On 12 August 2016 at 04:37, york sun york.sun@nxp.com wrote:
I saw some errors when compiling for arm. Compiling for power is still going.
Can you please try again?
-- Jagan.

On Thu, Aug 11, 2016 at 09:47:44PM +0530, Jagan Teki wrote:
On 11 August 2016 at 20:47, york sun york.sun@nxp.com wrote:
On 08/11/2016 08:12 AM, york.sun@nxp.com wrote:
On 08/11/2016 01:15 AM, Jagan Teki wrote:
Tested on microzed and sandbox
Tested-by: Jagan Teki jteki@openedev.com
I've some host issues while running buildman, can anyone please run buildman?
I can compile for power and (limited) arm for you.
I can't compile test your v3 patch. They are not in mailing list, or patchwork. I only got some of them.
Ohh..look like these are not in patchwork, Tom any idea?
They don't appear in the mail archives right now either. Wolfgang?
participants (4)
-
Bin Meng
-
Jagan Teki
-
Tom Rini
-
york sun