[U-Boot] [PATCH] cmd editing: optimize/shrink output blanking

No need to output spaces 1 char at a time in a loop when the printf code can do the same thing with the right format string. This shrinks things and gives a nice speed up when killing off lines more than a byte or two as printf will send out the buffer in one big chunk.
Signed-off-by: Mike Frysinger vapier@gentoo.org --- common/main.c | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/common/main.c b/common/main.c index 20090ee..40617f5 100644 --- a/common/main.c +++ b/common/main.c @@ -643,12 +643,10 @@ static void cread_print_hist_list(void)
#define ERASE_TO_EOL() { \ if (num < eol_num) { \ - int tmp; \ - for (tmp = num; tmp < eol_num; tmp++) \ - getcmd_putch(' '); \ - while (tmp-- > num) \ + printf("%*s", (int)(eol_num - num), ""); \ + do { \ getcmd_putch(CTL_BACKSPACE); \ - eol_num = num; \ + } while (--eol_num > num); \ } \ }

Dear Mike Frysinger,
In message 1279877295-4823-1-git-send-email-vapier@gentoo.org you wrote:
No need to output spaces 1 char at a time in a loop when the printf code can do the same thing with the right format string. This shrinks things and gives a nice speed up when killing off lines more than a byte or two as printf will send out the buffer in one big chunk.
Signed-off-by: Mike Frysinger vapier@gentoo.org
common/main.c | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
participants (2)
-
Mike Frysinger
-
Wolfgang Denk