[U-Boot] [PATCH 0/8] spi: Mark non-dm spi drivers as BROKEN
We have trigger a zap patches about the legacy spi driver which are not converted into dm, but the seems like most of the associated developers are unaware about the migration plan for SPI.
So, as per Tom request and make the removal smooth mark these non-dm drivers into BROKEN. The configs which enabled these drivers are now getting warnings saying that the resulting .config has broken config enabled and more over the code associated with these configs will be removed in v2019.07 release.
Any inputs? Jagan.
Jagan Teki (8): Kconfig: Update CONFIG_BROKEN help text Makefile: Trigger a Warning if BROKEN defined Makefile: Trigger a warning for legcay spi drivers spi: Kconfig: Mark MXS_SPI has BROKEN spi: Kconfig: Mark SH_SPI has BROKEN spi: Kconfig: Mark SOFT_SPI has BROKEN spi: Kconfig: Mark FSL_ESPI has BROKEN spi: Kconfig: Mark LPC32XX_SSP has BROKEN
Kconfig | 7 ++++++- Makefile | 19 ++++++++----------- drivers/spi/Kconfig | 5 +++++ 3 files changed, 19 insertions(+), 12 deletions(-)
Add bool text to describe what configurations is this for.
Update help text to describe the example use-case configs which comes under CONFIG_BROKEN, they are - legacy driver that would need dm conversion. - legacy driver that doesn't have proper update since from the releases.
Cc: Heinrich Schuchardt xypron.glpk@gmx.de Signed-off-by: Jagan Teki jagan@amarulasolutions.com --- Kconfig | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/Kconfig b/Kconfig index 7a5491bd67..eb3c2d04d3 100644 --- a/Kconfig +++ b/Kconfig @@ -15,11 +15,16 @@ source "arch/Kconfig" menu "General setup"
config BROKEN - bool + bool "Broken configuration" help This option cannot be enabled. It is used as dependency for broken and incomplete features.
+ These broken configurations may comes under, + - legacy driver that would need dm conversion. + - legacy driver that doesn't have proper update since + from the releases. + config LOCALVERSION string "Local version - append to U-Boot release" help
On 4/28/19 10:47 PM, Jagan Teki wrote:
Add bool text to describe what configurations is this for.
Update help text to describe the example use-case configs which comes under CONFIG_BROKEN, they are
- legacy driver that would need dm conversion.
- legacy driver that doesn't have proper update since from the releases.
Cc: Heinrich Schuchardt xypron.glpk@gmx.de Signed-off-by: Jagan Teki jagan@amarulasolutions.com
Kconfig | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/Kconfig b/Kconfig index 7a5491bd67..eb3c2d04d3 100644 --- a/Kconfig +++ b/Kconfig @@ -15,11 +15,16 @@ source "arch/Kconfig" menu "General setup"
config BROKEN
- bool
bool "Broken configuration" help This option cannot be enabled. It is used as dependency for broken and incomplete features.
These broken configurations may comes under,
Thanks for adding clarification. I suggest to rewrite it as:
This dependency is assigned to
- legacy drivers requiring driver model conversion - legacy drivers lacking maintenance
Best regards
Heinrich
- legacy driver that would need dm conversion.- legacy driver that doesn't have proper update sincefrom the releases.- config LOCALVERSION string "Local version - append to U-Boot release" help
If configured target has broken config enabled, trigger a warning saying that the desired .config has broken configuration.
Cc: Heinrich Schuchardt xypron.glpk@gmx.de Signed-off-by: Jagan Teki jagan@amarulasolutions.com --- Makefile | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/Makefile b/Makefile index 66a09ac900..02c9a73d33 100644 --- a/Makefile +++ b/Makefile @@ -918,6 +918,9 @@ cmd_cfgcheck = $(srctree)/scripts/check-config.sh $2 \ $(srctree)/scripts/config_whitelist.txt $(srctree)
all: $(ALL-y) +ifeq ($(CONFIG_BROKEN),y) + $(warning "You have broken configuration in your .config! Please check your configuration.") +endif # broken ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) @echo >&2 "===================== WARNING ======================" @echo >&2 "This board uses CONFIG_DM_I2C_COMPAT. Please remove"
On 4/28/19 10:47 PM, Jagan Teki wrote:
If configured target has broken config enabled, trigger a warning saying that the desired .config has broken configuration.
Cc: Heinrich Schuchardt xypron.glpk@gmx.de Signed-off-by: Jagan Teki jagan@amarulasolutions.com
Makefile | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/Makefile b/Makefile index 66a09ac900..02c9a73d33 100644 --- a/Makefile +++ b/Makefile @@ -918,6 +918,9 @@ cmd_cfgcheck = $(srctree)/scripts/check-config.sh $2 \ $(srctree)/scripts/config_whitelist.txt $(srctree)
all: $(ALL-y) +ifeq ($(CONFIG_BROKEN),y)
- $(warning "You have broken configuration in your .config! Please check your configuration.")
- $(warning "Your .config file selects a feature marked as broken.
Please check your configuration.")
Regards
Heinrich
+endif # broken ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) @echo >&2 "===================== WARNING ======================" @echo >&2 "This board uses CONFIG_DM_I2C_COMPAT. Please remove"
We have a warning text for non dm converted spi drivers, but the plan is to mark all these respetive drivers into CONFIG_BROKEN.
So, trigger a warning saying that these driver configurations and associated code will remove in v2019.07 (earlier plan is to remove it from v2019.04)
Signed-off-by: Jagan Teki jagan@amarulasolutions.com --- Makefile | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/Makefile b/Makefile index 02c9a73d33..4971f211ff 100644 --- a/Makefile +++ b/Makefile @@ -920,6 +920,11 @@ cmd_cfgcheck = $(srctree)/scripts/check-config.sh $2 \ all: $(ALL-y) ifeq ($(CONFIG_BROKEN),y) $(warning "You have broken configuration in your .config! Please check your configuration.") +ifeq ($(CONFIG_SPI),y) +ifneq ($(CONFIG_DM_SPI)$(CONFIG_OF_CONTROL),yy) + $(warning "The relevant config item with associated code will remove in v2019.07 release.") +endif +endif endif # broken ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) @echo >&2 "===================== WARNING ======================" @@ -997,17 +1002,6 @@ ifeq ($(CONFIG_OF_EMBED),y) @echo >&2 "See doc/README.fdt-control for more info." @echo >&2 "====================================================" endif -ifeq ($(CONFIG_SPI),y) -ifneq ($(CONFIG_DM_SPI)$(CONFIG_OF_CONTROL),yy) - @echo >&2 "===================== WARNING ======================" - @echo >&2 "This board does not use CONFIG_DM_SPI. Please update" - @echo >&2 "the board before v2019.04 for no dm conversion" - @echo >&2 "and v2019.07 for partially dm converted drivers." - @echo >&2 "Failure to update can lead to driver/board removal" - @echo >&2 "See doc/driver-model/MIGRATION.txt for more info." - @echo >&2 "====================================================" -endif -endif ifeq ($(CONFIG_SPI_FLASH),y) ifneq ($(CONFIG_DM_SPI_FLASH)$(CONFIG_OF_CONTROL),yy) @echo >&2 "===================== WARNING ======================"
Mark MXS_SPI has BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.
Cc: Marek Vasut marex@denx.de Cc: Fabio Estevam fabio.estevam@nxp.com Cc: Michael Trimarchi michael@amarulasolutions.com Signed-off-by: Jagan Teki jagan@amarulasolutions.com --- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index e196f64e2f..393382fee2 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -377,6 +377,7 @@ config MXC_SPI
config MXS_SPI bool "MXS SPI Driver" + select BROKEN help Enable the MXS SPI controller driver. This driver can be used on the i.MX23 and i.MX28 SoCs.
On 4/28/19 10:47 PM, Jagan Teki wrote:
Mark MXS_SPI has BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.
But the code is not broken, it works fine, right ?
Cc: Marek Vasut marex@denx.de Cc: Fabio Estevam fabio.estevam@nxp.com Cc: Michael Trimarchi michael@amarulasolutions.com Signed-off-by: Jagan Teki jagan@amarulasolutions.com
drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index e196f64e2f..393382fee2 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -377,6 +377,7 @@ config MXC_SPI
config MXS_SPI bool "MXS SPI Driver"
- select BROKEN help Enable the MXS SPI controller driver. This driver can be used on the i.MX23 and i.MX28 SoCs.
On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut marex@denx.de wrote:
On 4/28/19 10:47 PM, Jagan Teki wrote:
Mark MXS_SPI has BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.
But the code is not broken, it works fine, right ?
Yes the code work fine, but dm conversion not done yet. Now the CONFIG_BROKEN can mark the driver configs which doesn't convert dm yet, so the associated code will drop wrt MIGRATION deadline (similar like what we showed on the Makefile before).
It is something like caution, before dropping it as suggested Tom.
On 4/29/19 12:40 PM, Jagan Teki wrote:
On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut marex@denx.de wrote:
On 4/28/19 10:47 PM, Jagan Teki wrote:
Mark MXS_SPI has BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.
But the code is not broken, it works fine, right ?
Yes the code work fine, but dm conversion not done yet. Now the CONFIG_BROKEN can mark the driver configs which doesn't convert dm
That makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
yet, so the associated code will drop wrt MIGRATION deadline (similar like what we showed on the Makefile before).
It is something like caution, before dropping it as suggested Tom.
On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut marex@denx.de wrote:
On 4/29/19 12:40 PM, Jagan Teki wrote:
On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut marex@denx.de wrote:
On 4/28/19 10:47 PM, Jagan Teki wrote:
Mark MXS_SPI has BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.
But the code is not broken, it works fine, right ?
Yes the code work fine, but dm conversion not done yet. Now the CONFIG_BROKEN can mark the driver configs which doesn't convert dm
That makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
On 4/29/19 1:02 PM, Jagan Teki wrote:
On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut marex@denx.de wrote:
On 4/29/19 12:40 PM, Jagan Teki wrote:
On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut marex@denx.de wrote:
On 4/28/19 10:47 PM, Jagan Teki wrote:
Mark MXS_SPI has BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.
But the code is not broken, it works fine, right ?
Yes the code work fine, but dm conversion not done yet. Now the CONFIG_BROKEN can mark the driver configs which doesn't convert dm
That makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload CONFIG_BROKEN for such things. The Makefile warning seems sufficient to me.
On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote:
On 4/29/19 1:02 PM, Jagan Teki wrote:
On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut marex@denx.de wrote:
On 4/29/19 12:40 PM, Jagan Teki wrote:
On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut marex@denx.de wrote:
On 4/28/19 10:47 PM, Jagan Teki wrote:
Mark MXS_SPI has BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.
But the code is not broken, it works fine, right ?
Yes the code work fine, but dm conversion not done yet. Now the CONFIG_BROKEN can mark the driver configs which doesn't convert dm
That makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload CONFIG_BROKEN for such things. The Makefile warning seems sufficient to me.
The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN.
The Makefile warnings tell people the code is going to be removed and I'm trying to have the window be: 1) LOUD warning about needing work 2) 1 release past those loud deadlines of the code there, but not built unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken) 3) Code removed.
All that said, I continue to be open to delaying conversion / removal if we're having: - A discussion and proposed patches to do the conversion, but people need more time. The work is in progress, but people need time as it's not as easy to convert as hoped for various reasons. - A problem converting the driver to DM as it's highlighting some other problem within DM or hitting a size constraint or other problem. - Someone who is willing to do the DM work is just now seeing this. Yes, this is possible especially since our LOUD Makefile warnings are also easy enough to miss if you're just automating the build and not doing it manually.
But I am not fine with: - Code that isn't converted AND - Code that no one seems to be converting AND - Code that no one says they are going to convert AND - The conversion deadline has past.
On 4/29/19 1:24 PM, Tom Rini wrote:
On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote:
On 4/29/19 1:02 PM, Jagan Teki wrote:
On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut marex@denx.de wrote:
On 4/29/19 12:40 PM, Jagan Teki wrote:
On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut marex@denx.de wrote:
On 4/28/19 10:47 PM, Jagan Teki wrote: > Mark MXS_SPI has BROKEN, this so the resulting build shows > warning for broken configuration enabled and associated code > will remove in v2019.07 release.
But the code is not broken, it works fine, right ?
Yes the code work fine, but dm conversion not done yet. Now the CONFIG_BROKEN can mark the driver configs which doesn't convert dm
That makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload CONFIG_BROKEN for such things. The Makefile warning seems sufficient to me.
The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN.
The Makefile warnings tell people the code is going to be removed and I'm trying to have the window be:
- LOUD warning about needing work
- 1 release past those loud deadlines of the code there, but not built
unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken) 3) Code removed.
All that said, I continue to be open to delaying conversion / removal if we're having:
- A discussion and proposed patches to do the conversion, but people need more time. The work is in progress, but people need time as it's not as easy to convert as hoped for various reasons.
- A problem converting the driver to DM as it's highlighting some other problem within DM or hitting a size constraint or other problem.
- Someone who is willing to do the DM work is just now seeing this. Yes, this is possible especially since our LOUD Makefile warnings are also easy enough to miss if you're just automating the build and not doing it manually.
But I am not fine with:
- Code that isn't converted AND
- Code that no one seems to be converting AND
- Code that no one says they are going to convert AND
- The conversion deadline has past.
Seems there was some offer from Amarula to convert it , no ?
Hi Marek
On Mon, Apr 29, 2019 at 1:27 PM Marek Vasut marex@denx.de wrote:
On 4/29/19 1:24 PM, Tom Rini wrote:
On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote:
On 4/29/19 1:02 PM, Jagan Teki wrote:
On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut marex@denx.de wrote:
On 4/29/19 12:40 PM, Jagan Teki wrote:
On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut marex@denx.de wrote: > > On 4/28/19 10:47 PM, Jagan Teki wrote: >> Mark MXS_SPI has BROKEN, this so the resulting build shows >> warning for broken configuration enabled and associated code >> will remove in v2019.07 release. > > But the code is not broken, it works fine, right ?
Yes the code work fine, but dm conversion not done yet. Now the CONFIG_BROKEN can mark the driver configs which doesn't convert dm
That makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload CONFIG_BROKEN for such things. The Makefile warning seems sufficient to me.
The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN.
The Makefile warnings tell people the code is going to be removed and I'm trying to have the window be:
- LOUD warning about needing work
- 1 release past those loud deadlines of the code there, but not built
unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken) 3) Code removed.
All that said, I continue to be open to delaying conversion / removal if we're having:
- A discussion and proposed patches to do the conversion, but people need more time. The work is in progress, but people need time as it's not as easy to convert as hoped for various reasons.
- A problem converting the driver to DM as it's highlighting some other problem within DM or hitting a size constraint or other problem.
- Someone who is willing to do the DM work is just now seeing this. Yes, this is possible especially since our LOUD Makefile warnings are also easy enough to miss if you're just automating the build and not doing it manually.
But I am not fine with:
- Code that isn't converted AND
- Code that no one seems to be converting AND
- Code that no one says they are going to convert AND
- The conversion deadline has past.
Seems there was some offer from Amarula to convert it , no ?
we can do some job on imx28 because we have a board there. I have asked to mainline it
Michael
-- Best regards, Marek Vasut
On Mon, Apr 29, 2019 at 02:34:32PM +0200, Michael Nazzareno Trimarchi wrote:
Hi Marek
On Mon, Apr 29, 2019 at 1:27 PM Marek Vasut marex@denx.de wrote:
On 4/29/19 1:24 PM, Tom Rini wrote:
On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote:
On 4/29/19 1:02 PM, Jagan Teki wrote:
On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut marex@denx.de wrote:
On 4/29/19 12:40 PM, Jagan Teki wrote: > On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut marex@denx.de wrote: >> >> On 4/28/19 10:47 PM, Jagan Teki wrote: >>> Mark MXS_SPI has BROKEN, this so the resulting build shows >>> warning for broken configuration enabled and associated code >>> will remove in v2019.07 release. >> >> But the code is not broken, it works fine, right ? > > Yes the code work fine, but dm conversion not done yet. Now the > CONFIG_BROKEN can mark the driver configs which doesn't convert dm
That makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload CONFIG_BROKEN for such things. The Makefile warning seems sufficient to me.
The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN.
The Makefile warnings tell people the code is going to be removed and I'm trying to have the window be:
- LOUD warning about needing work
- 1 release past those loud deadlines of the code there, but not built
unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken) 3) Code removed.
All that said, I continue to be open to delaying conversion / removal if we're having:
- A discussion and proposed patches to do the conversion, but people need more time. The work is in progress, but people need time as it's not as easy to convert as hoped for various reasons.
- A problem converting the driver to DM as it's highlighting some other problem within DM or hitting a size constraint or other problem.
- Someone who is willing to do the DM work is just now seeing this. Yes, this is possible especially since our LOUD Makefile warnings are also easy enough to miss if you're just automating the build and not doing it manually.
But I am not fine with:
- Code that isn't converted AND
- Code that no one seems to be converting AND
- Code that no one says they are going to convert AND
- The conversion deadline has past.
Seems there was some offer from Amarula to convert it , no ?
we can do some job on imx28 because we have a board there. I have asked to mainline it
OK, good. Can you and Marek please coordinate on: - Updating MAINTAINERS files - Dropping the boards that won't be supported moving forward (even if you can't mainline the custom board, there must be a ref platform you have/use, yes?).
And Michael, can you please subscribe to the u-boot-maintainers list?
Jagan, was there an old patch to try and convert this driver that may be of help to Michael? Thanks!
On 4/29/19 2:47 PM, Tom Rini wrote:
On Mon, Apr 29, 2019 at 02:34:32PM +0200, Michael Nazzareno Trimarchi wrote:
Hi Marek
On Mon, Apr 29, 2019 at 1:27 PM Marek Vasut marex@denx.de wrote:
On 4/29/19 1:24 PM, Tom Rini wrote:
On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote:
On 4/29/19 1:02 PM, Jagan Teki wrote:
On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut marex@denx.de wrote: > > On 4/29/19 12:40 PM, Jagan Teki wrote: >> On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut marex@denx.de wrote: >>> >>> On 4/28/19 10:47 PM, Jagan Teki wrote: >>>> Mark MXS_SPI has BROKEN, this so the resulting build shows >>>> warning for broken configuration enabled and associated code >>>> will remove in v2019.07 release. >>> >>> But the code is not broken, it works fine, right ? >> >> Yes the code work fine, but dm conversion not done yet. Now the >> CONFIG_BROKEN can mark the driver configs which doesn't convert dm > > That makes no sense, if the code works, it works and thus it is NOT > broken. Find some other way to flag it as non-DM-converted, not this hack.
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload CONFIG_BROKEN for such things. The Makefile warning seems sufficient to me.
The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN.
The Makefile warnings tell people the code is going to be removed and I'm trying to have the window be:
- LOUD warning about needing work
- 1 release past those loud deadlines of the code there, but not built
unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken) 3) Code removed.
All that said, I continue to be open to delaying conversion / removal if we're having:
- A discussion and proposed patches to do the conversion, but people need more time. The work is in progress, but people need time as it's not as easy to convert as hoped for various reasons.
- A problem converting the driver to DM as it's highlighting some other problem within DM or hitting a size constraint or other problem.
- Someone who is willing to do the DM work is just now seeing this. Yes, this is possible especially since our LOUD Makefile warnings are also easy enough to miss if you're just automating the build and not doing it manually.
But I am not fine with:
- Code that isn't converted AND
- Code that no one seems to be converting AND
- Code that no one says they are going to convert AND
- The conversion deadline has past.
Seems there was some offer from Amarula to convert it , no ?
we can do some job on imx28 because we have a board there. I have asked to mainline it
OK, good. Can you and Marek please coordinate on:
- Updating MAINTAINERS files
- Dropping the boards that won't be supported moving forward (even if you can't mainline the custom board, there must be a ref platform you have/use, yes?).
Might make sense to keep the MX28EVK, I'll ask about the other boards, but I think they could be dropped.
And Michael, can you please subscribe to the u-boot-maintainers list?
Jagan, was there an old patch to try and convert this driver that may be of help to Michael? Thanks!
+ Akash
On Mon, Apr 29, 2019 at 6:17 PM Tom Rini trini@konsulko.com wrote:
On Mon, Apr 29, 2019 at 02:34:32PM +0200, Michael Nazzareno Trimarchi wrote:
Hi Marek
On Mon, Apr 29, 2019 at 1:27 PM Marek Vasut marex@denx.de wrote:
On 4/29/19 1:24 PM, Tom Rini wrote:
On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote:
On 4/29/19 1:02 PM, Jagan Teki wrote:
On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut marex@denx.de wrote: > > On 4/29/19 12:40 PM, Jagan Teki wrote: >> On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut marex@denx.de wrote: >>> >>> On 4/28/19 10:47 PM, Jagan Teki wrote: >>>> Mark MXS_SPI has BROKEN, this so the resulting build shows >>>> warning for broken configuration enabled and associated code >>>> will remove in v2019.07 release. >>> >>> But the code is not broken, it works fine, right ? >> >> Yes the code work fine, but dm conversion not done yet. Now the >> CONFIG_BROKEN can mark the driver configs which doesn't convert dm > > That makes no sense, if the code works, it works and thus it is NOT > broken. Find some other way to flag it as non-DM-converted, not this hack.
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload CONFIG_BROKEN for such things. The Makefile warning seems sufficient to me.
The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN.
The Makefile warnings tell people the code is going to be removed and I'm trying to have the window be:
- LOUD warning about needing work
- 1 release past those loud deadlines of the code there, but not built
unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken) 3) Code removed.
All that said, I continue to be open to delaying conversion / removal if we're having:
- A discussion and proposed patches to do the conversion, but people need more time. The work is in progress, but people need time as it's not as easy to convert as hoped for various reasons.
- A problem converting the driver to DM as it's highlighting some other problem within DM or hitting a size constraint or other problem.
- Someone who is willing to do the DM work is just now seeing this. Yes, this is possible especially since our LOUD Makefile warnings are also easy enough to miss if you're just automating the build and not doing it manually.
But I am not fine with:
- Code that isn't converted AND
- Code that no one seems to be converting AND
- Code that no one says they are going to convert AND
- The conversion deadline has past.
Seems there was some offer from Amarula to convert it , no ?
we can do some job on imx28 because we have a board there. I have asked to mainline it
OK, good. Can you and Marek please coordinate on:
- Updating MAINTAINERS files
- Dropping the boards that won't be supported moving forward (even if you can't mainline the custom board, there must be a ref platform you have/use, yes?).
And Michael, can you please subscribe to the u-boot-maintainers list?
Jagan, was there an old patch to try and convert this driver that may be of help to Michael? Thanks!
I have asked previous version[1] author, Akash. He said he is going to send the next version. He don't have hardware to test, but Michael or someone can test his change, thanks.
On Mon, Apr 29, 2019 at 4:54 PM Tom Rini trini@konsulko.com wrote:
On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote:
On 4/29/19 1:02 PM, Jagan Teki wrote:
On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut marex@denx.de wrote:
On 4/29/19 12:40 PM, Jagan Teki wrote:
On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut marex@denx.de wrote:
On 4/28/19 10:47 PM, Jagan Teki wrote: > Mark MXS_SPI has BROKEN, this so the resulting build shows > warning for broken configuration enabled and associated code > will remove in v2019.07 release.
But the code is not broken, it works fine, right ?
Yes the code work fine, but dm conversion not done yet. Now the CONFIG_BROKEN can mark the driver configs which doesn't convert dm
That makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload CONFIG_BROKEN for such things. The Makefile warning seems sufficient to me.
The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN.
Yes, the idea here is to build the broken one by selecting BROKEN so-that the travis-CI is green and have warning on the build, otherwise it is another rework of selecting BROKEN for those non-converted drivers if they depends.
The Makefile warnings tell people the code is going to be removed and I'm trying to have the window be:
- LOUD warning about needing work
- 1 release past those loud deadlines of the code there, but not built
unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken) 3) Code removed.
ie what this series does. Driver (for example) will select BROKEN, that means it is still working bu would like to remove in next versions and so..
On Tue, May 14, 2019 at 07:46:06PM +0530, Jagan Teki wrote:
On Mon, Apr 29, 2019 at 4:54 PM Tom Rini trini@konsulko.com wrote:
On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote:
On 4/29/19 1:02 PM, Jagan Teki wrote:
On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut marex@denx.de wrote:
On 4/29/19 12:40 PM, Jagan Teki wrote:
On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut marex@denx.de wrote: > > On 4/28/19 10:47 PM, Jagan Teki wrote: >> Mark MXS_SPI has BROKEN, this so the resulting build shows >> warning for broken configuration enabled and associated code >> will remove in v2019.07 release. > > But the code is not broken, it works fine, right ?
Yes the code work fine, but dm conversion not done yet. Now the CONFIG_BROKEN can mark the driver configs which doesn't convert dm
That makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload CONFIG_BROKEN for such things. The Makefile warning seems sufficient to me.
The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN.
Yes, the idea here is to build the broken one by selecting BROKEN so-that the travis-CI is green and have warning on the build, otherwise it is another rework of selecting BROKEN for those non-converted drivers if they depends.
The Makefile warnings tell people the code is going to be removed and I'm trying to have the window be:
- LOUD warning about needing work
- 1 release past those loud deadlines of the code there, but not built
unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken) 3) Code removed.
ie what this series does. Driver (for example) will select BROKEN, that means it is still working bu would like to remove in next versions and so..
What I'm after is https://github.com/trini/u-boot/commits/WIP-BROKEN-test which is close, but not quite there. We no longer build the drivers marked as BROKEN by default, and the fallout from that has been: - Some missing dependencies (I'm trying to fix that now) leading to build problems. - Needing to yank CONFIG_SPI for example from configs that had been using a now-not-built driver as the subsystem fails to link if there's no controller. I don't think that's a problem however. - Needing to migrate a few more symbols to Kconfig in order to be able to properly express "You need to depend on BROKEN to use this option now".
On 5/14/19 4:45 PM, Tom Rini wrote:
On Tue, May 14, 2019 at 07:46:06PM +0530, Jagan Teki wrote:
On Mon, Apr 29, 2019 at 4:54 PM Tom Rini trini@konsulko.com wrote:
On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote:
On 4/29/19 1:02 PM, Jagan Teki wrote:
On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut marex@denx.de wrote:
On 4/29/19 12:40 PM, Jagan Teki wrote: > On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut marex@denx.de wrote: >> >> On 4/28/19 10:47 PM, Jagan Teki wrote: >>> Mark MXS_SPI has BROKEN, this so the resulting build shows >>> warning for broken configuration enabled and associated code >>> will remove in v2019.07 release. >> >> But the code is not broken, it works fine, right ? > > Yes the code work fine, but dm conversion not done yet. Now the > CONFIG_BROKEN can mark the driver configs which doesn't convert dm
That makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload CONFIG_BROKEN for such things. The Makefile warning seems sufficient to me.
The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN.
Yes, the idea here is to build the broken one by selecting BROKEN so-that the travis-CI is green and have warning on the build, otherwise it is another rework of selecting BROKEN for those non-converted drivers if they depends.
The Makefile warnings tell people the code is going to be removed and I'm trying to have the window be:
- LOUD warning about needing work
- 1 release past those loud deadlines of the code there, but not built
unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken) 3) Code removed.
ie what this series does. Driver (for example) will select BROKEN, that means it is still working bu would like to remove in next versions and so..
What I'm after is https://github.com/trini/u-boot/commits/WIP-BROKEN-test which is close, but not quite there. We no longer build the drivers marked as BROKEN by default, and the fallout from that has been:
- Some missing dependencies (I'm trying to fix that now) leading to build problems.
- Needing to yank CONFIG_SPI for example from configs that had been using a now-not-built driver as the subsystem fails to link if there's no controller. I don't think that's a problem however.
- Needing to migrate a few more symbols to Kconfig in order to be able to properly express "You need to depend on BROKEN to use this option now".
I still disagree with marking drivers that need DM conversion, but are otherwise working perfectly fine, as broken. That's just misleading and in fact incorrect. Invent some new, more descriptive Kconfig option please.
On Tue, May 14, 2019 at 07:33:17PM +0200, Marek Vasut wrote:
On 5/14/19 4:45 PM, Tom Rini wrote:
On Tue, May 14, 2019 at 07:46:06PM +0530, Jagan Teki wrote:
On Mon, Apr 29, 2019 at 4:54 PM Tom Rini trini@konsulko.com wrote:
On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote:
On 4/29/19 1:02 PM, Jagan Teki wrote:
On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut marex@denx.de wrote: > > On 4/29/19 12:40 PM, Jagan Teki wrote: >> On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut marex@denx.de wrote: >>> >>> On 4/28/19 10:47 PM, Jagan Teki wrote: >>>> Mark MXS_SPI has BROKEN, this so the resulting build shows >>>> warning for broken configuration enabled and associated code >>>> will remove in v2019.07 release. >>> >>> But the code is not broken, it works fine, right ? >> >> Yes the code work fine, but dm conversion not done yet. Now the >> CONFIG_BROKEN can mark the driver configs which doesn't convert dm > > That makes no sense, if the code works, it works and thus it is NOT > broken. Find some other way to flag it as non-DM-converted, not this hack.
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload CONFIG_BROKEN for such things. The Makefile warning seems sufficient to me.
The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN.
Yes, the idea here is to build the broken one by selecting BROKEN so-that the travis-CI is green and have warning on the build, otherwise it is another rework of selecting BROKEN for those non-converted drivers if they depends.
The Makefile warnings tell people the code is going to be removed and I'm trying to have the window be:
- LOUD warning about needing work
- 1 release past those loud deadlines of the code there, but not built
unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken) 3) Code removed.
ie what this series does. Driver (for example) will select BROKEN, that means it is still working bu would like to remove in next versions and so..
What I'm after is https://github.com/trini/u-boot/commits/WIP-BROKEN-test which is close, but not quite there. We no longer build the drivers marked as BROKEN by default, and the fallout from that has been:
- Some missing dependencies (I'm trying to fix that now) leading to build problems.
- Needing to yank CONFIG_SPI for example from configs that had been using a now-not-built driver as the subsystem fails to link if there's no controller. I don't think that's a problem however.
- Needing to migrate a few more symbols to Kconfig in order to be able to properly express "You need to depend on BROKEN to use this option now".
I still disagree with marking drivers that need DM conversion, but are otherwise working perfectly fine, as broken. That's just misleading and in fact incorrect. Invent some new, more descriptive Kconfig option please.
I also still disagree, but, fine, I'll add CONFIG_DEPRECATED.
On 5/14/19 7:37 PM, Tom Rini wrote:
On Tue, May 14, 2019 at 07:33:17PM +0200, Marek Vasut wrote:
On 5/14/19 4:45 PM, Tom Rini wrote:
On Tue, May 14, 2019 at 07:46:06PM +0530, Jagan Teki wrote:
On Mon, Apr 29, 2019 at 4:54 PM Tom Rini trini@konsulko.com wrote:
On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote:
On 4/29/19 1:02 PM, Jagan Teki wrote: > On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut marex@denx.de wrote: >> >> On 4/29/19 12:40 PM, Jagan Teki wrote: >>> On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut marex@denx.de wrote: >>>> >>>> On 4/28/19 10:47 PM, Jagan Teki wrote: >>>>> Mark MXS_SPI has BROKEN, this so the resulting build shows >>>>> warning for broken configuration enabled and associated code >>>>> will remove in v2019.07 release. >>>> >>>> But the code is not broken, it works fine, right ? >>> >>> Yes the code work fine, but dm conversion not done yet. Now the >>> CONFIG_BROKEN can mark the driver configs which doesn't convert dm >> >> That makes no sense, if the code works, it works and thus it is NOT >> broken. Find some other way to flag it as non-DM-converted, not this hack. > > np, It depends on whether we consider non-dm code(for legacy SPI > drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload CONFIG_BROKEN for such things. The Makefile warning seems sufficient to me.
The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN.
Yes, the idea here is to build the broken one by selecting BROKEN so-that the travis-CI is green and have warning on the build, otherwise it is another rework of selecting BROKEN for those non-converted drivers if they depends.
The Makefile warnings tell people the code is going to be removed and I'm trying to have the window be:
- LOUD warning about needing work
- 1 release past those loud deadlines of the code there, but not built
unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken) 3) Code removed.
ie what this series does. Driver (for example) will select BROKEN, that means it is still working bu would like to remove in next versions and so..
What I'm after is https://github.com/trini/u-boot/commits/WIP-BROKEN-test which is close, but not quite there. We no longer build the drivers marked as BROKEN by default, and the fallout from that has been:
- Some missing dependencies (I'm trying to fix that now) leading to build problems.
- Needing to yank CONFIG_SPI for example from configs that had been using a now-not-built driver as the subsystem fails to link if there's no controller. I don't think that's a problem however.
- Needing to migrate a few more symbols to Kconfig in order to be able to properly express "You need to depend on BROKEN to use this option now".
I still disagree with marking drivers that need DM conversion, but are otherwise working perfectly fine, as broken. That's just misleading and in fact incorrect. Invent some new, more descriptive Kconfig option please.
I also still disagree, but, fine, I'll add CONFIG_DEPRECATED.
CONFIG_DM_NEED_MIGRATION or something ?
On Tue, May 14, 2019 at 07:41:07PM +0200, Marek Vasut wrote:
On 5/14/19 7:37 PM, Tom Rini wrote:
On Tue, May 14, 2019 at 07:33:17PM +0200, Marek Vasut wrote:
On 5/14/19 4:45 PM, Tom Rini wrote:
On Tue, May 14, 2019 at 07:46:06PM +0530, Jagan Teki wrote:
On Mon, Apr 29, 2019 at 4:54 PM Tom Rini trini@konsulko.com wrote:
On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote: > On 4/29/19 1:02 PM, Jagan Teki wrote: >> On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut marex@denx.de wrote: >>> >>> On 4/29/19 12:40 PM, Jagan Teki wrote: >>>> On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut marex@denx.de wrote: >>>>> >>>>> On 4/28/19 10:47 PM, Jagan Teki wrote: >>>>>> Mark MXS_SPI has BROKEN, this so the resulting build shows >>>>>> warning for broken configuration enabled and associated code >>>>>> will remove in v2019.07 release. >>>>> >>>>> But the code is not broken, it works fine, right ? >>>> >>>> Yes the code work fine, but dm conversion not done yet. Now the >>>> CONFIG_BROKEN can mark the driver configs which doesn't convert dm >>> >>> That makes no sense, if the code works, it works and thus it is NOT >>> broken. Find some other way to flag it as non-DM-converted, not this hack. >> >> np, It depends on whether we consider non-dm code(for legacy SPI >> drivers) is broken or not, let Tom comment on this. > > Again, the code works, it's not broken. That's very clear. > DM conversion is a separate matter, so let's not overload CONFIG_BROKEN > for such things. The Makefile warning seems sufficient to me.
The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN.
Yes, the idea here is to build the broken one by selecting BROKEN so-that the travis-CI is green and have warning on the build, otherwise it is another rework of selecting BROKEN for those non-converted drivers if they depends.
The Makefile warnings tell people the code is going to be removed and I'm trying to have the window be:
- LOUD warning about needing work
- 1 release past those loud deadlines of the code there, but not built
unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken) 3) Code removed.
ie what this series does. Driver (for example) will select BROKEN, that means it is still working bu would like to remove in next versions and so..
What I'm after is https://github.com/trini/u-boot/commits/WIP-BROKEN-test which is close, but not quite there. We no longer build the drivers marked as BROKEN by default, and the fallout from that has been:
- Some missing dependencies (I'm trying to fix that now) leading to build problems.
- Needing to yank CONFIG_SPI for example from configs that had been using a now-not-built driver as the subsystem fails to link if there's no controller. I don't think that's a problem however.
- Needing to migrate a few more symbols to Kconfig in order to be able to properly express "You need to depend on BROKEN to use this option now".
I still disagree with marking drivers that need DM conversion, but are otherwise working perfectly fine, as broken. That's just misleading and in fact incorrect. Invent some new, more descriptive Kconfig option please.
I also still disagree, but, fine, I'll add CONFIG_DEPRECATED.
CONFIG_DM_NEED_MIGRATION or something ?
No, I think given the definition of deprecated: "to withdraw official support for or discourage the use of (something, such as a software product) in favor of a newer or better alternative" (from https://www.merriam-webster.com/dictionary/deprecated) this is good enough.
Mark SH_SPI has BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.
Signed-off-by: Jagan Teki jagan@amarulasolutions.com --- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 393382fee2..ad66e310e1 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -348,6 +348,7 @@ config DAVINCI_SPI
config SH_SPI bool "SuperH SPI driver" + select BROKEN help Enable the SuperH SPI controller driver. This driver can be used on various SuperH SoCs, such as SH7757.
Mark SOFT_SPI has BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.
Cc: Vasily Khoruzhick anarsoul@gmail.com Signed-off-by: Jagan Teki jagan@amarulasolutions.com --- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index ad66e310e1..9e2eba47f7 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -308,6 +308,7 @@ endif # if DM_SPI
config SOFT_SPI bool "Soft SPI driver" + select BROKEN if !DM_SPI help Enable Soft SPI driver. This driver is to use GPIO simulate the SPI protocol.
Mark FSL_ESPI has BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.
Cc: Oleksandr Zhadan and Michael Durrant arcsupport@arcturusnetworks.com Signed-off-by: Jagan Teki jagan@amarulasolutions.com --- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 9e2eba47f7..55f0d6cf2b 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -328,6 +328,7 @@ config CF_SPI
config FSL_ESPI bool "Freescale eSPI driver" + select BROKEN help Enable the Freescale eSPI driver. This driver can be used to access the SPI interface and SPI NOR flash on platforms embedding
Mark LPC32XX_SSP has BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.
Cc: Vladimir Zapolskiy vz@mleia.com Cc: Albert ARIBAUD albert.aribaud@3adev.fr Signed-off-by: Jagan Teki jagan@amarulasolutions.com --- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 55f0d6cf2b..5fbe17bb20 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -369,6 +369,7 @@ config KIRKWOOD_SPI
config LPC32XX_SSP bool "LPC32XX SPI Driver" + select BROKEN help Enable support for SPI on LPC32xx
Hi Jagan,
On 04/28/2019 11:48 PM, Jagan Teki wrote:
Mark LPC32XX_SSP has BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.
Cc: Vladimir Zapolskiy vz@mleia.com Cc: Albert ARIBAUD albert.aribaud@3adev.fr Signed-off-by: Jagan Teki jagan@amarulasolutions.com
drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 55f0d6cf2b..5fbe17bb20 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -369,6 +369,7 @@ config KIRKWOOD_SPI
config LPC32XX_SSP bool "LPC32XX SPI Driver"
- select BROKEN help Enable support for SPI on LPC32xx
Acked-by: Vladimir Zapolskiy vz@mleia.com
Thank you for the change, as we've discussed earlier I won't have objections against the driver removal when time is up.
Thus you can locally prepare a removal change in advance, the one which you've sent earlier needs a minor update, please also remove lpc32xx_ssp_init() function and its usage in the board files.
-- Best wishes, Vladimir
Acked-by: Sylvain Lemieux slemieux@tycoint.com
On Tue, Apr 30, 2019 at 4:48 PM Vladimir Zapolskiy vz@mleia.com wrote:
Hi Jagan,
On 04/28/2019 11:48 PM, Jagan Teki wrote:
Mark LPC32XX_SSP has BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.
Cc: Vladimir Zapolskiy vz@mleia.com Cc: Albert ARIBAUD albert.aribaud@3adev.fr Signed-off-by: Jagan Teki jagan@amarulasolutions.com
drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 55f0d6cf2b..5fbe17bb20 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -369,6 +369,7 @@ config KIRKWOOD_SPI
config LPC32XX_SSP bool "LPC32XX SPI Driver"
select BROKEN help Enable support for SPI on LPC32xxAcked-by: Vladimir Zapolskiy vz@mleia.com
Thank you for the change, as we've discussed earlier I won't have objections against the driver removal when time is up.
Thus you can locally prepare a removal change in advance, the one which you've sent earlier needs a minor update, please also remove lpc32xx_ssp_init() function and its usage in the board files.
-- Best wishes, Vladimir
participants (7)
-
Heinrich Schuchardt -
Jagan Teki -
Marek Vasut -
Michael Nazzareno Trimarchi -
Sylvain Lemieux -
Tom Rini -
Vladimir Zapolskiy