[U-Boot] How to manage RMOBILE patches?
Dear, Wolfgang Denk.
I am working supporting Renesas RMOBILE to U-Boot. Renesas's RMOBILE SoC family contains an ARM Cortex-A9, and this uses the same IP as SH. (For example, timer, ether, serial, etc.) I already sent to patches of rmobile, I got review from some developers. And the patch is managed by the arm/rmobile branch of u-boot-sh[0] which I have maintained, now. Since I had you take the patch of rmobile into an ARM repository, I consulted with Albert about the future development approach.
We thought two methods are considered. One is Albert picks up a patch from ML to ARM repository, Another is whether to have pull from the repository by having a repository for rmobile made. And we decided to consult by ML.
What do you think about this?
Best regards, Nobuhiro
------- [0]: git://git.denx.de/u-boot-sh.git arm/rmobile
Hideyuki Sano (1): arm: rmobile: Add support for ATMARK-TECHNO Armadillo-800EVA board
Nobuhiro Iwamatsu (20): ARMv7: Add register definition of global timer arm: rmobile: Add basic support for Renesas R-Mobile arm: rmobile: Add support Renesas SH73A0 arm: rmobile: Add support PFC of Renesas SH73A0 arm: rmobile: Add supoprt for KMC KZM-A9-GT board arm: rmobile: Support build with gcc-4.6 or later arm: rmobile: kzm9g: Add LIBFDT support arm: rmobile: kzm9g: remove unrelated config arm: rmobile: Change initializing ICCICR register arm: rmobile: Add support TMU base timer function arm: rmobile: kzm9g: Add CONFIG_GLOBAL_TIMER to board config file arm: rmobile: Add support Renesas R8A7740 arm: rmobile: Add support PFC of Renesas R8A7740 arm: rmobile: armadillo-800eva Remove board_eth_init arm: rmobile: Add cpu_eth_init function rmobile: armadillo-800eva: Change init function of SCIFA1 rmobile: armadillo-800eva: Add Support CONFIG_OF_LIBFDT rmobile: armadillo-800eva: Add Support NFS and BOOTZ command rmobile: armadillo-800eva: Remove CONFIG_SYS_NO_L2CACHE rmobile: Add README
Tetsuyuki Kobayashi (11): arm: rmobile: kzm9g: Modify sdram area arm: rmobile: kzm9g: Adjust low level hardware setting arm: rmobile: kzm9g: change prompt to board specific arm: rmobile: kzm9g: Modify bus controller setting for CS4 arm: rmobile: kzm9g: enable reset command arm: rmobile: kzm9g: Add dummy member to struct sh73a0_rwdt arm: rmobile: kzm9g: Fix CONFIG_BAUDRATE setting arm: rmobile: kzm9g: add NFS_TIMEOUT in config file arm: rmobile: kzm9g: remove unrelated config arm: rmobile: kzm9g: fix CPU info arm: rmobile: kzm9g: separate cpu_rev to integer and fraction
MAINTAINERS | 8 + arch/arm/cpu/armv7/rmobile/Makefile | 59 +++ arch/arm/cpu/armv7/rmobile/board.c | 31 ++ arch/arm/cpu/armv7/rmobile/config.mk | 26 ++ arch/arm/cpu/armv7/rmobile/cpu_info-r8a7740.c | 48 +++ arch/arm/cpu/armv7/rmobile/cpu_info-sh73a0.c | 60 ++++ arch/arm/cpu/armv7/rmobile/cpu_info.c | 85 +++++ arch/arm/cpu/armv7/rmobile/emac.c | 36 ++ arch/arm/cpu/armv7/rmobile/lowlevel_init.S | 98 +++++ arch/arm/cpu/armv7/rmobile/pfc-r8a7740.c | 2612 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ arch/arm/cpu/armv7/rmobile/pfc-sh73a0.c | 2807 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ arch/arm/cpu/armv7/rmobile/timer.c | 97 +++++ arch/arm/include/asm/arch-armv7/globaltimer.h | 36 ++ arch/arm/include/asm/arch-rmobile/gpio.h | 12 + arch/arm/include/asm/arch-rmobile/irqs.h | 18 + arch/arm/include/asm/arch-rmobile/r8a7740-gpio.h | 584 ++++++++++++++++++++++++++++++ arch/arm/include/asm/arch-rmobile/r8a7740.h | 287 +++++++++++++++ arch/arm/include/asm/arch-rmobile/rmobile.h | 14 + arch/arm/include/asm/arch-rmobile/sh73a0-gpio.h | 553 ++++++++++++++++++++++++++++ arch/arm/include/asm/arch-rmobile/sh73a0.h | 289 +++++++++++++++ arch/arm/include/asm/arch-rmobile/sys_proto.h | 29 ++ arch/arm/include/asm/mach-types.h | 26 ++ board/atmark-techno/armadillo-800eva/Makefile | 46 +++ board/atmark-techno/armadillo-800eva/armadillo-800eva.c | 328 +++++++++++++++++ board/kmc/kzm9g/Makefile | 50 +++ board/kmc/kzm9g/kzm9g.c | 377 +++++++++++++++++++ boards.cfg | 2 + doc/README.rmobile | 65 ++++ include/configs/armadillo-800eva.h | 160 +++++++++ include/configs/kzm9g.h | 169 +++++++++ include/sh_tmu.h | 2 +- 31 files changed, 9013 insertions(+), 1 deletion(-) create mode 100644 arch/arm/cpu/armv7/rmobile/Makefile create mode 100644 arch/arm/cpu/armv7/rmobile/board.c create mode 100644 arch/arm/cpu/armv7/rmobile/config.mk create mode 100644 arch/arm/cpu/armv7/rmobile/cpu_info-r8a7740.c create mode 100644 arch/arm/cpu/armv7/rmobile/cpu_info-sh73a0.c create mode 100644 arch/arm/cpu/armv7/rmobile/cpu_info.c create mode 100644 arch/arm/cpu/armv7/rmobile/emac.c create mode 100644 arch/arm/cpu/armv7/rmobile/lowlevel_init.S create mode 100644 arch/arm/cpu/armv7/rmobile/pfc-r8a7740.c create mode 100644 arch/arm/cpu/armv7/rmobile/pfc-sh73a0.c create mode 100644 arch/arm/cpu/armv7/rmobile/timer.c create mode 100644 arch/arm/include/asm/arch-armv7/globaltimer.h create mode 100644 arch/arm/include/asm/arch-rmobile/gpio.h create mode 100644 arch/arm/include/asm/arch-rmobile/irqs.h create mode 100644 arch/arm/include/asm/arch-rmobile/r8a7740-gpio.h create mode 100644 arch/arm/include/asm/arch-rmobile/r8a7740.h create mode 100644 arch/arm/include/asm/arch-rmobile/rmobile.h create mode 100644 arch/arm/include/asm/arch-rmobile/sh73a0-gpio.h create mode 100644 arch/arm/include/asm/arch-rmobile/sh73a0.h create mode 100644 arch/arm/include/asm/arch-rmobile/sys_proto.h create mode 100644 board/atmark-techno/armadillo-800eva/Makefile create mode 100644 board/atmark-techno/armadillo-800eva/armadillo-800eva.c create mode 100644 board/kmc/kzm9g/Makefile create mode 100644 board/kmc/kzm9g/kzm9g.c create mode 100644 doc/README.rmobile create mode 100644 include/configs/armadillo-800eva.h create mode 100644 include/configs/kzm9g.h
Dear Nobuhiro Iwamatsu,
In message CABMQnVLBEEjcEtfTzdeThHfTLp=b24QSOgnFjbZr-8YWYTJUhg@mail.gmail.com you wrote:
I am working supporting Renesas RMOBILE to U-Boot. Renesas's RMOBILE SoC family contains an ARM Cortex-A9, and this uses the same IP as SH. (For example, timer, ether, serial, etc.) I already sent to patches of rmobile, I got review from some developers. And the patch is managed by the arm/rmobile branch of u-boot-sh[0] which I have maintained, now. Since I had you take the patch of rmobile into an ARM repository, I consulted with Albert about the future development approach.
We thought two methods are considered. One is Albert picks up a patch from ML to ARM repository,
As this is ARM code, this appears the most natural approach to me.
Another is whether to have pull from the repository by having a repository for rmobile made.
If this is an ARM SoC, then it should go through the ARM repo - even if we should later decide that there is so much traffic that a separate rmobile repo would be sustified, thi would still be a sub-repo, which Albert would pull from.
Best regards,
Wolfgang Denk
On Mon, Sep 03, 2012 at 09:15:56PM +0200, Wolfgang Denk wrote:
Dear Nobuhiro Iwamatsu,
In message CABMQnVLBEEjcEtfTzdeThHfTLp=b24QSOgnFjbZr-8YWYTJUhg@mail.gmail.com you wrote:
I am working supporting Renesas RMOBILE to U-Boot. Renesas's RMOBILE SoC family contains an ARM Cortex-A9, and this uses the same IP as SH. (For example, timer, ether, serial, etc.) I already sent to patches of rmobile, I got review from some developers. And the patch is managed by the arm/rmobile branch of u-boot-sh[0] which I have maintained, now. Since I had you take the patch of rmobile into an ARM repository, I consulted with Albert about the future development approach.
We thought two methods are considered. One is Albert picks up a patch from ML to ARM repository,
As this is ARM code, this appears the most natural approach to me.
Another is whether to have pull from the repository by having a repository for rmobile made.
If this is an ARM SoC, then it should go through the ARM repo - even if we should later decide that there is so much traffic that a separate rmobile repo would be sustified, thi would still be a sub-repo, which Albert would pull from.
Another option, which Mike is using for, iirc, sf and blackfin, is just to add rmobile-master / rmobile-next as branches to the u-boot-sh repository.
Hi,
On Wed, Sep 5, 2012 at 2:36 AM, Tom Rini trini@ti.com wrote:
On Mon, Sep 03, 2012 at 09:15:56PM +0200, Wolfgang Denk wrote:
Dear Nobuhiro Iwamatsu,
In message CABMQnVLBEEjcEtfTzdeThHfTLp=b24QSOgnFjbZr-8YWYTJUhg@mail.gmail.com you wrote:
I am working supporting Renesas RMOBILE to U-Boot. Renesas's RMOBILE SoC family contains an ARM Cortex-A9, and this uses the same IP as SH. (For example, timer, ether, serial, etc.) I already sent to patches of rmobile, I got review from some developers. And the patch is managed by the arm/rmobile branch of u-boot-sh[0] which I have maintained, now. Since I had you take the patch of rmobile into an ARM repository, I consulted with Albert about the future development approach.
We thought two methods are considered. One is Albert picks up a patch from ML to ARM repository,
As this is ARM code, this appears the most natural approach to me.
Another is whether to have pull from the repository by having a repository for rmobile made.
If this is an ARM SoC, then it should go through the ARM repo - even if we should later decide that there is so much traffic that a separate rmobile repo would be sustified, thi would still be a sub-repo, which Albert would pull from.
Another option, which Mike is using for, iirc, sf and blackfin, is just to add rmobile-master / rmobile-next as branches to the u-boot-sh repository.
Yes, this is one of easy way. But Albert won't pull form u-boot-sh, if If my understanding is not wrong.
Best regards, Nobuhiro
Hi Nobuhiro,
On Wed, 5 Sep 2012 11:26:37 +0900, Nobuhiro Iwamatsu iwamatsu@nigauri.org wrote:
Hi,
On Wed, Sep 5, 2012 at 2:36 AM, Tom Rini trini@ti.com wrote:
On Mon, Sep 03, 2012 at 09:15:56PM +0200, Wolfgang Denk wrote:
Dear Nobuhiro Iwamatsu,
In message CABMQnVLBEEjcEtfTzdeThHfTLp=b24QSOgnFjbZr-8YWYTJUhg@mail.gmail.com you wrote:
I am working supporting Renesas RMOBILE to U-Boot. Renesas's RMOBILE SoC family contains an ARM Cortex-A9, and this uses the same IP as SH. (For example, timer, ether, serial, etc.) I already sent to patches of rmobile, I got review from some developers. And the patch is managed by the arm/rmobile branch of u-boot-sh[0] which I have maintained, now. Since I had you take the patch of rmobile into an ARM repository, I consulted with Albert about the future development approach.
We thought two methods are considered. One is Albert picks up a patch from ML to ARM repository,
As this is ARM code, this appears the most natural approach to me.
Another is whether to have pull from the repository by having a repository for rmobile made.
If this is an ARM SoC, then it should go through the ARM repo - even if we should later decide that there is so much traffic that a separate rmobile repo would be sustified, thi would still be a sub-repo, which Albert would pull from.
Another option, which Mike is using for, iirc, sf and blackfin, is just to add rmobile-master / rmobile-next as branches to the u-boot-sh repository.
Yes, this is one of easy way. But Albert won't pull form u-boot-sh, if If my understanding is not wrong.
This just means that they'll end up on u-boot/master from u-boot.sh (and from there into u-boot-arm later on).
Best regards, Nobuhiro
Amicalement,
On 09/05/2012 04:18 AM, Albert ARIBAUD wrote:
Hi Nobuhiro,
On Wed, 5 Sep 2012 11:26:37 +0900, Nobuhiro Iwamatsu iwamatsu@nigauri.org wrote:
Hi,
On Wed, Sep 5, 2012 at 2:36 AM, Tom Rini trini@ti.com wrote:
On Mon, Sep 03, 2012 at 09:15:56PM +0200, Wolfgang Denk wrote:
Dear Nobuhiro Iwamatsu,
In message CABMQnVLBEEjcEtfTzdeThHfTLp=b24QSOgnFjbZr-8YWYTJUhg@mail.gmail.com you wrote:
I am working supporting Renesas RMOBILE to U-Boot. Renesas's RMOBILE SoC family contains an ARM Cortex-A9, and this uses the same IP as SH. (For example, timer, ether, serial, etc.) I already sent to patches of rmobile, I got review from some developers. And the patch is managed by the arm/rmobile branch of u-boot-sh[0] which I have maintained, now. Since I had you take the patch of rmobile into an ARM repository, I consulted with Albert about the future development approach.
We thought two methods are considered. One is Albert picks up a patch from ML to ARM repository,
As this is ARM code, this appears the most natural approach to me
Another is whether to have pull from the repository by having a repository for rmobile made.
If this is an ARM SoC, then it should go through the ARM repo - even if we should later decide that there is so much traffic that a separate rmobile repo would be sustified, thi would still be a sub-repo, which Albert would pull from.
Another option, which Mike is using for, iirc, sf and blackfin, is just to add rmobile-master / rmobile-next as branches to the u-boot-sh repository.
Yes, this is one of easy way. But Albert won't pull form u-boot-sh, if If my understanding is not wrong.
This just means that they'll end up on u-boot/master from u-boot.sh (and from there into u-boot-arm later on).
To be clear, what I'm saying is just add a few more branches to u-boot-sh that Albert will pull (since they're ARM stuff). Say u-boot-sh/rmobile/master and u-boot-sh/rmobile/next. Then not get too hung up on which repository a merge message comes from. :)
Hi, Tom.
On Wed, Sep 5, 2012 at 11:17 PM, Tom Rini trini@ti.com wrote:
On 09/05/2012 04:18 AM, Albert ARIBAUD wrote:
Hi Nobuhiro,
On Wed, 5 Sep 2012 11:26:37 +0900, Nobuhiro Iwamatsu iwamatsu@nigauri.org wrote:
Hi,
On Wed, Sep 5, 2012 at 2:36 AM, Tom Rini trini@ti.com wrote:
On Mon, Sep 03, 2012 at 09:15:56PM +0200, Wolfgang Denk wrote:
Dear Nobuhiro Iwamatsu,
In message CABMQnVLBEEjcEtfTzdeThHfTLp=b24QSOgnFjbZr-8YWYTJUhg@mail.gmail.com you wrote:
I am working supporting Renesas RMOBILE to U-Boot. Renesas's RMOBILE SoC family contains an ARM Cortex-A9, and this uses the same IP as SH. (For example, timer, ether, serial, etc.) I already sent to patches of rmobile, I got review from some developers. And the patch is managed by the arm/rmobile branch of u-boot-sh[0] which I have maintained, now. Since I had you take the patch of rmobile into an ARM repository, I consulted with Albert about the future development approach.
We thought two methods are considered. One is Albert picks up a patch from ML to ARM repository,
As this is ARM code, this appears the most natural approach to me
Another is whether to have pull from the repository by having a repository for rmobile made.
If this is an ARM SoC, then it should go through the ARM repo - even if we should later decide that there is so much traffic that a separate rmobile repo would be sustified, thi would still be a sub-repo, which Albert would pull from.
Another option, which Mike is using for, iirc, sf and blackfin, is just to add rmobile-master / rmobile-next as branches to the u-boot-sh repository.
Yes, this is one of easy way. But Albert won't pull form u-boot-sh, if If my understanding is not wrong.
This just means that they'll end up on u-boot/master from u-boot.sh (and from there into u-boot-arm later on).
To be clear, what I'm saying is just add a few more branches to u-boot-sh that Albert will pull (since they're ARM stuff). Say u-boot-sh/rmobile/master and u-boot-sh/rmobile/next. Then not get too hung up on which repository a merge message comes from. :)
I was going to do by how to explain you. However, I think that Albert mistook by my shortage of explanation. Thank you for following up.
Nobuhiro
Hi Nobuhiro,
On Thu, 6 Sep 2012 08:20:59 +0900, Nobuhiro Iwamatsu iwamatsu@nigauri.org wrote:
Hi, Tom.
On Wed, Sep 5, 2012 at 11:17 PM, Tom Rini trini@ti.com wrote:
On 09/05/2012 04:18 AM, Albert ARIBAUD wrote:
Hi Nobuhiro,
On Wed, 5 Sep 2012 11:26:37 +0900, Nobuhiro Iwamatsu iwamatsu@nigauri.org wrote:
Hi,
On Wed, Sep 5, 2012 at 2:36 AM, Tom Rini trini@ti.com wrote:
On Mon, Sep 03, 2012 at 09:15:56PM +0200, Wolfgang Denk wrote:
Dear Nobuhiro Iwamatsu,
In message CABMQnVLBEEjcEtfTzdeThHfTLp=b24QSOgnFjbZr-8YWYTJUhg@mail.gmail.com you wrote: > > I am working supporting Renesas RMOBILE to U-Boot. > Renesas's RMOBILE SoC family contains an ARM Cortex-A9, and > this uses the same IP as SH. > (For example, timer, ether, serial, etc.) > I already sent to patches of rmobile, I got review from some > developers. And the patch is managed by the arm/rmobile branch > of u-boot-sh[0] which I have maintained, now. > Since I had you take the patch of rmobile into an ARM > repository, I consulted with Albert about the > future development approach. > > We thought two methods are considered. > One is Albert picks up a patch from ML to ARM repository,
As this is ARM code, this appears the most natural approach to me
> Another is whether to have pull from the repository by having a > repository for rmobile made.
If this is an ARM SoC, then it should go through the ARM repo - even if we should later decide that there is so much traffic that a separate rmobile repo would be sustified, thi would still be a sub-repo, which Albert would pull from.
Another option, which Mike is using for, iirc, sf and blackfin, is just to add rmobile-master / rmobile-next as branches to the u-boot-sh repository.
Yes, this is one of easy way. But Albert won't pull form u-boot-sh, if If my understanding is not wrong.
This just means that they'll end up on u-boot/master from u-boot.sh (and from there into u-boot-arm later on).
To be clear, what I'm saying is just add a few more branches to u-boot-sh that Albert will pull (since they're ARM stuff). Say u-boot-sh/rmobile/master and u-boot-sh/rmobile/next. Then not get too hung up on which repository a merge message comes from. :)
I was going to do by how to explain you. However, I think that Albert mistook by my shortage of explanation. Thank you for following up.
Nobuhiro
I understand that some ARM patches would be stored in some branch (say rmobile/master) of the u-boot-sh repo and pull-requested to me from there.
What I still don't understand is *why* this should be done. Before they get on this branch, the patches would still have to go through the mailing list for review, just like the ARM patches that end up applied to u-boot-arm/master, except they'd have to do through an intermediate branch. If there are benefits in this, someone will have to lay them out for me, because right now I don't see them.
Amicalement,
On 09/06/2012 12:28 PM, Albert ARIBAUD wrote:
Hi Nobuhiro,
On Thu, 6 Sep 2012 08:20:59 +0900, Nobuhiro Iwamatsu iwamatsu@nigauri.org wrote:
Hi, Tom.
On Wed, Sep 5, 2012 at 11:17 PM, Tom Rini trini@ti.com wrote:
On 09/05/2012 04:18 AM, Albert ARIBAUD wrote:
Hi Nobuhiro,
On Wed, 5 Sep 2012 11:26:37 +0900, Nobuhiro Iwamatsu iwamatsu@nigauri.org wrote:
Hi,
On Wed, Sep 5, 2012 at 2:36 AM, Tom Rini trini@ti.com wrote:
On Mon, Sep 03, 2012 at 09:15:56PM +0200, Wolfgang Denk wrote: > Dear Nobuhiro Iwamatsu, > > In message > CABMQnVLBEEjcEtfTzdeThHfTLp=b24QSOgnFjbZr-8YWYTJUhg@mail.gmail.com > you wrote: >> >> I am working supporting Renesas RMOBILE to U-Boot. >> Renesas's RMOBILE SoC family contains an ARM Cortex-A9, and >> this uses the same IP as SH. >> (For example, timer, ether, serial, etc.) >> I already sent to patches of rmobile, I got review from some >> developers. And the patch is managed by the arm/rmobile branch >> of u-boot-sh[0] which I have maintained, now. >> Since I had you take the patch of rmobile into an ARM >> repository, I consulted with Albert about the >> future development approach. >> >> We thought two methods are considered. >> One is Albert picks up a patch from ML to ARM repository, > > As this is ARM code, this appears the most natural approach to > me > >> Another is whether to have pull from the repository by having a >> repository for rmobile made. > > If this is an ARM SoC, then it should go through the ARM repo - > even if we should later decide that there is so much traffic > that a separate rmobile repo would be sustified, thi would > still be a sub-repo, which Albert would pull from.
Another option, which Mike is using for, iirc, sf and blackfin, is just to add rmobile-master / rmobile-next as branches to the u-boot-sh repository.
Yes, this is one of easy way. But Albert won't pull form u-boot-sh, if If my understanding is not wrong.
This just means that they'll end up on u-boot/master from u-boot.sh (and from there into u-boot-arm later on).
To be clear, what I'm saying is just add a few more branches to u-boot-sh that Albert will pull (since they're ARM stuff). Say u-boot-sh/rmobile/master and u-boot-sh/rmobile/next. Then not get too hung up on which repository a merge message comes from. :)
I was going to do by how to explain you. However, I think that Albert mistook by my shortage of explanation. Thank you for following up.
Nobuhiro
I understand that some ARM patches would be stored in some branch (say rmobile/master) of the u-boot-sh repo and pull-requested to me from there.
What I still don't understand is *why* this should be done. Before they get on this branch, the patches would still have to go through the mailing list for review, just like the ARM patches that end up applied to u-boot-arm/master, except they'd have to do through an intermediate branch. If there are benefits in this, someone will have to lay them out for me, because right now I don't see them.
I think the answer is, given how you wish to work, there's not. It's a workflow problem only. If it's no easier for you to get a pull request from Nobuhiro once the patches have been reviewed than for you to pull them out of patchwork once they have been reviewed, then since your preference is for patchwork, via patchwork and into u-boot-arm is how they'll work.
Hi Tom,
On Thu, 6 Sep 2012 13:58:57 -0700, Tom Rini trini@ti.com wrote:
On 09/06/2012 12:28 PM, Albert ARIBAUD wrote:
Hi Nobuhiro,
On Thu, 6 Sep 2012 08:20:59 +0900, Nobuhiro Iwamatsu iwamatsu@nigauri.org wrote:
Hi, Tom.
On Wed, Sep 5, 2012 at 11:17 PM, Tom Rini trini@ti.com wrote:
On 09/05/2012 04:18 AM, Albert ARIBAUD wrote:
Hi Nobuhiro,
On Wed, 5 Sep 2012 11:26:37 +0900, Nobuhiro Iwamatsu iwamatsu@nigauri.org wrote:
Hi,
On Wed, Sep 5, 2012 at 2:36 AM, Tom Rini trini@ti.com wrote: > On Mon, Sep 03, 2012 at 09:15:56PM +0200, Wolfgang Denk wrote: >> Dear Nobuhiro Iwamatsu, >> >> In message >> CABMQnVLBEEjcEtfTzdeThHfTLp=b24QSOgnFjbZr-8YWYTJUhg@mail.gmail.com >> you wrote: >>> >>> I am working supporting Renesas RMOBILE to U-Boot. >>> Renesas's RMOBILE SoC family contains an ARM Cortex-A9, and >>> this uses the same IP as SH. >>> (For example, timer, ether, serial, etc.) >>> I already sent to patches of rmobile, I got review from some >>> developers. And the patch is managed by the arm/rmobile >>> branch of u-boot-sh[0] which I have maintained, now. >>> Since I had you take the patch of rmobile into an ARM >>> repository, I consulted with Albert about the >>> future development approach. >>> >>> We thought two methods are considered. >>> One is Albert picks up a patch from ML to ARM repository, >> >> As this is ARM code, this appears the most natural approach to >> me >> >>> Another is whether to have pull from the repository by >>> having a repository for rmobile made. >> >> If this is an ARM SoC, then it should go through the ARM repo >> - even if we should later decide that there is so much traffic >> that a separate rmobile repo would be sustified, thi would >> still be a sub-repo, which Albert would pull from. > > Another option, which Mike is using for, iirc, sf and blackfin, > is just to add rmobile-master / rmobile-next as branches to the > u-boot-sh repository.
Yes, this is one of easy way. But Albert won't pull form u-boot-sh, if If my understanding is not wrong.
This just means that they'll end up on u-boot/master from u-boot.sh (and from there into u-boot-arm later on).
To be clear, what I'm saying is just add a few more branches to u-boot-sh that Albert will pull (since they're ARM stuff). Say u-boot-sh/rmobile/master and u-boot-sh/rmobile/next. Then not get too hung up on which repository a merge message comes from. :)
I was going to do by how to explain you. However, I think that Albert mistook by my shortage of explanation. Thank you for following up.
Nobuhiro
I understand that some ARM patches would be stored in some branch (say rmobile/master) of the u-boot-sh repo and pull-requested to me from there.
What I still don't understand is *why* this should be done. Before they get on this branch, the patches would still have to go through the mailing list for review, just like the ARM patches that end up applied to u-boot-arm/master, except they'd have to do through an intermediate branch. If there are benefits in this, someone will have to lay them out for me, because right now I don't see them.
I think the answer is, given how you wish to work, there's not. It's a workflow problem only. If it's no easier for you to get a pull request from Nobuhiro once the patches have been reviewed than for you to pull them out of patchwork once they have been reviewed, then since your preference is for patchwork, via patchwork and into u-boot-arm is how they'll work.
Thanks for this answer. I personally prefer applying patches from patchwork directly into u-boot-arm/master.
Amicalement,
Hi,
On Sat, Sep 8, 2012 at 2:09 AM, Albert ARIBAUD albert.u.boot@aribaud.net wrote:
Hi Tom,
On Thu, 6 Sep 2012 13:58:57 -0700, Tom Rini trini@ti.com wrote:
On 09/06/2012 12:28 PM, Albert ARIBAUD wrote:
Hi Nobuhiro,
On Thu, 6 Sep 2012 08:20:59 +0900, Nobuhiro Iwamatsu iwamatsu@nigauri.org wrote:
Hi, Tom.
On Wed, Sep 5, 2012 at 11:17 PM, Tom Rini trini@ti.com wrote:
On 09/05/2012 04:18 AM, Albert ARIBAUD wrote:
Hi Nobuhiro,
On Wed, 5 Sep 2012 11:26:37 +0900, Nobuhiro Iwamatsu iwamatsu@nigauri.org wrote:
> Hi, > > On Wed, Sep 5, 2012 at 2:36 AM, Tom Rini trini@ti.com wrote: >> On Mon, Sep 03, 2012 at 09:15:56PM +0200, Wolfgang Denk wrote: >>> Dear Nobuhiro Iwamatsu, >>> >>> In message >>> CABMQnVLBEEjcEtfTzdeThHfTLp=b24QSOgnFjbZr-8YWYTJUhg@mail.gmail.com >>> you wrote: >>>> >>>> I am working supporting Renesas RMOBILE to U-Boot. >>>> Renesas's RMOBILE SoC family contains an ARM Cortex-A9, and >>>> this uses the same IP as SH. >>>> (For example, timer, ether, serial, etc.) >>>> I already sent to patches of rmobile, I got review from some >>>> developers. And the patch is managed by the arm/rmobile >>>> branch of u-boot-sh[0] which I have maintained, now. >>>> Since I had you take the patch of rmobile into an ARM >>>> repository, I consulted with Albert about the >>>> future development approach. >>>> >>>> We thought two methods are considered. >>>> One is Albert picks up a patch from ML to ARM repository, >>> >>> As this is ARM code, this appears the most natural approach to >>> me >>> >>>> Another is whether to have pull from the repository by >>>> having a repository for rmobile made. >>> >>> If this is an ARM SoC, then it should go through the ARM repo >>> - even if we should later decide that there is so much traffic >>> that a separate rmobile repo would be sustified, thi would >>> still be a sub-repo, which Albert would pull from. >> >> Another option, which Mike is using for, iirc, sf and blackfin, >> is just to add rmobile-master / rmobile-next as branches to the >> u-boot-sh repository. > > Yes, this is one of easy way. But Albert won't pull form > u-boot-sh, if If my understanding is not wrong.
This just means that they'll end up on u-boot/master from u-boot.sh (and from there into u-boot-arm later on).
To be clear, what I'm saying is just add a few more branches to u-boot-sh that Albert will pull (since they're ARM stuff). Say u-boot-sh/rmobile/master and u-boot-sh/rmobile/next. Then not get too hung up on which repository a merge message comes from. :)
I was going to do by how to explain you. However, I think that Albert mistook by my shortage of explanation. Thank you for following up.
Nobuhiro
I understand that some ARM patches would be stored in some branch (say rmobile/master) of the u-boot-sh repo and pull-requested to me from there.
What I still don't understand is *why* this should be done. Before they get on this branch, the patches would still have to go through the mailing list for review, just like the ARM patches that end up applied to u-boot-arm/master, except they'd have to do through an intermediate branch. If there are benefits in this, someone will have to lay them out for me, because right now I don't see them.
I think the answer is, given how you wish to work, there's not. It's a workflow problem only. If it's no easier for you to get a pull request from Nobuhiro once the patches have been reviewed than for you to pull them out of patchwork once they have been reviewed, then since your preference is for patchwork, via patchwork and into u-boot-arm is how they'll work.
Thanks for this answer. I personally prefer applying patches from patchwork directly into u-boot-arm/master.
OK, could you pickup rmobile patches from patchwork, please? But I already archived rmobile patches in patchwork......
Best regards, Nobuhiro
Hi,
ping....
Best regards, Nobuhiro
On Mon, Sep 10, 2012 at 9:41 AM, Nobuhiro Iwamatsu iwamatsu@nigauri.org wrote:
Hi,
On Sat, Sep 8, 2012 at 2:09 AM, Albert ARIBAUD albert.u.boot@aribaud.net wrote:
Hi Tom,
On Thu, 6 Sep 2012 13:58:57 -0700, Tom Rini trini@ti.com wrote:
On 09/06/2012 12:28 PM, Albert ARIBAUD wrote:
Hi Nobuhiro,
On Thu, 6 Sep 2012 08:20:59 +0900, Nobuhiro Iwamatsu iwamatsu@nigauri.org wrote:
Hi, Tom.
On Wed, Sep 5, 2012 at 11:17 PM, Tom Rini trini@ti.com wrote:
On 09/05/2012 04:18 AM, Albert ARIBAUD wrote: > Hi Nobuhiro, > > On Wed, 5 Sep 2012 11:26:37 +0900, Nobuhiro Iwamatsu > iwamatsu@nigauri.org wrote: > >> Hi, >> >> On Wed, Sep 5, 2012 at 2:36 AM, Tom Rini trini@ti.com wrote: >>> On Mon, Sep 03, 2012 at 09:15:56PM +0200, Wolfgang Denk wrote: >>>> Dear Nobuhiro Iwamatsu, >>>> >>>> In message >>>> CABMQnVLBEEjcEtfTzdeThHfTLp=b24QSOgnFjbZr-8YWYTJUhg@mail.gmail.com >>>> you wrote: >>>>> >>>>> I am working supporting Renesas RMOBILE to U-Boot. >>>>> Renesas's RMOBILE SoC family contains an ARM Cortex-A9, and >>>>> this uses the same IP as SH. >>>>> (For example, timer, ether, serial, etc.) >>>>> I already sent to patches of rmobile, I got review from some >>>>> developers. And the patch is managed by the arm/rmobile >>>>> branch of u-boot-sh[0] which I have maintained, now. >>>>> Since I had you take the patch of rmobile into an ARM >>>>> repository, I consulted with Albert about the >>>>> future development approach. >>>>> >>>>> We thought two methods are considered. >>>>> One is Albert picks up a patch from ML to ARM repository, >>>> >>>> As this is ARM code, this appears the most natural approach to >>>> me >>>> >>>>> Another is whether to have pull from the repository by >>>>> having a repository for rmobile made. >>>> >>>> If this is an ARM SoC, then it should go through the ARM repo >>>> - even if we should later decide that there is so much traffic >>>> that a separate rmobile repo would be sustified, thi would >>>> still be a sub-repo, which Albert would pull from. >>> >>> Another option, which Mike is using for, iirc, sf and blackfin, >>> is just to add rmobile-master / rmobile-next as branches to the >>> u-boot-sh repository. >> >> Yes, this is one of easy way. But Albert won't pull form >> u-boot-sh, if If my understanding is not wrong. > > This just means that they'll end up on u-boot/master from > u-boot.sh (and from there into u-boot-arm later on).
To be clear, what I'm saying is just add a few more branches to u-boot-sh that Albert will pull (since they're ARM stuff). Say u-boot-sh/rmobile/master and u-boot-sh/rmobile/next. Then not get too hung up on which repository a merge message comes from. :)
I was going to do by how to explain you. However, I think that Albert mistook by my shortage of explanation. Thank you for following up.
Nobuhiro
I understand that some ARM patches would be stored in some branch (say rmobile/master) of the u-boot-sh repo and pull-requested to me from there.
What I still don't understand is *why* this should be done. Before they get on this branch, the patches would still have to go through the mailing list for review, just like the ARM patches that end up applied to u-boot-arm/master, except they'd have to do through an intermediate branch. If there are benefits in this, someone will have to lay them out for me, because right now I don't see them.
I think the answer is, given how you wish to work, there's not. It's a workflow problem only. If it's no easier for you to get a pull request from Nobuhiro once the patches have been reviewed than for you to pull them out of patchwork once they have been reviewed, then since your preference is for patchwork, via patchwork and into u-boot-arm is how they'll work.
Thanks for this answer. I personally prefer applying patches from patchwork directly into u-boot-arm/master.
OK, could you pickup rmobile patches from patchwork, please? But I already archived rmobile patches in patchwork......
Best regards, Nobuhiro
-- Nobuhiro Iwamatsu iwamatsu at {nigauri.org / debian.org} GPG ID: 40AD1FA6
HI, Albert.
On Fri, Sep 7, 2012 at 4:28 AM, Albert ARIBAUD albert.u.boot@aribaud.net wrote:
Hi Nobuhiro,
On Thu, 6 Sep 2012 08:20:59 +0900, Nobuhiro Iwamatsu iwamatsu@nigauri.org wrote:
Hi, Tom.
On Wed, Sep 5, 2012 at 11:17 PM, Tom Rini trini@ti.com wrote:
On 09/05/2012 04:18 AM, Albert ARIBAUD wrote:
Hi Nobuhiro,
On Wed, 5 Sep 2012 11:26:37 +0900, Nobuhiro Iwamatsu iwamatsu@nigauri.org wrote:
Hi,
On Wed, Sep 5, 2012 at 2:36 AM, Tom Rini trini@ti.com wrote:
On Mon, Sep 03, 2012 at 09:15:56PM +0200, Wolfgang Denk wrote: > Dear Nobuhiro Iwamatsu, > > In message > CABMQnVLBEEjcEtfTzdeThHfTLp=b24QSOgnFjbZr-8YWYTJUhg@mail.gmail.com > you wrote: >> >> I am working supporting Renesas RMOBILE to U-Boot. >> Renesas's RMOBILE SoC family contains an ARM Cortex-A9, and >> this uses the same IP as SH. >> (For example, timer, ether, serial, etc.) >> I already sent to patches of rmobile, I got review from some >> developers. And the patch is managed by the arm/rmobile branch >> of u-boot-sh[0] which I have maintained, now. >> Since I had you take the patch of rmobile into an ARM >> repository, I consulted with Albert about the >> future development approach. >> >> We thought two methods are considered. >> One is Albert picks up a patch from ML to ARM repository, > > As this is ARM code, this appears the most natural approach to > me > >> Another is whether to have pull from the repository by having a >> repository for rmobile made. > > If this is an ARM SoC, then it should go through the ARM repo - > even if we should later decide that there is so much traffic > that a separate rmobile repo would be sustified, thi would > still be a sub-repo, which Albert would pull from.
Another option, which Mike is using for, iirc, sf and blackfin, is just to add rmobile-master / rmobile-next as branches to the u-boot-sh repository.
Yes, this is one of easy way. But Albert won't pull form u-boot-sh, if If my understanding is not wrong.
This just means that they'll end up on u-boot/master from u-boot.sh (and from there into u-boot-arm later on).
To be clear, what I'm saying is just add a few more branches to u-boot-sh that Albert will pull (since they're ARM stuff). Say u-boot-sh/rmobile/master and u-boot-sh/rmobile/next. Then not get too hung up on which repository a merge message comes from. :)
I was going to do by how to explain you. However, I think that Albert mistook by my shortage of explanation. Thank you for following up.
Nobuhiro
I understand that some ARM patches would be stored in some branch (say rmobile/master) of the u-boot-sh repo and pull-requested to me from there.
What I still don't understand is *why* this should be done. Before they get on this branch, the patches would still have to go through the mailing list for review, just like the ARM patches that end up applied to u-boot-arm/master, except they'd have to do through an intermediate branch. If there are benefits in this, someone will have to lay them out for me, because right now I don't see them.
Because I thought that it was easier to manage patches as Tom was also written. OK, I understood your thought.
Best regards, Nobuhiro
Hi,
On Tue, Sep 4, 2012 at 4:15 AM, Wolfgang Denk wd@denx.de wrote:
Dear Nobuhiro Iwamatsu,
In message CABMQnVLBEEjcEtfTzdeThHfTLp=b24QSOgnFjbZr-8YWYTJUhg@mail.gmail.com you wrote:
I am working supporting Renesas RMOBILE to U-Boot. Renesas's RMOBILE SoC family contains an ARM Cortex-A9, and this uses the same IP as SH. (For example, timer, ether, serial, etc.) I already sent to patches of rmobile, I got review from some developers. And the patch is managed by the arm/rmobile branch of u-boot-sh[0] which I have maintained, now. Since I had you take the patch of rmobile into an ARM repository, I consulted with Albert about the future development approach.
We thought two methods are considered. One is Albert picks up a patch from ML to ARM repository,
As this is ARM code, this appears the most natural approach to me.
Another is whether to have pull from the repository by having a repository for rmobile made.
If this is an ARM SoC, then it should go through the ARM repo - even if we should later decide that there is so much traffic that a separate rmobile repo would be sustified, thi would still be a sub-repo, which Albert would pull from.
Yes, I understood these. But Albert said "I won't pull from u-boot-sh.git. becauase this repository is not ARM tree." in the inside of mail with him. I think that I also want rmobile to receive request-pull like other ARM SoCs if possible. Of course, I want to take precedence to the code of rmobile being taken in.
Best regards, Nobuhiro
participants (4)
-
Albert ARIBAUD -
Nobuhiro Iwamatsu -
Tom Rini -
Wolfgang Denk