On 04/25/2012 03:11 PM, Eric Nelson wrote:

On 04/25/2012 12:10 PM, Eric Nelson wrote:

...

On 04/25/2012 11:40 AM, Fabio Estevam wrote:

...

Hi,

On Stefano´s tree I see this sata patch for mx5/mx6: http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commit;h=6931bd30d03de827c52bf...

Has anyone tried sata support on mx6qsabrelite yet?

Any patches missing that were not applied?

I don't have a way to test it at the moment, but I have a colleague that wants to use sata on mx6qsabrelite.

Hi Fabio,

I've tried it and it just worked for me, but it's been a month or so.

It looks like I'm a bit forgetful.

It didn't __just work__. It required a couple of patches that seem to be lingering: http://patchwork.ozlabs.org/patch/148600/ http://patchwork.ozlabs.org/patch/148599/

...

I'll dig out my SATA drive and test again this afternoon.

I'll rebase and test.

Hi Fabio,

I just re-based and re-sent two of the three patches needed to get SATA up and running against mainline/master.

MX6QSABRELITE U-Boot > sata init AHCI 0001.0300 32 slots 1 ports 3 Gbps 0x1 impl SATA mode flags: ncq stag pm led clo only pmp pio slum part SATA Device Info: S/N: 26EK5486T Product model number: TOSHIBA MK4032GSX Firmware version: AS212D Capacity: 75200265 sectors MX6QSABRELITE U-Boot > ext2ls sata 0:1 / <DIR> 4096 . <DIR> 4096 .. <DIR> 16384 lost+found <DIR> 4096 bin <DIR> 4096 mnt <DIR> 4096 lib <DIR> 4096 var <DIR> 4096 root

The third commit is Stefano's SATA driver for i.MX5/6:

http://git.denx.de/u-boot-imx.git/?p=u-boot/u-boot-imx.git;a=commit;h=6931bd...

The two new patches are here: http://lists.denx.de/pipermail/u-boot/2012-April/123168.html and here: http://lists.denx.de/pipermail/u-boot/2012-April/123169.html

Regards,

Eric

On 26/04/2012 00:11, Eric Nelson wrote:

On 04/25/2012 12:10 PM, Eric Nelson wrote:

...

On 04/25/2012 11:40 AM, Fabio Estevam wrote:

...

Hi,

On Stefano´s tree I see this sata patch for mx5/mx6: http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commit;h=6931bd30d03de827c52bf...

Has anyone tried sata support on mx6qsabrelite yet?

Any patches missing that were not applied?

I don't have a way to test it at the moment, but I have a colleague that wants to use sata on mx6qsabrelite.

Hi Fabio,

I've tried it and it just worked for me, but it's been a month or so.

It looks like I'm a bit forgetful.

It didn't __just work__. It required a couple of patches that seem to be lingering: http://patchwork.ozlabs.org/patch/148600/ http://patchwork.ozlabs.org/patch/148599/

...

I'll dig out my SATA drive and test again this afternoon.

I'll rebase and test.

Stefano, I'm not sure if the second patch above is on my plate or yours.

Sorry for late answer. From my point of view, I was waiting for new version of the patch.

I'll review the history and see. I think you had asked for a meaningful error code instead of returning -1,

No, a very minor comment - only returning immediately. I see you did already in V3 ;-).

Best regards, Stefano Babic