[U-Boot] [PATCH] test: hexdump: fix misplaced return

One of the hexdump tests in test/lib/hexdump.c returns right at the start of the function without testing anything.
Fix this by moving the 'return 0;' statement to the end of the function.
Signed-off-by: Simon Goldschmidt simon.k.r.goldschmidt@gmail.com ---
test/lib/hexdump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/test/lib/hexdump.c b/test/lib/hexdump.c index e8b3e566e0..567b57686a 100644 --- a/test/lib/hexdump.c +++ b/test/lib/hexdump.c @@ -11,8 +11,6 @@
static int lib_test_hex_to_bin(struct unit_test_state *uts) { - return 0; - ut_asserteq(0x0, hex_to_bin('0')); ut_asserteq(0x1, hex_to_bin('1')); ut_asserteq(0x2, hex_to_bin('2')); @@ -30,6 +28,8 @@ static int lib_test_hex_to_bin(struct unit_test_state *uts) ut_asserteq(0xe, hex_to_bin('e')); ut_asserteq(0xf, hex_to_bin('f')); ut_asserteq(-1, hex_to_bin('g')); + + return 0; }
DM_TEST(lib_test_hex_to_bin, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);

On Tue, 4 Dec 2018 at 13:30, Simon Goldschmidt simon.k.r.goldschmidt@gmail.com wrote:
One of the hexdump tests in test/lib/hexdump.c returns right at the start of the function without testing anything.
Fix this by moving the 'return 0;' statement to the end of the function.
Signed-off-by: Simon Goldschmidt simon.k.r.goldschmidt@gmail.com
test/lib/hexdump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
That's one way to make a test pass.
Reviewed-by: Simon Glass sjg@chromium.org

Am 05.12.2018 um 13:55 schrieb Simon Glass:
On Tue, 4 Dec 2018 at 13:30, Simon Goldschmidt simon.k.r.goldschmidt@gmail.com wrote:
One of the hexdump tests in test/lib/hexdump.c returns right at the start of the function without testing anything.
Fix this by moving the 'return 0;' statement to the end of the function.
Signed-off-by: Simon Goldschmidt simon.k.r.goldschmidt@gmail.com
test/lib/hexdump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
That's one way to make a test pass.
Reviewed-by: Simon Glass sjg@chromium.org
Is there a plan to make all tests under test/ run with 'make check'? Seems like this one is not included there?
Simon

On Sun, 9 Dec 2018 at 13:53, Simon Goldschmidt simon.k.r.goldschmidt@gmail.com wrote:
Am 05.12.2018 um 13:55 schrieb Simon Glass:
On Tue, 4 Dec 2018 at 13:30, Simon Goldschmidt simon.k.r.goldschmidt@gmail.com wrote:
One of the hexdump tests in test/lib/hexdump.c returns right at the start of the function without testing anything.
Fix this by moving the 'return 0;' statement to the end of the function.
Signed-off-by: Simon Goldschmidt simon.k.r.goldschmidt@gmail.com
test/lib/hexdump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
That's one way to make a test pass.
Reviewed-by: Simon Glass sjg@chromium.org
Is there a plan to make all tests under test/ run with 'make check'? Seems like this one is not included there?
Yes I agree, it needs to be added.
- Simon

On Tue, Dec 04, 2018 at 09:30:08PM +0100, Simon Goldschmidt wrote:
One of the hexdump tests in test/lib/hexdump.c returns right at the start of the function without testing anything.
Fix this by moving the 'return 0;' statement to the end of the function.
Signed-off-by: Simon Goldschmidt simon.k.r.goldschmidt@gmail.com Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot/master, thanks!
participants (3)
-
Simon Glass
-
Simon Goldschmidt
-
Tom Rini