[U-Boot] [PATCH] ARM: da850evm: Remove DM_I2C_COMPAT

The da850evm does not need this enabled, so this removes a notice that appears during compile time that says "Please remove"
Signed-off-by: Adam Ford aford173@gmail.com
diff --git a/configs/da850_am18xxevm_defconfig b/configs/da850_am18xxevm_defconfig index 6745cd10fa..c3d7cff18e 100644 --- a/configs/da850_am18xxevm_defconfig +++ b/configs/da850_am18xxevm_defconfig @@ -39,7 +39,6 @@ CONFIG_ENV_IS_IN_SPI_FLASH=y CONFIG_DM=y CONFIG_DA8XX_GPIO=y CONFIG_DM_I2C=y -CONFIG_DM_I2C_COMPAT=y CONFIG_SYS_I2C_DAVINCI=y CONFIG_MTD_DEVICE=y CONFIG_MTD_PARTITIONS=y diff --git a/configs/da850evm_direct_nor_defconfig b/configs/da850evm_direct_nor_defconfig index 8ea522af93..b7423034db 100644 --- a/configs/da850evm_direct_nor_defconfig +++ b/configs/da850evm_direct_nor_defconfig @@ -40,7 +40,6 @@ CONFIG_DM=y CONFIG_BLK=y CONFIG_DA8XX_GPIO=y CONFIG_DM_I2C=y -CONFIG_DM_I2C_COMPAT=y CONFIG_SYS_I2C_DAVINCI=y # CONFIG_MMC is not set CONFIG_MTD_NOR_FLASH=y diff --git a/include/configs/da850evm.h b/include/configs/da850evm.h index 319f6aadf5..167bd4b5c4 100644 --- a/include/configs/da850evm.h +++ b/include/configs/da850evm.h @@ -26,7 +26,6 @@ #undef CONFIG_DM_SPI #undef CONFIG_DM_SPI_FLASH #undef CONFIG_DM_I2C -#undef CONFIG_DM_I2C_COMPAT #endif /* * SoC Configuration

On Sun, Sep 30, 2018 at 09:20:13AM -0500, Adam Ford wrote:
The da850evm does not need this enabled, so this removes a notice that appears during compile time that says "Please remove"
Signed-off-by: Adam Ford aford173@gmail.com
NAK, this breaks da850_am18xxevm which, ahem, you're listed as the maintainer of :)

On Sat, Oct 6, 2018 at 1:06 PM Tom Rini trini@konsulko.com wrote:
On Sun, Sep 30, 2018 at 09:20:13AM -0500, Adam Ford wrote:
The da850evm does not need this enabled, so this removes a notice that appears during compile time that says "Please remove"
Signed-off-by: Adam Ford aford173@gmail.com
NAK, this breaks da850_am18xxevm which, ahem, you're listed as the maintainer of :)
(facepalm) I don't know what I was thinking. I must have had something else going which made it compile.
On a separate note, I'd like to relinquish maintainership of just da850_am18xxevm since I don't have that hardware, and it was not made by Logic PD. The other remaining boards I have, so I can continue to do that. Looking at the maintainer readme stuff, I cannot tell of the proper syntax to orphan just one defconfig since they appear to me sharing a lot of the same code.
Can you off me a suggestion? I could just delete it from the list of boards I maintain, but it seems like, it should be moved into it's own category, but I don't want to imply the rest have been orphaned.
adam
-- Tom

On Sun, Oct 07, 2018 at 08:46:13AM -0500, Adam Ford wrote:
On Sat, Oct 6, 2018 at 1:06 PM Tom Rini trini@konsulko.com wrote:
On Sun, Sep 30, 2018 at 09:20:13AM -0500, Adam Ford wrote:
The da850evm does not need this enabled, so this removes a notice that appears during compile time that says "Please remove"
Signed-off-by: Adam Ford aford173@gmail.com
NAK, this breaks da850_am18xxevm which, ahem, you're listed as the maintainer of :)
(facepalm) I don't know what I was thinking. I must have had something else going which made it compile.
On a separate note, I'd like to relinquish maintainership of just da850_am18xxevm since I don't have that hardware, and it was not made by Logic PD. The other remaining boards I have, so I can continue to do that. Looking at the maintainer readme stuff, I cannot tell of the proper syntax to orphan just one defconfig since they appear to me sharing a lot of the same code.
Can you off me a suggestion? I could just delete it from the list of boards I maintain, but it seems like, it should be moved into it's own category, but I don't want to imply the rest have been orphaned.
I think you'll need to re-org the file to have a new entry just for that board and mark it as orphaned. Thanks!
participants (2)
-
Adam Ford
-
Tom Rini